From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF34C7EE2F for ; Fri, 3 Mar 2023 15:28:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA56C6B0072; Fri, 3 Mar 2023 10:28:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C55A96B0073; Fri, 3 Mar 2023 10:28:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACF5C6B0074; Fri, 3 Mar 2023 10:28:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9961B6B0072 for ; Fri, 3 Mar 2023 10:28:44 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5766E80397 for ; Fri, 3 Mar 2023 15:28:44 +0000 (UTC) X-FDA: 80527969368.15.00BBF39 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf26.hostedemail.com (Postfix) with ESMTP id 4355714001B for ; Fri, 3 Mar 2023 15:28:42 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dr+oLHzc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="933j/fR/"; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677857322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L8AyWiAIq00eH63iNHHtdW6GZAdQH8mZn7Eq8c9MeEw=; b=P2Xk/+Ar8Kwv38+sCucAvU1KOnR2CsJKoy9Fiz74rpYxgCnhAeRWBKtffqhgx/YFH3UftB nfxcmMwWUpgkS+8akMEC3OmjfeOuesr0OiXImZp+HjKO79azI0E97ccL1nWfFSrsu6sfJi swr068ZgovlY/bTaURJ6MXgEKNaE+Co= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dr+oLHzc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="933j/fR/"; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677857322; a=rsa-sha256; cv=none; b=dvi0ZehKpTsbSW1iO7+CUMoF559XDr11GWl3IPEb7tN7qdd0DbXip/DBXaCxwUXBIO4VRa +LOic07WzZY6A9xrqZQcAq9yaNXhsR6ERYGK3x28pWXFCdDP2snJAW3c9tcySDAq267cBp ZXp2po3VbQZ8LbVeAGQ1VH4bm//oQbs= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 90ABA22CB1; Fri, 3 Mar 2023 15:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1677857320; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L8AyWiAIq00eH63iNHHtdW6GZAdQH8mZn7Eq8c9MeEw=; b=dr+oLHzclmXO04/iJ9ki90C5t7maT5EUjsDO6UqNQmS5qsM/U7HsjCoKEqAvk+b7yRS8Z9 UMOWnaO0czslTE9wwRStMuiaT/Sh91vSWzXHUJEk9yN6dpWvKs9efWAMDYY5sUBSAK5qSE +emINk7vBQu5tSZFQK3v29U9GUdLS2E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1677857320; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L8AyWiAIq00eH63iNHHtdW6GZAdQH8mZn7Eq8c9MeEw=; b=933j/fR/dfZkxvtKeDKbP5LGrgSyjKVLpT6IWqNfB6CdpD5bcQLSgbzDx1PslqcBl2CETr +HLaOVsTiknBfLAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 074B0139D3; Fri, 3 Mar 2023 15:28:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hsfpACgSAmQHOwAAMHmgww (envelope-from ); Fri, 03 Mar 2023 15:28:40 +0000 Message-ID: Date: Fri, 3 Mar 2023 16:28:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC v8 12/56] x86/sev: Add RMP entry lookup helpers Content-Language: en-US To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, Brijesh Singh References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-13-michael.roth@amd.com> From: Vlastimil Babka In-Reply-To: <20230220183847.59159-13-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4355714001B X-Stat-Signature: s4yjpoao8dettkpjwjmmjmo9pdknemj8 X-HE-Tag: 1677857322-179537 X-HE-Meta: U2FsdGVkX18iJsCMfoJ4mupbFKQOqlWYvXfam6COLGhKXLMURmMp2BLRe7xuvWfEejo0zZGWoOaT6AXzmLqTeaeBYecLDNtiAErxBXZXtC6CtSLzFYTDUbPP5RiPOsIz7P21SeqaXjUtXB1gQIdz6jXcQcuystNbjOOJLFBcQLWnFpaRcPNkxw4B/dDZ8IVejmAVvNcC2hAMakKX03gHVbW59ayVseEManaJ5qHAoMUJO/RMv2nMzSmCICuX8tiFZKPD83Mv7irnasy9fOI/W38Df78hNOblMCEIVLGCBiGrYj8LW3BCA/MpWPkAN3eP8P7Oely5n45sfsWgU5Qv0izXTULJOGF3bj5D5vD0tU5E8L/bN38NMBFtEjSpGuZoMNC454q5Vf0KlQ0TMjz2WNitJHQRnLxb93rTpDd/t4kZ5+27I7JPbL3Q2kPmtqT2czPYEw0JhTdaxeBwns1qf4zkX3tq2Bt3T5t4CiEIXGdWOpqHCXT10EeQeNhLVC6nSBHNxVYicQPLLOLjS9dLLEkM26OWoEylGHEoRP3wpvth9FUxa5nBuU24Bf169FFZrhtOmh3yN2CQDrgp/t8slOEiO6YlJmFQ3YCVfLzZv+wXa+Q2Eq7sLQzgByAKeXr8B2G728/pwc1/Og4m9f5mJZoES+fA53X/swktaYs849UNi3ouBHiGdMeKGYyvSalBShbX7lgpBplr6owTnWLJAuR++RPlVs27tRrqK4tN/9kMgOrxdv7XP9TmvbtwIy0OpK+VeW/Oq50Z1ip93QErORJG9u62oeAIkvKmhxgBr+yFHzDNV1md/vd2v5Y7IZ9dS2S3fBwedP8YEB8cWzy5mCJMXlh2/KnAeXI/SUnLmACscZ6owqgQufL9r6eykXlXAdSvSdSeiln3CzFbra8aEhPEoPXgoYE3gTEnd/H04j+OM86tX8JKI8zI25VBNnRSNhIyuGV7f2kq3GGgIo0 8v+ak1oW ZtyL55V0GC/1TduvJ0YGejPDJQjLbQf2QqvHhgRobcxiYNxCkBQ1wVQ+ZGxN0M0JOWNuTTajEe9zP7G6hWSa2t9UzSWc/4vUgZcgu1oZlWc6leAUNO6tiLTJNbDgcn5POjNfYPCbVgg1J4lm5MwYs4v6EHaXOg8q0oT9g9oKfJ4dwYRbWGiqLysYa1Hc6Nyb1T4wsr8qtwrcO/rn9qBT35v3bm8+TzTxhfrJVmwggT8EAxEvLYqvdanTG6bA6js8hmGKaejAvv6yu4W2/R50MOQwdowvXFoSQbPDfjlZhEhPHy7o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/20/23 19:38, Michael Roth wrote: > From: Brijesh Singh > > The snp_lookup_page_in_rmptable() can be used by the host to read the RMP > entry for a given page. The RMP entry format is documented in AMD PPR, see > https://bugzilla.kernel.org/attachment.cgi?id=296015. > > Co-developed-by: Ashish Kalra > Signed-off-by: Ashish Kalra > Signed-off-by: Brijesh Singh > Signed-off-by: Michael Roth > --- > +/* > + * Return 1 if the RMP entry is assigned, 0 if it exists but is not assigned, > + * and -errno if there is no corresponding RMP entry. > + */ Hmm IMHO the kernel's idiomatic way is to return 0 on "success" and I'd assume the more intuitive expectation of success here if the entry is assigned? The various callers seem to differ though so I guess it depends on context. Some however don't distinguish their "failure" from an ERR and maybe they should, at least for the purposes of the various printks? > +int snp_lookup_rmpentry(u64 pfn, int *level) > +{ > + struct rmpentry *e; > + > + e = __snp_lookup_rmpentry(pfn, level); > + if (IS_ERR(e)) > + return PTR_ERR(e); > + > + return !!rmpentry_assigned(e); > +} > +EXPORT_SYMBOL_GPL(snp_lookup_rmpentry);