From: David Hildenbrand <david@redhat.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Huang, Ying" <ying.huang@linux.alibaba.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>, Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Yang Shi <yang@os.amperecomputing.com>,
"Christoph Lameter (Ampere)" <cl@gentwo.org>,
Dev Jain <dev.jain@arm.com>, Barry Song <baohua@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Yin Fengwei <fengwei_yin@linux.alibaba.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH -v2 1/2] mm: add spurious fault fixing support for huge pmd
Date: Wed, 15 Oct 2025 14:23:26 +0200 [thread overview]
Message-ID: <b479a6af-1e13-41da-82b7-d4c17e9034dd@redhat.com> (raw)
In-Reply-To: <d748bc6b-2aff-4cee-a233-008f4d2555fa@lucifer.local>
>>
>>>>
>>>> _pmd = pmd_mkyoung(*pmd);
>>>> if (write)
>>>> _pmd = pmd_mkdirty(_pmd);
>>>> - if (pmdp_set_access_flags(vma, addr & HPAGE_PMD_MASK,
>>>> - pmd, _pmd, write))
>>>> + changed = pmdp_set_access_flags(vma, addr & HPAGE_PMD_MASK,
>>>> + pmd, _pmd, write);
>>>> + if (changed)
>>>> update_mmu_cache_pmd(vma, addr, pmd);
>>>
>>> We can make this simpler, e.g.:
>>>
>>> if (pmdp_set_access_flags(vma, addr & HPAGE_PMD_MASK,
>>> pmd, entry, write)) {
>>> update_mmu_cache_pmd(vma, addr, pmd);
>>> return true;
>>> }
>>>
>>> return false;
>>
>> No problem. As long as David is OK with this.
>
> Sure I don't think he'd have an issue with it but he can raise it if so :)
Absolutely fine :)
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-10-15 12:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 9:20 [PATCH -v2 0/2] arm, tlbflush: avoid TLBI broadcast if page reused in write fault Huang Ying
2025-10-13 9:20 ` [PATCH -v2 1/2] mm: add spurious fault fixing support for huge pmd Huang Ying
2025-10-14 14:21 ` Lorenzo Stoakes
2025-10-14 14:38 ` David Hildenbrand
2025-10-14 14:49 ` Lorenzo Stoakes
2025-10-14 14:58 ` David Hildenbrand
2025-10-14 15:13 ` Lorenzo Stoakes
2025-10-15 8:43 ` Huang, Ying
2025-10-15 11:20 ` Lorenzo Stoakes
2025-10-15 12:23 ` David Hildenbrand [this message]
2025-10-16 2:22 ` Huang, Ying
2025-10-16 8:25 ` Lorenzo Stoakes
2025-10-16 8:59 ` David Hildenbrand
2025-10-16 9:12 ` Huang, Ying
2025-10-13 9:20 ` [PATCH -v2 2/2] arm64, tlbflush: don't TLBI broadcast if page reused in write fault Huang Ying
2025-10-15 15:28 ` Ryan Roberts
2025-10-16 1:35 ` Huang, Ying
2025-10-22 4:08 ` Barry Song
2025-10-22 7:31 ` Huang, Ying
2025-10-22 8:14 ` Barry Song
2025-10-22 9:02 ` Huang, Ying
2025-10-22 9:17 ` Barry Song
2025-10-22 9:30 ` Huang, Ying
2025-10-22 9:37 ` Barry Song
2025-10-22 9:46 ` Huang, Ying
2025-10-22 9:55 ` Barry Song
2025-10-22 10:22 ` Barry Song
2025-10-22 10:34 ` Huang, Ying
2025-10-22 10:52 ` Barry Song
2025-10-23 1:22 ` Huang, Ying
2025-10-23 5:39 ` Barry Song
2025-10-23 6:15 ` Huang, Ying
2025-10-23 10:18 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b479a6af-1e13-41da-82b7-d4c17e9034dd@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=catalin.marinas@arm.com \
--cc=cl@gentwo.org \
--cc=dev.jain@arm.com \
--cc=fengwei_yin@linux.alibaba.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
--cc=yangyicong@hisilicon.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox