From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D74C77B71 for ; Sat, 15 Apr 2023 09:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 279496B0072; Sat, 15 Apr 2023 05:53:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 228F76B0075; Sat, 15 Apr 2023 05:53:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 117F66B0078; Sat, 15 Apr 2023 05:53:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F23976B0072 for ; Sat, 15 Apr 2023 05:53:34 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C27BD1A021F for ; Sat, 15 Apr 2023 09:53:34 +0000 (UTC) X-FDA: 80683163148.16.CFC3E20 Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by imf12.hostedemail.com (Postfix) with ESMTP id 23CDF40014 for ; Sat, 15 Apr 2023 09:53:31 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=none (imf12.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp has no SPF policy when checking 202.181.97.72) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681552413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HtK3f6AoO/duICumOM8QtVqIUHT+IEX2Pgdzac6jh6s=; b=fhTlXZIwuvVIEA6OUTOd9BBkF6G5m58+McLu7i/evcKqxszZN0V1obZvdUaadgqcSBh2ag 41YsbO4G58eDmLxjTo87p0J4Y25rDhznsQVmoGDFkV3lFNcyfsD7NCsO7gNC370ZFozpuo BK2gGjuFrm/xjuXAAPSZr2DZDSxK+s8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=none (imf12.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp has no SPF policy when checking 202.181.97.72) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681552413; a=rsa-sha256; cv=none; b=FLEM2tCRCWaV1CmMscF4mt4I9z+oyUXSFFTYg3FNfacfpxkZrs/biQZqfF8aGXOuKIlP0Q JiS16UyS0tjYCMOVfNIP9kFA5HBraY3vWWmvGafqAx+Akvm6ypAEsJE2SqrfZ1OqS7Qfac 5Oh7tePaltAFDlLy63vO8Z3Ir3gzGdU= Received: from fsav414.sakura.ne.jp (fsav414.sakura.ne.jp [133.242.250.113]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 33F9qg6n066740; Sat, 15 Apr 2023 18:52:42 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav414.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav414.sakura.ne.jp); Sat, 15 Apr 2023 18:52:42 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav414.sakura.ne.jp) Received: from [192.168.1.6] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 33F9qfPk066737 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Sat, 15 Apr 2023 18:52:41 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: Date: Sat, 15 Apr 2023 18:52:41 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 3/7] mm/gup: remove vmas parameter from get_user_pages_remote() Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <631001ecc556c5e348ff4f47719334c31f7bd592.1681547405.git.lstoakes@gmail.com> From: Tetsuo Handa In-Reply-To: <631001ecc556c5e348ff4f47719334c31f7bd592.1681547405.git.lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 23CDF40014 X-Stat-Signature: b74sp77jkcod1joof38cdynnm55s8hpb X-Rspam-User: X-HE-Tag: 1681552411-447681 X-HE-Meta: U2FsdGVkX1+T0DZkIZFPnmmJ2eDcNDnhm2ggeaRAZSqYHcAYSylwkiLE3St6FTl275cN5zjO1Z1hCIiJHP4S/t8ZeamOr+JcDfZh7Ms1WGskaV9xdgCIRI9KQ67ja///umlr6RbYlDaSbrYhO+4uspsIythzIgs3UtdBBcUkSkAn4Mv041ZWTCxop+TbyWUUOk59Fm3s8BhxFyM6nHRO6dho7G+jC1tiIp2Ovv5kj6WtgzGSQk1DBhzkXPg2cTnoi3n1cEu0oUnpmhbzSZai0aLLM6W90n/+9YdvpwnL/C6b8MUVIjRDF0bzb+XSYZGDgbPxvuMf+WCsk/svZxWwtnHRRIR5zJLmg5EZ1ewP52+u1YV4ar8uIO6XYqW1+czglAtTSAEUYwVuG1zg+cYnjMcOe2tl792b5fzWdU5L0clAgGajSJzjqjCyQayxJmJ6AUEb65uw0rfzkyvtRJi2Tz8/JTlbMYTs7gBASaKRzTtMm8KTU/OaP91QTkdV23aXa/5l5/bWPy/lgx06pA0a7Gx2/osCu6eMmcj0qu7CDtjJAKkXbyxj8mVX4VuEK14+yGUWZU89R2+iEstURvYfHIkfbH15iD1SHKZ4UdRQbdUo/QV1jsUCj7Krms7Msvs7043y7Z8wq8BD2zI2g0frNXxmlQJSSBMHLPesgsUqmye4RYR612GJqqkpy15dBf8NGSRbjvXUcd2y008Kl+4ZppSA0LZRaVDxpwiZ9AfMe0OYyYCe6x43nZwW+q2oxoxdtHl8cA/MZf+np7eI1rwvysDocX04KpqvO1xZa5oBEAnahdF4G3Ieybvq46dj3QL4Fwo9e6zNNVcv4l9ejmZcpEni0KGxlunZsSQYBktpHg+DdkBvEfsclg1EBsyRF7twuZfT8f1TyNGrV5wmzsgzAFmmrMvGzTDAANP0ianPoQm7A4fQyQgwbZHCeJLH+OI2f3R6r7OVlTpq9vn60jO anuSnviy YPlFK30GskErGw/zFpooSJ/k6lEfKSazz8yy0g6hXj7RVy5nxsI+QIBEjur+Rlz5N1h/RjcAowOYLyKV3Rr9tgc6pA69s72CtW0FrFvmhETwQCuA3m76EjB1N543N4zRYiBIWb3B6LwT1uHq+P4UDmJVVqzubk+GMbtKMgX9h1X2p3UwUXtRkFBSWxFGDUlIoYHLorGXM7mYyU4+B2Q8BiPZpHki84YDV2CfEYJIqNihVKlv/2+XNYTDjz2T6LrnhpBgTWdiE8Z7vqSlTeGpUMFGZUSNr1Q7BI3toqBcXR8tHOenvUbo3Dz7/EQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/04/15 18:08, Lorenzo Stoakes wrote: > @@ -475,10 +474,14 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm, > gup_flags |= FOLL_SPLIT_PMD; > /* Read the page with vaddr into memory */ > ret = get_user_pages_remote(mm, vaddr, 1, gup_flags, > - &old_page, &vma, NULL); > + &old_page, NULL); > if (ret <= 0) > return ret; > > + vma = vma_lookup(mm, vaddr); > + if (!vma) > + goto put_old; > + > ret = verify_opcode(old_page, vaddr, &opcode); > if (ret <= 0) > goto put_old; This conversion looks wrong. This causes returning a positive number when vma_lookup() returned NULL. * Return 0 (success) or a negative errno.