From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFBE1EB64DC for ; Thu, 6 Jul 2023 19:45:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7500B6B0072; Thu, 6 Jul 2023 15:45:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FFC16B0074; Thu, 6 Jul 2023 15:45:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C7F68D0001; Thu, 6 Jul 2023 15:45:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4DA446B0072 for ; Thu, 6 Jul 2023 15:45:31 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6444680679 for ; Thu, 6 Jul 2023 19:45:30 +0000 (UTC) X-FDA: 80982216420.28.B55BC77 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf17.hostedemail.com (Postfix) with ESMTP id E967640017 for ; Thu, 6 Jul 2023 19:45:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=lNzL+MZH; spf=pass (imf17.hostedemail.com: domain of hughd@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688672728; a=rsa-sha256; cv=none; b=obfcrMGUtv5fULN8setQ74OFYwae4zZa9QVd35oF9s8h4OPWR/1kTXyjBuvlJJPSEWtdSQ R7gAoP37wheUHgRA9KsX7sdr+rFKT58aczZTT+FCXsE2bYddBEwgCRpKp4Yhk9rrxaS8G7 pweEfvqHRoS1Dp7M2GL/z4hD8SKX39k= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=lNzL+MZH; spf=pass (imf17.hostedemail.com: domain of hughd@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688672728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jn2A84TyxlB9E6QwhZ/S3+QyShJtUiEedaODmn36QLU=; b=ZMHIV/0ngHTVaVi6+bMHmTvbHdrwslkNgjVgdOkX4Kv1pccJQlWJeQNPL/saa+UJ/WVth+ ZVetnfqmV/jZzu8bLdSUfi+8iaGL91ENPsc0Xz5N9d19I+0ZfDb619hVkH4VDJ4Hn2Wemq hqeayFhNiaHP0nonhL2/bQuF43FbCvw= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-c17534f4c63so1206651276.0 for ; Thu, 06 Jul 2023 12:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688672727; x=1691264727; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=jn2A84TyxlB9E6QwhZ/S3+QyShJtUiEedaODmn36QLU=; b=lNzL+MZHVE5Tf5jrUoH6qartx9zzmTGqRlIdWHCjVAbfYsp6CttNZlOBa0hRzJvZTL SocW3GJytbAfu6mxKOaeSgPA2iF9rnWdCYXvkrsIK9bHpmO7W6jRojvsd0W+wS+1M4ey Cy0yHMaRcD9qOOww9osMC+/qv3AnBllJOa6CwnAgkMCGCbzwsgDwWZB/A/DaH1aXsVkX GCRoPuBLf5rOxEvwKQVFZvVP2+nwXsMRUU4gYs9i3BpzNT/+y660I6oddp/GqxuJdZ4c ZEiHuDoHp93DRZmouI1YYfnuJreSUTCXVkXN8Tu0HBsepWhWGMKQWmvcj8W8/LXjSWTi jHsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688672727; x=1691264727; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jn2A84TyxlB9E6QwhZ/S3+QyShJtUiEedaODmn36QLU=; b=C0xzFomspsijtTlX8tkrxdDjB+P55WQjrdk9IMud6gojeHUCLiXPDi6weFqEjaM1j9 saitP2gZR5ltat40FXHOV28LjWUF0pEJILb0jfthcHK7JXXSNu4yG/odEkVB4cpfu3Iu d971pqkn2MqSkkpTKbtn4ws+71ecJv1HyQ011Ww3089JF1TNm2Lw/nXn9/7UgPmNWALm wBSB4yPIUKkb9WHMQuquy/2bEI4C2fyzWyA9Ez0yHw21weoIQaTTIp0v6M0lJyjTQoJZ /vSJt4nlJtxxBuiDUCkV0UdzRTdCCYDcorEAnH9eBR19p/Mh5Tsz4S1DZWI3RHxqmiJp YVFA== X-Gm-Message-State: ABy/qLYWe5WNgYTe7VTt1hpjmFVLNgKwT+0SIafKxNF+lImWuGycbKLr VS3njuPbZs/mYdzUKYDrGlLszw== X-Google-Smtp-Source: APBJJlHqKtby+pVoLzti7droMN1zKJuKs2lBA2W3Af+OZJMud2WnSKOd+NI5VCViV+RTettlilf/TQ== X-Received: by 2002:a81:5f09:0:b0:570:6667:1cfa with SMTP id t9-20020a815f09000000b0057066671cfamr3295624ywb.47.1688672726798; Thu, 06 Jul 2023 12:45:26 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id z7-20020a81c207000000b005703cfc23c1sm539958ywc.104.2023.07.06.12.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 12:45:26 -0700 (PDT) Date: Thu, 6 Jul 2023 12:45:14 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Gerald Schaefer cc: Hugh Dickins , Jason Gunthorpe , Andrew Morton , Vasily Gorbik , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Russell King , "David S. Miller" , Michael Ellerman , "Aneesh Kumar K.V" , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Alexander Gordeev , Jann Horn , Vishal Moola , Vlastimil Babka , linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 07/12] s390: add pte_free_defer() for pgtables sharing page In-Reply-To: <20230706170213.2ea63606@thinkpad-T15> Message-ID: References: <54cb04f-3762-987f-8294-91dafd8ebfb0@google.com> <20230628211624.531cdc58@thinkpad-T15> <20230629175645.7654d0a8@thinkpad-T15> <7bef5695-fa4a-7215-7e9d-d4a83161c7ab@google.com> <20230704171905.1263478f@thinkpad-T15> <20230705145516.7d9d554d@thinkpad-T15> <1014735-ecc4-b4bc-3ae7-48a4328ed149@google.com> <20230706170213.2ea63606@thinkpad-T15> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E967640017 X-Stat-Signature: 8hy59siut6tq58jag6b5ub7jrsq5jakd X-Rspam-User: X-HE-Tag: 1688672727-293478 X-HE-Meta: U2FsdGVkX1+vYSTyRgXuuxhqMompPjcQLh9l/nmb/whD4/TrxzVFWbnsovMcGypFLFgZ5wSAZd0/qd05k7c6k45nShU22h/hxh9lhgvSoIMtQtj7MlZ4skZ+3cDFYMSDnW87R/OxTV65fIb9VpKpHr3YCMchvWmntuC4pr3MHFt8MhEZjK9sTODGK1flh8TMOSjDuqLxpHochLNPkdN9y3v+H2su3FDtasjnxC3fwZSAG0QEeHWLaUuspE6lmuQxDGCgmay+fMbhJKmbdaKbMwVCOOyA2RWDk96672vajG06OEj23Kk54U8zecZMqJQPvERaCY+S5xwCOJlsq8KfM736PHs7PpN+HsDfWFB7VBLJPROyhWy41gUroUZsLkvUZtF3Uz/Hk2WMOGSwrPfd17LdGezfhA0fbaj69H83D4jG6z7LmcCVqmP7JeS7G9ZnQ76ipqYi7fcy3m/W+xvUg6cKWm6um2C2Kr2zzQHef2TqTp4BFhx/l3NS6+srE2zze6lwxzNDnNP0dOreIv3eh99LAYPUWCkdpFbaZZ7N9oJPk07iTE7GEQOjASUNDphefWdpC+k1KhuqMvEYRwV0/il0zXD7U4XbAKN4KawDU5NY2Qg11LabrqdQQC+k2dPIO1mtIApU+CqBhnSrMLyyMO7sqJFLqsw/mhBj+fdY6GtNAVqKGJllon26Gw1hcWGUy0uey31G9kxMfs/pm4DVmR/agLLeIQ6gebVaoilvKFEuq8zCD5hd46cZunkhi/pg9RD9u3REI8G/qfrNF93cHYybN9KDn2Y9JSA+1pCjhp3zp1TugKoKK4ilyh9W6npdAqEUaqHUZTDAYEqANBO2xBl5XKRtpnYDw+2YQmLu+TanzGAbzWsXJ0QvRnQ4dQcpFYSsNlpdV0uTTudytI7+cVUZdiLET028/ECgTU6JWghLECqVbGDS6lyou0EU47dF9G245O7UPORTXwf0Le6 mNB1aawv eyEhG5HUYQnaFMp3gXeVwZnezBkijEdRjWlDYbhaDEufD/gFswCmuqLfoHSDgDOd0fpmXCN4eCydtDDAOiDBuwOwu4el7aEBfetV4IQIY0m6LwRULVHUjHOED+5hHmMoNx/qiZMjxv+tqst34J9/zIFeah0ju5fxdod4iMK/QoXXiE8WK/xxH1SA1EWEM9B3qBy0PizUxu+DBx4O9pIlj4kYTjrABaQoApHWT404UKIscKsLjjkQ7GKpjmz7kbWl/OX/junSPVS7Wt/b8ddi7j6H1jhzghbJ+rUEOobabAx2MK5kKNVskHTVRcjpJ4Xs2IIbq8u3hvVQOntfY7CqE5UW8dMve/XS+pCICoYgdPmzvOtwHxgdJh49HALoO9c6wz8aEwmzBZdueKjV4xDR92+XskSHe39Pslm97ueJYorZ+bXE0phLX57D8yQQv+67ecFJ9w/FKcZXNPBfLW3yElwn5VHborb/Sm2DQXSBBDcSU5xB4Y0fQ9k4Blg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 6 Jul 2023, Gerald Schaefer wrote: > > Since none of my remarks on the comments seem valid or strictly necessary > any more, and I also could not find functional issues, I think you can add > this patch as new version for 07/12. And I can now give you this: > > Reviewed-by: Gerald Schaefer Great, thanks a lot Gerald. The one change I'm making to it is then this merged in: --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -455,6 +455,11 @@ void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable) page = virt_to_page(pgtable); SetPageActive(page); page_table_free(mm, (unsigned long *)pgtable); + /* + * page_table_free() does not do the pgste gmap_unlink() which + * page_table_free_rcu() does: warn us if pgste ever reaches here. + */ + WARN_ON_ONCE(mm_alloc_pgste(mm)); } #endif /* CONFIG_TRANSPARENT_HUGEPAGE */