From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20016C3ABC0 for ; Wed, 7 May 2025 14:15:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8C506B0089; Wed, 7 May 2025 10:15:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E15636B008A; Wed, 7 May 2025 10:15:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C68FF6B008C; Wed, 7 May 2025 10:15:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A02636B0089 for ; Wed, 7 May 2025 10:15:21 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DC8031A04D5 for ; Wed, 7 May 2025 14:15:21 +0000 (UTC) X-FDA: 83416309242.29.A0D396E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 4D80020017 for ; Wed, 7 May 2025 14:15:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gw35g0YK; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746627319; a=rsa-sha256; cv=none; b=5g9zOXasj1lrQL1JB1zAFQ/HC8jAZ7QTXpLA0Z3Z8ZmzKW6dnvDmNVmM1ZI0kT6is6GOhR 4cGp16zARefWpaIKLnN5WC27mP9PiKOrxdCVEMf5jsfih8sbLM2tovR3NRN6J5Mnz75aBP qzR5MHOAtKdwyyo5Kw3tfDCIMlaQRtc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gw35g0YK; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746627319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IR4sYe4zuV+MgdFUj0SEQEMny2GtXp9mBqrR8ByAWsg=; b=pcoXBT7/uqhwniYMqA42grPCj0NA1+cOsO/0GRNFCR53CBIljwti1rqaGJFx95zqVN6WTL uvhKyd2WIsuPIfiKdsu7b4YyX7t3dhAdp53JgG6m04Vz+HYK8Bg9KKLlbYJ8h9FtkGuLMq 6ID5MV6Gy5qNwWIy2tmaIComb/jwKNE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746627318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IR4sYe4zuV+MgdFUj0SEQEMny2GtXp9mBqrR8ByAWsg=; b=gw35g0YK12o4O44PNnLcsoK10pYUdgreyRE/6mujFG/6sGStrZFXAI2gxOpW5RYT8mLBCX RY3hF5HPHXy4u5VlIcmGGcfWwch1zQAJeZ16QjLm+eqWR/yrXLBmpqAwqgBscOAG2mj1SQ kauh1DtfITGkMAb1hj7x2fAYKzkicSY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-50-49q-gb3iNnCg3uRaNmVOqg-1; Wed, 07 May 2025 10:15:17 -0400 X-MC-Unique: 49q-gb3iNnCg3uRaNmVOqg-1 X-Mimecast-MFC-AGG-ID: 49q-gb3iNnCg3uRaNmVOqg_1746627316 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d734da1a3so33124475e9.0 for ; Wed, 07 May 2025 07:15:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746627316; x=1747232116; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IR4sYe4zuV+MgdFUj0SEQEMny2GtXp9mBqrR8ByAWsg=; b=oTYNt5hOOUmmIqzJtr/fuo3BMneZsIlGPBJsPyzdKv/4MGTM35Nn5qZX9phjP8QldM CXJgpPFGOCSphfHBNEIhESfgepY4O3DqSNizsPKmd2DtHG1I6e6mZq9OpVRMwp9fRuUg FFr74CI9yxMSPQ8SxORGpHQt4vMOd0d4WceECznEMXL6RG4Hm+RJbeTSGtEOcLYb/QWD 1jl93AXkAQQ9xPQI3xeaTvIPUdA6PO2Oj1r7G7j1xNgoi7xBKUyuPce/deVj0pKLguF2 inUqGx/mxmqC5yFMYTR5kWbBkIsQLRloQJ4afeCBbDijT+kMlfbfwtXF4V2TkcZUVAsr 6cPA== X-Forwarded-Encrypted: i=1; AJvYcCVJmS1y+WEY8A3SxzA74aIcNkIEsUQ6KwHaIfWCMuC6XgGbEFNmde5ft6IiTICgJ62nBSD5lJYgUA==@kvack.org X-Gm-Message-State: AOJu0YygJ3in5lVKEE6FgOKyUSqu2iglZpu7tAu354Ob/Fp6/SioFeqX 4Vbtl6CHCPZ9zm/h7Er2lRq4PZ8Gy3ho29Bokp4+NHbroqrsR/i6BXhtLYxdBr6pMO486ci0UnK Lj1fPXeTDqswuZvLNbsJQiRGyTflmp5tFfoNaDRMTRrun9kcO X-Gm-Gg: ASbGnct7QEPgZCAQCKMw9GmuMd3eTz8JmJIDfv614kTlOjokeUfRZLUQPSZq28Mf6T2 3ihHzMTsAesTZp5+4qrSu17Dttmjgi7QCO2e1FwbQLIG0RV0E0Gy3coDd2CiESSEoYEL0LT/ihg vCFSTe4yFwFNQdf4/SH9NgBGIMBmPahpgLyerkjY/NakglxlY0Jhz+g5PyFlaE6l6mAG0dSqgj9 Cisf0OAx3GTWP8Q/Z8JvSphfe4d0yV5MHwsrGWmuEiB5KP9b9JGpZxvnz5ui7zQ7cFb4z1ehh1h XGeeWhcdGrZEohEfQlhqaq/trt8Dp4xIihM2kvAWSDcHznRCnBV1iQcpRIsXnEVcGicHGNtE9cD 7XeYyXfKC5vKjk1nQUD0gx8M5mHrN5KEgBIUohA== X-Received: by 2002:a05:600c:4eca:b0:43d:563:6fef with SMTP id 5b1f17b1804b1-441d44dcd83mr25874205e9.21.1746627316024; Wed, 07 May 2025 07:15:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEU0Dz+x4SiNUmlpqgxEkYcd0eKKNeptqhw2nJzZPcuY/oNAzsky9GpaxoI8b3MNp8F7/bkjA== X-Received: by 2002:a05:600c:4eca:b0:43d:563:6fef with SMTP id 5b1f17b1804b1-441d44dcd83mr25873895e9.21.1746627315648; Wed, 07 May 2025 07:15:15 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:d400:ed3c:fb0c:1ec0:c628? (p200300d82f12d400ed3cfb0c1ec0c628.dip0.t-ipconnect.de. [2003:d8:2f12:d400:ed3c:fb0c:1ec0:c628]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442cd3285e0sm2477015e9.5.2025.05.07.07.15.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 May 2025 07:15:15 -0700 (PDT) Message-ID: Date: Wed, 7 May 2025 16:15:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] mm: mmap: map MAP_STACK to VM_NOHUGEPAGE only if THP is enabled To: Ignacio.MorenoGonzalez@kuka.com, lorenzo.stoakes@oracle.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250507-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v5-1-c6c38cfefd6e@kuka.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250507-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v5-1-c6c38cfefd6e@kuka.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QqG1u_DAsLFzD3ISfiO_RwkSBrLpTdaqgqx3wl_Vy8U_1746627316 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4D80020017 X-Stat-Signature: hbmqh6ejjr3dksc85bbrqz76cp8wjhum X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746627319-98829 X-HE-Meta: U2FsdGVkX19k748J+gmUN5dvAE64DH1+ce7QstTBi5mHidAuITqvQta96I12QU2gJ+QSfShnSlPvdQ36xa+2X7SiwsTeISlNBkmagWmI/eubpLL5E6uiXiex5LWsE5xAbHflLYXm125J1zXtEPMHH598bD+4i9qOafvfvyXGZNjsj6c6Wfe/UmXcYJCg4VZ7dAXfiDOIfR9UZcybjsZQDgoeRVNcvOxqxHbMxrRn/5vGoyuX5KPdwZ4jFmg8Gihi91xk8RNVUD3EQNh1A74I4wdzdqGGG4yDEmp354S2js/xKqChuBv43roEGHKCja2voglaAqVkAd/uR678F4ZsYUFBR/NcdzyvEVnv+LKjGvk8j3VNB3wyfyGuNzpGWQXaxC0V+CUzL2E5lbx0F74l8vehzNvm8TLoA1X+/JveTBtPk88IcYw0VsO2mcmIOHcq13RAucZTnt5uh/f/WLmi8Re6Nkb6ZSP870I9KC9bkK+IEE0d3BUHf6HumYOQIKk6ue+8VaJNV1tkYzZF+EAuPr4yapsm24Uazm/AbT1H82ZAwK4ggBb1oJUNMloZS+rtHGiN6zX/XdYGbRJcfwHRr7Dl3nUFRCZCI7IxAE3frb6VYR2cXjsv4tPpUAO686r9s/p336fdZU058Pb8a3qD0HyIrNWq3CMXg00jJDwkpiVmiFdRzQS/sQq3GlZq4BV2n8FAn72EXQfWyvafhS8XttrwkqfpeHx6yqyPQpwiJt76U6M7Xu62IePfevR5fm0zh9gb4EETTvG8zAeB1kPUghCcH/EluhMIFNVCDikCasAhUB9VQgBCe98Mks4LluRKgqsmHHYya/9mp/FTbr6FEFuNZtso0kAnKChFV7gdOEyMCEbJQI4T98kz7+9yn2kn6CZlB3kUvg/JGLqXztOy061u/nieWo48f9QQ44tWXxKmMYMM/WQ4c3+KYW6hZOC096oiGdSTH7fbk/LGS0u x202rxRx 7bBVFV2DZv0tO8nkO+SVHinGCOOT3oA4T7PPcYJ3CRfO6P01H3nbfS3eh/50PIdrY14cBrge8dhivkURax0q08OWB97HYz+69oObQrOJ0BGG0CSSKd9eyIAl9mSqRE/6B3F6qMdFcHzBIy43ztoJ7dgjmX52DgjysXcfgs4bGQdy/gdmyB1vsVcMhHbHbwvrV5wlvuLlgKjnEuR39deSA0U7NQhWSZoOinqKXJdgLF4Odf6zHuCF2eF7mDY2r84iHYA0fSF8b2eImG1A4lTKQTYIXEo6jRjxoY++LHVplK0MVBazTuv9SfC6IduosMhxHx5O9zxcsuK7dmcNkq3+EbpJjjx/pblTQRT6wRWbiIegdOC/va2UdYTAakMpTdOhAFGKHV1M9pcVph/1u1V1zuSKNF7mbTx6Kjzz73aQOAmhR65KFPWCXoMKyECA61sldNpu4A97l8KBvqGxsh6PCFOCyZH0B0Sak0lLn0WXB5iobMG/gHbjOeezgdoSAYX4ruhm07xlqDTQFWg8dppn2hlJCwFhvnADaw4a1rTjfuulO8N5GdR1lbVUwjzNwG2S8uc/4PUl1B2HuEVGVcZ/OCgFRxhVf97Gnw8auDrMZxMm6buVZQvkYbMDdrskocK1Ommb4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.05.25 15:28, Ignacio Moreno Gonzalez via B4 Relay wrote: > From: Ignacio Moreno Gonzalez > > commit c4608d1bf7c6 ("mm: mmap: map MAP_STACK to VM_NOHUGEPAGE") maps > the mmap option MAP_STACK to VM_NOHUGEPAGE. This is also done if > CONFIG_TRANSPARENT_HUGEPAGE is not defined. But in that case, the > VM_NOHUGEPAGE does not make sense. > > I discovered this issue when trying to use the tool CRIU to checkpoint > and restore a container. Our running kernel is compiled without > CONFIG_TRANSPARENT_HUGEPAGE. CRIU parses the output of > /proc//smaps and saves the "nh" flag. When trying to restore the > container, CRIU fails to restore the "nh" mappings, since madvise() > MADV_NOHUGEPAGE always returns an error because > CONFIG_TRANSPARENT_HUGEPAGE is not defined. > > Fixes: c4608d1bf7c6 ("mm: mmap: map MAP_STACK to VM_NOHUGEPAGE") > Cc: stable@vger.kernel.org > Reviewed-by: Lorenzo Stoakes > Reviewed-by: Yang Shi > Reviewed-by: Liam R. Howlett > Signed-off-by: Ignacio Moreno Gonzalez Acked-by: David Hildenbrand -- Cheers, David / dhildenb