From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A51C36010 for ; Fri, 4 Apr 2025 06:29:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1157E280003; Fri, 4 Apr 2025 02:29:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C289280001; Fri, 4 Apr 2025 02:29:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF3A0280003; Fri, 4 Apr 2025 02:29:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D30A4280001 for ; Fri, 4 Apr 2025 02:29:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 62568142143 for ; Fri, 4 Apr 2025 06:29:22 +0000 (UTC) X-FDA: 83295384564.13.6B88459 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id A049B1C0004 for ; Fri, 4 Apr 2025 06:29:20 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743748160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VLXk/v38KvGAyRDN7YJ/BSRIDRh/7ikNT2JRpsSIl84=; b=pZk9Jfrx5DAXy8X/FPD9JolbJKw1qsjl9jWvwiCi2ZjDrgMrEyPhBznMfsY/1E1EtKEVTM IeI6HAiHmTGpD99616k9/CTtOR9frD53b7DpGGylpP6Bn6U3hwA3ufmo+4I/ZdqxNfKyEK QQER4Heppfz2KfVhngBwrifK9a3dbmU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743748160; a=rsa-sha256; cv=none; b=tj1e75LoLCgvtOpYEPfxkcR6q7U1kgWF6d+qMSe0iVG5PK01Tg2992bYAGljG4BEXa0waL u4bsqrOsi0ij8DDe4YBkz3SNrJk2eBDVvqyQSTOuQJzXxYZRrHGVPnaC7N+n0ixkZfpnat jeejHRM7dJov2+g2dbG/UCqO9omG2sA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E19F31063; Thu, 3 Apr 2025 23:29:21 -0700 (PDT) Received: from [10.162.40.17] (a077893.blr.arm.com [10.162.40.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6FBC03F694; Thu, 3 Apr 2025 23:29:14 -0700 (PDT) Message-ID: Date: Fri, 4 Apr 2025 11:59:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: numa_memblks: introduce numa_add_reserved_memblk To: Yuquan Wang , Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rppt@kernel.org, rafael@kernel.org, lenb@kernel.org, akpm@linux-foundation.org, alison.schofield@intel.com, rrichter@amd.com, bfaccini@nvidia.com, haibo1.xu@intel.com, david@redhat.com Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, chenbaozi@phytium.com.cn References: <20250328092132.2695299-1-wangyuquan1236@phytium.com.cn> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250328092132.2695299-1-wangyuquan1236@phytium.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A049B1C0004 X-Stat-Signature: wckdbg5ff9kpq64gfs3pwb8asc4mmuhc X-Rspam-User: X-HE-Tag: 1743748160-741247 X-HE-Meta: U2FsdGVkX18rCiiG+HVkY5ApWAiRuM+Cb9XnZXUib24RvWUljfIL2XGBEKuHQnBOQdr7gZ/CB69HI2lhyhw2uLo+Q/EYaHgb+Dn1DvXQsCsf6/JFMNUAMXk2oOlDGgGj+4fCMGX/anl2+vqlH8SJM4NO57bbpfzHjKuxLjxGSZb/Rm7onuzZxOxGFLFRS5SsgkM1gzYIf4nV5PPLAf8w8S5nWtE8exlr7+L8y8Bs+01nqwXYJBSZJKVdkLp3r1DphkIjc5pCd7dZA7ZPMFh9azcQ6GzSEZNQeQ8INgM9D7Nw46Xf0UovsaxEYhA4J+WIEoppTqXbl2Pd+LySUAraHqynCWQX8Z9F0yyWfwZZyZ0/zBz1TPR4LE1NeTSAFRLYgPk5H14MicDbGgrPI6M66Qj32Xlpcp/wclHutGuJahyZM105DjY7mQZBBJk7jQ3ayzYubwMBanQmRoFpdAO5u/9KR68I3f6tmA3tRKFHZERexd8HyApkHRY81/kSWIXaQrif5I0MylACFfHbTxCpztBYRmPnOSf05eRAjfeqCsfrXhuJRmWMIum5fpbtFm0ATlmiqWTaNAz7FQ09ZbDDzQPcyUPZLDNHGSzIdA496hnvgbO4kzuPMd0t+PpJDyFvfi9XZler/R/629gYKFt+74sU75XgZ+qE1uaQZrGc8sScm4+4JBFhFCoqgdHUqO4QFCj90b9v1WHSH+WAHDiXcQbE4EnsaMj7sSNM7Drey781pb6vUacTGPznGK88wcHhXH8SyxRcVH4Fiy/UL1NEqe67hlZHRXY/MZB0vWuCtWQRa0D7/lOmwO2mjvxRhwM+NYyIbbhu/2hvsJcAKutzRyftlMVk9W655mj6DK5vnl9c/X+CgKWKQvlHx5DH+4jKmwldTAV1BNM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/28/25 14:51, Yuquan Wang wrote: > With numa_add_reserved_memblk(), kernel could add numa_memblk into > numa_reserved_meminfo directly. > > acpi_parse_cfmws() currently adds empty CFMWS ranges to numa_meminfo > with the expectation that numa_cleanup_meminfo moves them to > numa_reserved_meminfo. There is no need for that indirection when it is > known in advance that these unpopulated ranges are meant for > numa_reserved_meminfo in suppot of future hotplug / CXL provisioning. > > Signed-off-by: Yuquan Wang > --- > > Changes in v2 (Thanks to Dan): > - Use numa_add_reserved_memblk() to replace numa_add_memblk() in acpi_parse_cfmws() > - Add comments to describe the usage of numa_add_reserved_memblk() > - Provide a more explicit commit message > > drivers/acpi/numa/srat.c | 2 +- > include/linux/numa_memblks.h | 1 + > mm/numa_memblks.c | 22 ++++++++++++++++++++++ > 3 files changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 00ac0d7bb8c9..70f1a7c6b54a 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -458,7 +458,7 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > return -EINVAL; > } > > - if (numa_add_memblk(node, start, end) < 0) { > + if (numa_add_reserved_memblk(node, start, end) < 0) { > /* CXL driver must handle the NUMA_NO_NODE case */ > pr_warn("ACPI NUMA: Failed to add memblk for CFMWS node %d [mem %#llx-%#llx]\n", > node, start, end); > diff --git a/include/linux/numa_memblks.h b/include/linux/numa_memblks.h > index dd85613cdd86..991076cba7c5 100644 > --- a/include/linux/numa_memblks.h > +++ b/include/linux/numa_memblks.h > @@ -22,6 +22,7 @@ struct numa_meminfo { > }; > > int __init numa_add_memblk(int nodeid, u64 start, u64 end); > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end); > void __init numa_remove_memblk_from(int idx, struct numa_meminfo *mi); > > int __init numa_cleanup_meminfo(struct numa_meminfo *mi); > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c > index ff4054f4334d..541a99c4071a 100644 > --- a/mm/numa_memblks.c > +++ b/mm/numa_memblks.c > @@ -200,6 +200,28 @@ int __init numa_add_memblk(int nid, u64 start, u64 end) > return numa_add_memblk_to(nid, start, end, &numa_meminfo); > } > > +/** > + * numa_add_reserved_memblk - Add one numa_memblk to numa_reserved_meminfo > + * @nid: NUMA node ID of the new memblk > + * @start: Start address of the new memblk > + * @end: End address of the new memblk > + * > + * Add a new memblk to the numa_reserved_meminfo. > + * > + * Usage Case: numa_cleanup_meminfo() reconciles all numa_memblk instances > + * against memblock_type information and moves any that intersect reserved > + * ranges to numa_reserved_meminfo. However, when that information is known > + * ahead of time, we use numa_add_reserved_memblk() to add the numa_memblk > + * to numa_reserved_meminfo directly. > + * > + * RETURNS: > + * 0 on success, -errno on failure. > + */ > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end) > +{ > + return numa_add_memblk_to(nid, start, end, &numa_reserved_meminfo); > +} > + > /** > * numa_cleanup_meminfo - Cleanup a numa_meminfo > * @mi: numa_meminfo to clean up For the NUMA memblocks Reviewed-by: Anshuman Khandual