From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D62C433EF for ; Fri, 25 Mar 2022 17:13:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B7206B0071; Fri, 25 Mar 2022 13:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53DFD6B0073; Fri, 25 Mar 2022 13:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B8536B0074; Fri, 25 Mar 2022 13:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id 25FDE6B0071 for ; Fri, 25 Mar 2022 13:13:07 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CB7331828BF13 for ; Fri, 25 Mar 2022 17:13:06 +0000 (UTC) X-FDA: 79283553972.21.11208A5 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf16.hostedemail.com (Postfix) with ESMTP id 0FB8A180031 for ; Fri, 25 Mar 2022 17:13:05 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B4DAC1F38D; Fri, 25 Mar 2022 17:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648228384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XKexgfjamdvbbu3VGkHD1BxsOGVns4qzCWLF0AkS8NI=; b=DyZE4f0L8Eod747juoTFaJGRxuPWFz0KzgYYhKux8bSg3WJDEN/3WKnUF7om/ZIsI0NnIY oiFDMtDpCkZ432CjLmx4SfG0kM37ERLX8RA5xIbeKOMCPQ0lwAZDC1pn/cRFxrwhpJ0+8K NTa5Dhyq7S7qvDp8g36/ju1kLRN9v/E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648228384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XKexgfjamdvbbu3VGkHD1BxsOGVns4qzCWLF0AkS8NI=; b=alFgVVXYPc1uJ4ARK0MLckTK6C9E/1OJ2IjKbSrg2WApSwsJWohRffwMNuUX53BU/3+PXq Ls7wW3BcQV4FZ6DQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 8DC061386C; Fri, 25 Mar 2022 17:13:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id NfsEIiD4PWIgSQAAGKfGzw (envelope-from ); Fri, 25 Mar 2022 17:13:04 +0000 Message-ID: Date: Fri, 25 Mar 2022 18:13:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC PATCH v1 11/15] mm/sl[auo]b: use same tracepoint in kmalloc and normal caches Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Marco Elver , Matthew WilCox , Roman Gushchin , linux-kernel@vger.kernel.org References: <20220308114142.1744229-1-42.hyeyoo@gmail.com> <20220308114142.1744229-12-42.hyeyoo@gmail.com> From: Vlastimil Babka In-Reply-To: <20220308114142.1744229-12-42.hyeyoo@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 9c3pyf19y6etow98bfjf7qf4kixhmhtz Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DyZE4f0L; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=alFgVVXY; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0FB8A180031 X-HE-Tag: 1648228385-941839 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/8/22 12:41, Hyeonggon Yoo wrote: > Now that tracepoints print cache names, we can distinguish kmalloc and > normal cache allocations. > > Use same tracepoint in kmalloc and normal caches. After this patch, > there is only two tracepoints in slab allocators: kmem_cache_alloc_node > and kmem_cache_free. Haven't made up my mind yet about whether the extra overhead of cache names is worth it. But at least the unification of _node and non_node versions make sense. I would however use the tracepoint names without "_node" in them > Remove all unused tracepoints. > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > --- > include/trace/events/kmem.h | 79 ------------------------------------- > mm/slab.c | 8 ++-- > mm/slab_common.c | 5 ++- > mm/slob.c | 14 ++++--- > mm/slub.c | 19 +++++---- > 5 files changed, 27 insertions(+), 98 deletions(-) > > diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h > index 35e6887c6101..ca67ba5fd76a 100644 > --- a/include/trace/events/kmem.h > +++ b/include/trace/events/kmem.h > @@ -9,56 +9,6 @@ > #include > #include > > -DECLARE_EVENT_CLASS(kmem_alloc, > - > - TP_PROTO(unsigned long call_site, > - const void *ptr, > - size_t bytes_req, > - size_t bytes_alloc, > - gfp_t gfp_flags), > - > - TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags), > - > - TP_STRUCT__entry( > - __field( unsigned long, call_site ) > - __field( const void *, ptr ) > - __field( size_t, bytes_req ) > - __field( size_t, bytes_alloc ) > - __field( gfp_t, gfp_flags ) > - ), > - > - TP_fast_assign( > - __entry->call_site = call_site; > - __entry->ptr = ptr; > - __entry->bytes_req = bytes_req; > - __entry->bytes_alloc = bytes_alloc; > - __entry->gfp_flags = gfp_flags; > - ), > - > - TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s", > - (void *)__entry->call_site, > - __entry->ptr, > - __entry->bytes_req, > - __entry->bytes_alloc, > - show_gfp_flags(__entry->gfp_flags)) > -); > - > -DEFINE_EVENT(kmem_alloc, kmalloc, > - > - TP_PROTO(unsigned long call_site, const void *ptr, > - size_t bytes_req, size_t bytes_alloc, gfp_t gfp_flags), > - > - TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags) > -); > - > -DEFINE_EVENT(kmem_alloc, kmem_cache_alloc, > - > - TP_PROTO(unsigned long call_site, const void *ptr, > - size_t bytes_req, size_t bytes_alloc, gfp_t gfp_flags), > - > - TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags) > -); > - > DECLARE_EVENT_CLASS(kmem_alloc_node, > > TP_PROTO(const char *name, > @@ -101,15 +51,6 @@ DECLARE_EVENT_CLASS(kmem_alloc_node, > __entry->node) > ); > > -DEFINE_EVENT(kmem_alloc_node, kmalloc_node, > - > - TP_PROTO(const char *name, unsigned long call_site, > - const void *ptr, size_t bytes_req, size_t bytes_alloc, > - gfp_t gfp_flags, int node), > - > - TP_ARGS(name, call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node) > -); > - > DEFINE_EVENT(kmem_alloc_node, kmem_cache_alloc_node, > > TP_PROTO(const char *name, unsigned long call_site, > @@ -119,26 +60,6 @@ DEFINE_EVENT(kmem_alloc_node, kmem_cache_alloc_node, > TP_ARGS(name, call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node) > ); > > -TRACE_EVENT(kfree, > - > - TP_PROTO(unsigned long call_site, const void *ptr), > - > - TP_ARGS(call_site, ptr), > - > - TP_STRUCT__entry( > - __field( unsigned long, call_site ) > - __field( const void *, ptr ) > - ), > - > - TP_fast_assign( > - __entry->call_site = call_site; > - __entry->ptr = ptr; > - ), > - > - TP_printk("call_site=%pS ptr=%p", > - (void *)__entry->call_site, __entry->ptr) > -); > - > TRACE_EVENT(kmem_cache_free, > > TP_PROTO(const char *name, unsigned long call_site, const void *ptr), > diff --git a/mm/slab.c b/mm/slab.c > index e451f8136066..702a78f64b44 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3554,9 +3554,9 @@ void *kmem_cache_alloc_node_trace(struct kmem_cache *cachep, > ret = slab_alloc_node(cachep, flags, nodeid, size, _RET_IP_); > > ret = kasan_kmalloc(cachep, ret, size, flags); > - trace_kmalloc_node(cachep->name, _RET_IP_, ret, > - size, cachep->size, > - flags, nodeid); > + trace_kmem_cache_alloc_node(cachep->name, _RET_IP_, ret, > + size, cachep->size, > + flags, nodeid); > return ret; > } > EXPORT_SYMBOL(kmem_cache_alloc_node_trace); > @@ -3692,7 +3692,6 @@ void kfree(const void *objp) > struct folio *folio; > void *x = (void *) objp; > > - trace_kfree(_RET_IP_, objp); > > if (unlikely(ZERO_OR_NULL_PTR(objp))) > return; > @@ -3704,6 +3703,7 @@ void kfree(const void *objp) > } > > c = folio_slab(folio)->slab_cache; > + trace_kmem_cache_free(c->name, _RET_IP_, objp); > > local_irq_save(flags); > kfree_debugcheck(objp); > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 03949445c5fc..8a8330a777f5 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -917,6 +917,7 @@ void free_large_kmalloc(struct folio *folio, void *object) > if (WARN_ON_ONCE(order == 0)) > pr_warn_once("object pointer: 0x%p\n", object); > > + trace_kmem_cache_free(KMALLOC_LARGE_NAME, _RET_IP_, object); > kmemleak_free(object); > kasan_kfree_large(object); > > @@ -962,8 +963,8 @@ void *kmalloc_large_node(size_t size, gfp_t flags, int node) > ptr = kasan_kmalloc_large(ptr, size, flags); > /* As ptr might get tagged, call kmemleak hook after KASAN. */ > kmemleak_alloc(ptr, size, 1, flags); > - trace_kmalloc_node(KMALLOC_LARGE_NAME, _RET_IP_, ptr, size, > - PAGE_SIZE << order, flags, node); > + trace_kmem_cache_alloc_node(KMALLOC_LARGE_NAME, _RET_IP_, ptr, size, > + PAGE_SIZE << order, flags, node); > return ptr; > > } > diff --git a/mm/slob.c b/mm/slob.c > index d60175c9bb1b..3726b77a066b 100644 > --- a/mm/slob.c > +++ b/mm/slob.c > @@ -505,8 +505,8 @@ __do_kmalloc_node(size_t size, gfp_t gfp, int node, unsigned long caller) > *m = size; > ret = (void *)m + minalign; > > - trace_kmalloc_node(KMALLOC_NAME, caller, ret, > - size, size + minalign, gfp, node); > + trace_kmem_cache_alloc_node(KMALLOC_NAME, caller, ret, > + size, size + minalign, gfp, node); > } else { > unsigned int order = get_order(size); > > @@ -514,8 +514,9 @@ __do_kmalloc_node(size_t size, gfp_t gfp, int node, unsigned long caller) > gfp |= __GFP_COMP; > ret = slob_new_pages(gfp, order, node); > > - trace_kmalloc_node(KMALLOC_LARGE_NAME, caller, ret, > - size, PAGE_SIZE << order, gfp, node); > + trace_kmem_cache_alloc_node(KMALLOC_LARGE_NAME, caller, > + ret, size, PAGE_SIZE << order, > + gfp, node); > } > > kmemleak_alloc(ret, size, 1, gfp); > @@ -533,8 +534,6 @@ void kfree(const void *block) > { > struct folio *sp; > > - trace_kfree(_RET_IP_, block); > - > if (unlikely(ZERO_OR_NULL_PTR(block))) > return; > kmemleak_free(block); > @@ -543,10 +542,13 @@ void kfree(const void *block) > if (folio_test_slab(sp)) { > int align = max_t(size_t, ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN); > unsigned int *m = (unsigned int *)(block - align); > + > + trace_kmem_cache_free(KMALLOC_LARGE_NAME, _RET_IP_, block); > slob_free(m, *m + align); > } else { > unsigned int order = folio_order(sp); > > + trace_kmem_cache_free(KMALLOC_NAME, _RET_IP_, block); > mod_node_page_state(folio_pgdat(sp), NR_SLAB_UNRECLAIMABLE_B, > -(PAGE_SIZE << order)); > __free_pages(folio_page(sp, 0), order); > diff --git a/mm/slub.c b/mm/slub.c > index 8a23d1f9507d..c2e713bdb26c 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3241,8 +3241,8 @@ void *kmem_cache_alloc_node_trace(struct kmem_cache *s, > { > void *ret = slab_alloc_node(s, gfpflags, node, _RET_IP_, size); > > - trace_kmalloc_node(s->name, _RET_IP_, ret, > - size, s->size, gfpflags, node); > + trace_kmem_cache_alloc_node(s->name, _RET_IP_, ret, > + size, s->size, gfpflags, node); > > ret = kasan_kmalloc(s, ret, size, gfpflags); > return ret; > @@ -4366,7 +4366,8 @@ void *__kmalloc_node(size_t size, gfp_t flags, int node) > > ret = slab_alloc_node(s, flags, node, _RET_IP_, size); > > - trace_kmalloc_node(s->name, _RET_IP_, ret, size, s->size, flags, node); > + trace_kmem_cache_alloc_node(s->name, _RET_IP_, ret, size, > + s->size, flags, node); > > ret = kasan_kmalloc(s, ret, size, flags); > > @@ -4445,8 +4446,7 @@ void kfree(const void *x) > struct folio *folio; > struct slab *slab; > void *object = (void *)x; > - > - trace_kfree(_RET_IP_, x); > + struct kmem_cache *s; > > if (unlikely(ZERO_OR_NULL_PTR(x))) > return; > @@ -4456,8 +4456,12 @@ void kfree(const void *x) > free_large_kmalloc(folio, object); > return; > } > + > slab = folio_slab(folio); > - slab_free(slab->slab_cache, slab, object, NULL, 1, _RET_IP_); > + s = slab->slab_cache; > + > + trace_kmem_cache_free(s->name, _RET_IP_, x); > + slab_free(s, slab, object, NULL, 1, _RET_IP_); > } > EXPORT_SYMBOL(kfree); > > @@ -4825,7 +4829,8 @@ void *__kmalloc_node_track_caller(size_t size, gfp_t gfpflags, > ret = slab_alloc_node(s, gfpflags, node, caller, size); > > /* Honor the call site pointer we received. */ > - trace_kmalloc_node(s->name, caller, ret, size, s->size, gfpflags, node); > + trace_kmem_cache_alloc_node(s->name, caller, ret, size, > + s->size, gfpflags, node); > > return ret; > }