From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B886C27C4F for ; Thu, 13 Jun 2024 08:16:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7A936B0096; Thu, 13 Jun 2024 04:16:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C51246B0098; Thu, 13 Jun 2024 04:16:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B18586B0099; Thu, 13 Jun 2024 04:16:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 95A676B0096 for ; Thu, 13 Jun 2024 04:16:20 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3497D160B98 for ; Thu, 13 Jun 2024 08:16:20 +0000 (UTC) X-FDA: 82225158120.22.E9983B6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id DF8D020013 for ; Thu, 13 Jun 2024 08:16:17 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BKLqZC9A; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718266576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+HvS5o00goPyqB2yAiG1GSSXSOvqSTXokODERQ3Empw=; b=Ky61ysnC2C949Gl7+VySbpDvZXYcjd2vCH2GfYkGMfRMh/ZMbXuM7veSVbt5l06W1Hl7CZ hVA9Wmjo6ZVAvE0RZIh4YbHY4wnxMGk3dN9eLN47VWixnLYtGejKzoD5PapCKEY+kqqIGG 1QnnhFvLybRFJ3QRvYteUKR/8KRMhZ8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BKLqZC9A; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718266576; a=rsa-sha256; cv=none; b=k8e0iopZ3VbAPJp2XzoKCu5HxR6sr6r230Gk1/eaBPV7ct9kxwKRDpy6Ik2+TSwTMs25Un DtBoNLcCExaoMd1hTIi7FmXhzpga2D63vN+cWTmrMxeYcmvatfk+ixWOCNKn45DQ/BYbH6 /NxAIV5HGUm4/JR+QsAUGw9kpZ9Yoxw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718266577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+HvS5o00goPyqB2yAiG1GSSXSOvqSTXokODERQ3Empw=; b=BKLqZC9AJNRIja1xifi146GFxNl/rNFJjqPUX7q3gPLZdp0yoom6ieVbtZ7qxTDbkWF3Fk sV0UXA5VWAIq7Hn4IH+4g/cCzbBy5YTJuycJqpM6ghc+DOD+fTC42u4Jt9Bfx7ASn88zAk kAG2Yn80pvqK+/EeuOWFZRGmSdjkrkk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-TuGf502KNKCw1gxj6m-2qA-1; Thu, 13 Jun 2024 04:16:14 -0400 X-MC-Unique: TuGf502KNKCw1gxj6m-2qA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42120e033e2so4714575e9.0 for ; Thu, 13 Jun 2024 01:16:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718266573; x=1718871373; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+HvS5o00goPyqB2yAiG1GSSXSOvqSTXokODERQ3Empw=; b=hHM1Q4pxoZvhBYrllPrjDDyEPeCQHoIahBt5V0vvKFMaLfFScDAafZsSBCK9y2w/Ot g8vkmyvuX+lytvwRLCO4LfbW4LFubmwDkYxHx9IAsxCu/oTIkUvZA2aZP1FRneijnMRq MsDFyYPDO0WrB24y42Ty7a/5fDWtcye7+uqZSz/CPskOuDGSK/HyBIBiiROzzBC1RJhQ ZEFWJN/YbZq4djJWBesBItZQrF9g9361Diwhqy2+DWX9NFva5E0VnTW2h/MtG4pt/MKW D/0FYTONBUtVWE5hBL6iEX1BkbJ5uD3K6ga92EJOJ+QaJ+76GQZ75JRh0w52Hc7fiPWZ ubxA== X-Forwarded-Encrypted: i=1; AJvYcCWMdc0SQYSv+aeqIVgq97z5qgqr3O9NbHn+dEDrlmwvfp6n0h9mnDsv649rRRTi/w5aW+UiesZzr1SHO0YbrATl91w= X-Gm-Message-State: AOJu0YwRkx4S9fhYaxm0hw8z+Rc1JF8xc5LcOjkg/vQH1BacJhDjiP8R Jcv/oZuqj4gh3/gLGWAg+Oss7/bgVzaLjeK61MxhplwseKw+eJgEQ+ujL/o/zoHGiwG5nT4g4a9 m/sKaqp/RH2VaP9eD+q4y5SK4efPZcXZLVjp06xS181cIpcgF X-Received: by 2002:adf:fe0a:0:b0:35f:fa0:cf82 with SMTP id ffacd0b85a97d-35fe891b400mr2828539f8f.68.1718266572857; Thu, 13 Jun 2024 01:16:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7HepdPNeI8qmEZe10F4ZflLGI6ol2kzakdoPepdhR1E/su+t2ZMdOE1SBCwkbrt47wDdmrg== X-Received: by 2002:adf:fe0a:0:b0:35f:fa0:cf82 with SMTP id ffacd0b85a97d-35fe891b400mr2828517f8f.68.1718266572443; Thu, 13 Jun 2024 01:16:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:fe00:10fe:298:6bf1:d163? (p200300cbc703fe0010fe02986bf1d163.dip0.t-ipconnect.de. [2003:cb:c703:fe00:10fe:298:6bf1:d163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36075093547sm956156f8f.19.2024.06.13.01.16.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 01:16:12 -0700 (PDT) Message-ID: Date: Thu, 13 Jun 2024 10:16:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 06/11] filemap: cap PTE range to be created to allowed zero fill in folio_map_range() To: Luis Chamberlain Cc: Matthew Wilcox , Hugh Dickins , yang@os.amperecomputing.com, linmiaohe@huawei.com, muchun.song@linux.dev, osalvador@suse.de, "Pankaj Raghav (Samsung)" , david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-7-kernel@pankajraghav.com> <818f69fa-9dc7-4ca0-b3ab-a667cd1fb16d@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DF8D020013 X-Stat-Signature: y6fz5fzpmyc4uued36aimc1tsqy3ti6q X-Rspam-User: X-HE-Tag: 1718266577-299977 X-HE-Meta: U2FsdGVkX1/pmPLT8PgDxg94/sgdENOJ1xBelBUF0A+pudOb1eQmEe6KMzmzRx2QlG1/diGNibHxgR8ZZuQ5hLB/wtocj/vhmwqbFwW3naH4bLw3JJm0Q2Uzsdm+U3WGwnbAjYDnjKgtc9WFZvsAIsI/pDxCk3O5onG77fpvNYT4rnksWEtJ338fSKVz1ydVHR+tOClPnLkm5+W57BRblp+UjgQreVu3FKvdy8dNabSVwmga8Tx6VDdtlzvhPF6zCoLaH7BL4Vj/nD2iK3vRx0dN8pMEyyHsj1M4VQyNsyEEj2bKOSHctDYGlJDb4bU6Jf5Dp51HQDlkLYx9a2TtrTc5q40OqSjbiCHdpul2L+qPNf1qH/8xzmVGwDwfH6DrF7bqqwTcYFHgP5kfsM0mUUrG+DeUkekJd2oMzWjQtQzSweX4C+QKbpgz+WDgHQndvtiDxEMUOqJh0JER/477TEG+4HmBIBbQtHf2zOZ9i5PR2un8lejblqPwY505SdMhme5mwNB4yYUL5vxqOTqsC+kfm9+7rQIXtobmlhnFyfbvoLyyFHbR2CFOQr+U6oXAViD3gcY7epT6/JXWD8mMbAsRkjeQgGJi3k37/IqKDmNXAr6yx+dUc4V1KLOOGsJd0zo+UH1BC7HXsvXmZi4nqy9uqHemjhaGr/TlQA5HbBzkdYqyrMoV+mDUrw+xVk4uLzrwOuZmC2oRiTfgDpZEg0QJ1afTMeJJ9CUTfqcSKc6QQhusI6RDujpAEWMmOGzucqSxl60IK6lQ24EzCqxXAyZVR+wBlFbGSypcav8hd9UR5mVdZV2wvW5NI2NAZWDpL/aZiP58ebK+dLFf6Y6nUW0olKpZM2xxGxcK49qFDCPJsQlUMofJH6dSgsqT+iQCmk7f9/UBFzbc3EGJeJPq8G6ahmQbLl7/l0v8X4Kqp3oufR6MeVbFlksYFa7Ts9te61fRcuBx/5BbeWa9m5B xZ96YuVc HDGZKd7bXfOfvDFTmQ9r+oiL5fSk+U7iMuSBbZwuHIofPxhKLYvrg5p4/4IcnLb36ENkwO6RdCicdZxH8KbCcHRzUFF0V4GovFAsqoRWknCDSd0YTwImEtrba6VBPEmr8Au46B+Zac0bfyt88Jl0os3CIQF+drdwyfo79BLYyJC8pJoxvdTk7xVXtTwJnEvnk1QT4hGEJN0+/wAgPmYSSlHJEU4o+YLrmni84ixk3hH6koRtFTOUXzPX63pvL5X0bP2tDvnxz0bulYJjQYQTPFtzuDr0ZfIPe0t+2orc/7Nbk5DSao1dsJrahfNydPNhxe0ZbpocuZkzBw89nes3yGiy896vmvZaWfO8D7mMX9zyA8uXlwbCJPnBT662x2lBBIRZ0/JmAJTaLnzpaZXcKBG0HIQYpBCbs72amwOgFe94E2YjZkG7/Ia9rdrKKl/IE7j4wJoGpK2ZVcmAqqZLX9EiZsOO7/tX/O8afU8D55xJmT9Lk0mFvYdmoWu7WGEuA3vNiHH04G+dYuhfMGHwILRBr6TiHlGphT4vgm/WpVAoyUgrXa0GUCIcNCBZeg8Fy/rwuh3enucKslOM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.06.24 10:13, Luis Chamberlain wrote: > On Thu, Jun 13, 2024 at 10:07:15AM +0200, David Hildenbrand wrote: >> On 13.06.24 09:57, Luis Chamberlain wrote: >>> On Wed, Jun 12, 2024 at 08:08:15PM +0100, Matthew Wilcox wrote: >>>> On Fri, Jun 07, 2024 at 02:58:57PM +0000, Pankaj Raghav (Samsung) wrote: >>>>> From: Pankaj Raghav >>>>> >>>>> Usually the page cache does not extend beyond the size of the inode, >>>>> therefore, no PTEs are created for folios that extend beyond the size. >>>>> >>>>> But with LBS support, we might extend page cache beyond the size of the >>>>> inode as we need to guarantee folios of minimum order. Cap the PTE range >>>>> to be created for the page cache up to the max allowed zero-fill file >>>>> end, which is aligned to the PAGE_SIZE. >>>> >>>> I think this is slightly misleading because we might well zero-fill >>>> to the end of the folio. The issue is that we're supposed to SIGBUS >>>> if userspace accesses pages which lie entirely beyond the end of this >>>> file. Can you rephrase this? >>>> >>>> (from mmap(2)) >>>> SIGBUS Attempted access to a page of the buffer that lies beyond the end >>>> of the mapped file. For an explanation of the treatment of the >>>> bytes in the page that corresponds to the end of a mapped file >>>> that is not a multiple of the page size, see NOTES. >>>> >>>> >>>> The code is good though. >>>> >>>> Reviewed-by: Matthew Wilcox (Oracle) >>> >>> Since I've been curating the respective fstests test to test for this >>> POSIX corner case [0] I wanted to enable the test for tmpfs instead of >>> skipping it as I originally had it, and that meant also realizing mmap(2) >>> specifically says this now: >>> >>> Huge page (Huge TLB) mappings >> >> Confusion alert: this likely talks about hugetlb (MAP_HUGETLB), not THP and >> friends. >> >> So it might not be required for below changes. > > Thanks, I had to ask as we're dusting off this little obscure corner of > the universe. Reason I ask, is the test fails for tmpfs with huge pages, > and this patch fixes it, but it got me wondering the above applies also > to tmpfs with huge pages. Is it tmpfs with THP/large folios or shmem with hugetlb? I assume the tmpfs with THP. There are not really mmap/munmap restrictions to THP and friends (because it's supposed to be "transparent" :) ). -- Cheers, David / dhildenb