From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B22DC3ABB2 for ; Tue, 17 Sep 2024 01:57:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C32D6B0088; Mon, 16 Sep 2024 21:57:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 672DD6B0089; Mon, 16 Sep 2024 21:57:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53AC56B008A; Mon, 16 Sep 2024 21:57:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 32E746B0088 for ; Mon, 16 Sep 2024 21:57:03 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CBD2940248 for ; Tue, 17 Sep 2024 01:57:02 +0000 (UTC) X-FDA: 82572567084.26.9E742D1 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by imf20.hostedemail.com (Postfix) with ESMTP id CD1311C0009 for ; Tue, 17 Sep 2024 01:57:00 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=J+Lx5nLS; spf=pass (imf20.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.210.47 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726538110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7WmMcTLc+P7iBUKnVGPTlOrPlGv0NpqcT1SQCN2LOIk=; b=VfnipUde+GNSiicTgecDn8Twa7p2fODl5iGX5Py5tzgFo1y42mJfh1JkGsVlPubKhVn63Z 5M634QB1HNRNw0Roj4+GmFXh4Erqk04yKOFoPwGWKFO2wPS4syayeuKOh7Ola49dxIR35j fGxjzLLLhBMt14LgmzgR9W2rftjvvO8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726538110; a=rsa-sha256; cv=none; b=u67/JUjbQYlGqkTY+ZM9/19IR79Mi8skyfTF5ScD2c37HNWaod0v4Y7zNTWmoULdFfArOc nLCGEKZPbqc92UdqBHwuACyhvHgKMv8J3ASlk/FYyGmA+k188BkbrZ30fcnDZ/CKc9ZUy3 nXzl8wrUBgHonuUFMXPn1IKdMczrRGE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=J+Lx5nLS; spf=pass (imf20.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.210.47 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-710daaadd9bso2471777a34.2 for ; Mon, 16 Sep 2024 18:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1726538220; x=1727143020; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7WmMcTLc+P7iBUKnVGPTlOrPlGv0NpqcT1SQCN2LOIk=; b=J+Lx5nLSgGOzNwt8reYglotmWOXEyVuwbH7KO8YFwIEsgg5QgHsdp6t0ilty/xvvyW mvwHL+vYYsRAyaDbpvLNNIjqeJWDTGlvXPmfn+YymwMqPQ3lvlaoVMS6X0HKt1Gm6ntY Z1gRVurbBqZRi/4NlX2dzZDYWb4Fj6bpxos4c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726538220; x=1727143020; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7WmMcTLc+P7iBUKnVGPTlOrPlGv0NpqcT1SQCN2LOIk=; b=a9YkeGk8gnkv3kUsdZCmg1sAO9lbGupZiJZ52zQwICWCSNI/TosptPSs7q1dHNOOPd R41p1BLgfkkKup9eKI0coFwsaW3P0ytWW6Wpt+TqYAtmnB1slKV4sAnMnwRiltVPczQy lzAKBRfewKiPtgKhkRdptWAh3wUrCrbzerJnt4vjRHJ+u2dHzV7JV6XWguZLgLAjePMM plEDZBrN0dNQXegjY29PmVztdCE9gN+Zgk0okZeDddW/MNIhv6gLPKs9Ov2QTdRSq72n eM7QYmeu4WHXX/1CNPxvDjIHmX3POFfsvWPGrQj29g1E/Peme7XO4EbCJYepb3MoyorM sl/A== X-Forwarded-Encrypted: i=1; AJvYcCX3eSOCqMVGHHRWph6dUh+znmb06sHV65jbi/2rrjul+8EY4GhgFqcz+xvD6Q45sxo2f5t1MvSqTQ==@kvack.org X-Gm-Message-State: AOJu0YxDjAb7WBzcLoxZoZwlG9tGy7dIlrON88iiJsLs9vWxHbnvC5c1 pEAUM61EFOBK8D0OO8ZjXRneM70Au7nQkGqN1w+wxGOTcDZAqMiC1CLZF8oF6tU= X-Google-Smtp-Source: AGHT+IFlytWyNbdJdTLUjZkQ39Po3xQqLCVh9Etwt4uiH/F/t4s66dLjJoHmw5ETmH73XVSKw4t8BA== X-Received: by 2002:a05:6830:34a6:b0:703:676a:5bb0 with SMTP id 46e09a7af769-71109483836mr13863708a34.16.1726538219663; Mon, 16 Sep 2024 18:56:59 -0700 (PDT) Received: from [172.20.0.160] ([50.202.43.9]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5e3b0e29dadsm1102929eaf.36.2024.09.16.18.56.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Sep 2024 18:56:58 -0700 (PDT) Message-ID: Date: Mon, 16 Sep 2024 19:56:54 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan , John Hubbard , David Hildenbrand Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240912103151.1520254-1-usama.anjum@collabora.com> <3cb9d266-4d4b-4031-8603-da7fd9e3ad47@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <3cb9d266-4d4b-4031-8603-da7fd9e3ad47@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CD1311C0009 X-Stat-Signature: ca1np9u39c9yy9mbia7t5ojgn1tdjrh1 X-HE-Tag: 1726538220-237169 X-HE-Meta: U2FsdGVkX1/bOYOrkcQj3an5VS6YUe6t6sWpnfbuGaE7eo9TXMVmY0M9jte7W+sMK5WruUmpel1uYTg0HHW8wh7lrTSEOPqN2r2MaUredj9mcoHVxzKs7yoNHwnjJLjFcuTmwnMSR+jiIxjL3+Dbyi0px7l9FEPOSzO3pGZxjWtnZfxyIj1Ewet7o7m8MIkgK4XpbGctUuIHne4FBfphCcWcmy7cFKsUt+CPgTEB+vwVn3GIXbSHICAXqjQQVnnDB+LoXhqELqaC1HPQC8+4nCMiqS+1rgzy8a+rZyfuNSgc1lEI79SyEgiuJUzfPwOxyQ4+aN1r7z8A3hTL8y/4cyQtTKDggBci2PHjOF1xY2RCYJY/6+iC0zKVjJW3s/2wiBS9I+JzD2yw7IT4czFl/aQ2twwLpx2sKyIoFb0j2c6YTzlCZPk/JMkStsfUBYwZ5zhzWkNERB5gq164he0rWWNr01YAIY1tprongrOFCgGp0qVWK87F98mj2GbCHsyFs6bB3O4ejeDrmzp9dJKlFl7VdoVOPiWmXK4mIKqZTA6lzpxyy3nf8RsLfHHGW1t4Foj7FC99j5OJjzqO4gsjIiMAlaZy5+HRRIbYxN2iMW+kz59gW4QB0XHEM7iSRS9SH8PRSNFy/UW595gJX7JNYR4i/Gve6fPMkxPJmZTM6UHYaX/qo+d6TqNNeSDp7ArTOwjMIjL+EWnWL0FNuYmvz53DOki/HoxkKqyweAqncG2+mSIVRaZkpAbUGx3wQ9bNxwU5ATvogDHGSi+3xwnNenv4xLv0bScqCYIF/rHosqelxWe3huXSntV8XobUW35MAZUJbTsd+ayZ3vfpWIAvEI7vDBKOGaQhgmi9Evg46JlaKYWP766cH77f54UeTjHBWt2hg3sGPA0el5PQyi/Ienbp33aIDIYtbklB5duIlX6+XAVWr9yhYQWKGZUVxzwpjqEemPVpjkVjV0GYvzr og81F7fq pxKkN0cimveHlBSkgDe5TFOfMhB7gfiOF5jGX/FBSJYfYPNnSVLQXSPnN0O3E0F0UxEMRowdvbHHDZAqwPhjTHFncOQ83vOEHpeJvxTavf0SC22B7VDR9TOqlBNNZ7TY4NQBepDhJasJ8LIsY0PCfO7vJB74g3UjtrQYSj+f74MdHrFnhAAa6YBuFwyCpchdOwnrpSCYmqUjoqaxxAm74HJs9G2QmWeqQzpevyn38mmJBn9oGCo8gzmYGpVuAjlA8uDbs+8gulzPXl/wpQ5slIXp9CjgI11WW3NRPJhrd7hdFrq8PSu/MLkze4rl1lbTVyRs3EZnAjyMxSUlxpIboEOKzfsV0kcM1okVDLzxi4mGi/pehBFyJgxjLQEeYawAUl+6NpFDcf9WuK1LL6oRwXi81fQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.054739, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/16/24 00:32, Muhammad Usama Anjum wrote: > On 9/12/24 8:44 PM, Shuah Khan wrote: >> On 9/12/24 04:31, Muhammad Usama Anjum wrote: >>> The value of __NR_userfaultfd was changed to 282 when >>> asm-generic/unistd.h was included. It makes the test to fail every time >>> as the correct number of this syscall on x86_64 is 323. Fix the header >>> to asm/unistd.h. >>> >> >> "please elaborate every time" - I just built on my x86_64 and built >> just fine. > The build isn't broken. > >> I am not saying this isn't a problem, it is good to >> understand why and how it is failing before making the change. > I mean to say that the test is failing at run time because the correct > userfaultfd syscall isn't being found with __NR_userfaultfd = 282. > _NR_userfaultfd's value depends on the header. When asm-generic/unistd.h > is included, its value (282) is wrong. I've tested on x86_64. > Okay - how do you know this is wrong? can you provide more details. git grep _NR_userfaultfd include/uapi/asm-generic/unistd.h:#define __NR_userfaultfd 282 include/uapi/asm-generic/unistd.h:__SYSCALL(__NR_userfaultfd, sys_userfaultfd) tools/include/uapi/asm-generic/unistd.h:#define __NR_userfaultfd 282 > The fix is simple. Add the correct header which has _NR_userfaultfd = 323. I need more details on this number. thanks, -- Shuah