From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEDD0C021A9 for ; Tue, 18 Feb 2025 09:39:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A3796B0089; Tue, 18 Feb 2025 04:39:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 352D66B008C; Tue, 18 Feb 2025 04:39:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 241992800D1; Tue, 18 Feb 2025 04:39:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 064E96B0089 for ; Tue, 18 Feb 2025 04:39:45 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7B8DC160C3B for ; Tue, 18 Feb 2025 09:39:45 +0000 (UTC) X-FDA: 83132568330.18.257D153 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by imf13.hostedemail.com (Postfix) with ESMTP id 3EC6520010 for ; Tue, 18 Feb 2025 09:39:39 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=WaM9iNYH; spf=pass (imf13.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739871582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AOdAb3d6o80BSYahe52Vce3OcGOdM1bmfBBl7TGBGRg=; b=diea8eix/zgpl6eTZuOKSAL6oxheuigPAOo6yhlwB4H9qNb87xtWEGdigPxi7pxD0MpVNg KC6wU7/vSWRtcDBcemBt5m/PkadKXL7BKiGlGU3YuVaoGkuFvUdedf1LbrDkYuPi6NsGRX Jf3mmqp44g5VlwYLg9nLBge7SMn3JPY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=WaM9iNYH; spf=pass (imf13.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739871582; a=rsa-sha256; cv=none; b=xdaz0df1CpmvI2/4oEaTInMIh2dLNBPLQTVUDzKHwnbZGfNm78Vmj+/qQCRtX0yjEUfuyd UQMIxBvarLsrvoJcSerzsqvqUz9CUAUFUMO+jXba9TZg12B0zkED/u93kAfiHIAa13wPML 9+QiBLds5n3WJV6iexebO0/rhFy+KmM= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1739871577; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=AOdAb3d6o80BSYahe52Vce3OcGOdM1bmfBBl7TGBGRg=; b=WaM9iNYH65UB/gg4qMdk7MOk74YqeZWOmn0eXBmMjyZ82xifBr/7XEnj+vetD/MWdKcWRzJaTiDQMFABlwgR+RdJXf1MYQgqh1eaTlcy8WPsuwBxyF7fIc+IID3Ut7jrTQHntp8AO1yCvbgtOqA/+UvZkRwAHvyj0jNBZhuEp2Y= Received: from 30.246.161.128(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WPlNMQZ_1739871574 cluster:ay36) by smtp.aliyun-inc.com; Tue, 18 Feb 2025 17:39:35 +0800 Message-ID: Date: Tue, 18 Feb 2025 17:39:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] x86/mce: Collect error message for severities below MCE_PANIC_SEVERITY To: Borislav Petkov Cc: tony.luck@intel.com, nao.horiguchi@gmail.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linmiaohe@huawei.com, akpm@linux-foundation.org, peterz@infradead.org, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com References: <20250217063335.22257-1-xueshuai@linux.alibaba.com> <20250217063335.22257-2-xueshuai@linux.alibaba.com> <20250218075858.GAZ7Q9wp_WQUsjq2AW@fat_crate.local> From: Shuai Xue In-Reply-To: <20250218075858.GAZ7Q9wp_WQUsjq2AW@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3EC6520010 X-Stat-Signature: xbddyifgc6wnyqpqojjxru6obtxie7og X-HE-Tag: 1739871579-591036 X-HE-Meta: U2FsdGVkX19EswssDtp3R3nMqxUBd3g3HVNIBbWUSZpVAVJh675JiUqImfN5KIEBy+MuSYEE8Oyz/zCLTRQVvSnMYv/3gTppyey5wFB214R0Ob5BlHRPHaeGRRTcU43xsHtfyeCfHtDtlbvEEUEDgsMIz8CW8mze/gGEUCT2V9RcILGWrYXw4QijByRQczmi4bsQ9tY7IV/JWMFDQBZ6TnJ2ISXS6b8qr0snUl5fkJ4Uk2P0bcb6LpN0c9mCbR/XMhVAXYVHq/xd4ctPpjwX3bqRzrIRkEq4w1+FapdThfSI3cJmuTQcr7BBjhazKY9G1zBrFiGnZfdTs84Vhz3+ISg3uIjA2lNC7SkY8hHE4eI2hznGEEZn/w8dZjt2XUNLB2LZ80X3wI9ejPu7sFyhN6TOu05eNy5AHM19V9SYK1pKxczOQMEzUtlOynsCc2hdz+TiL2ROJlEiL1+F1afLKzV3crxa8L4QDIjDOLK2GVPTPVAW3tVvATzh6cRjWMLG5zP4eM+rZy09Xn0ei/+0552pN+sPOq13tnR/N9330vRAVnwqHMD68LjpYRxZkQGC3OAxq3A5M+zTWtFfX8A1rT7dJB57UluVFz4rXHExuAvT0qfv6Iz4W05K0YuPRFLrx7xKd+kigmwYrz3DeHB17WR9f7Q3BbiGMyrEKjR4FER71NmMFaxjjKNMeoaIjO3ckRkI8yDNWdq/QfuxDuCY9rF7lb8DIcWQRA+Et9xPfyQGBB0xgSOhlcCd67KU34iRWttEvOSAe1Am0nb9fqa/73XKMUoY8IEvl0oDeRG2TilyUwHFV8O6/iYuNgHjhbRTrW1FsO3GkoJKitcOLRoMkhsZncmIyq6+ISASGilp6c6z3CIZQV1nqhVUSUwSQUFPSWn7ars51jxGBkUfO9iSkNAUtFfUyXFa6ktpocNDszRxTCQYoRRlC+x6wGeG2qHWBObH0AekUtKdwdlYC8X MEotCe/w T+EXNLmeLAWTI5mCsnYujLSbaus27w7ypfkfh2JXrtPNroc1sQwUC2+VO6sgOzjVoZNkkS+b503FEXyppLBhhHJNTblfTK+JJB9z2GPI7PMoCyelW7okhH7M3FJeN5grq6wJUKuNVLrmjKAlROF4tlNJW8SbFUGPpls2+mxzoTvAB7gWKdODdFTzF1PHveNH2EtQ64VWfXERAnHH9lVmNVG4lRhwiERAwfMkZnY/VMTYMzlZTqJIt6JiXB9rxWYq1MD6Bg/cvMR5HkpIJp1avbkDYCYAPkh4FpI6lf/MvuEZrV3bII17/W+55VTVOInAB+cc3Mi13HJrDk95/06kwa4NUNLhagk1RMKMlSlN/LqtXibjcz8/9G3Eci0gi0W0MC7cyTrtN/5UNxA0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.357414, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/18 15:58, Borislav Petkov 写道: > On Mon, Feb 17, 2025 at 02:33:31PM +0800, Shuai Xue wrote: >> Currently, mce_no_way_out() only collects error messages when the error >> severity is equal to `MCE_PANIC_SEVERITY`. To improve diagnostics, >> modify the behavior to also collect error messages when the severity is >> less than `MCE_PANIC_SEVERITY`. > > That function is literally called "no way out" as in, is the error severe > enough so that there is no way out. > > Now you went and stomped all over that to "improve diagnostics". What > diagnostsics? Your commit messages need to explain in detail why exactly > a patch exists. > > So nope. > Hi, Borislav, Thank you for reply. The msg in predefined `severities`, e.g. MCESEV( AO, "Action optional: last level cache writeback error", SER, MASK(MCI_UC_AR|MCACOD, MCI_STATUS_UC|MCACOD_L3WB) ), is helpful for users to know what kind of MCE is happened. For a fatal machine check, kernel panic use the message and I want to extend to collect the message and print it out for non-fatal one. If you don't object, let's go on to discuss how to implement it. Otherwise, you can ignore the following response. Yes, mce_no_way_out() means "no way out" literally. It only collects message for MCE_PANIC_SEVERITY but use in common path. So I used this function to extend it to non-fatal, assuming it was obvious. Is __mc_scan_banks() a proper function to extend? Thanks. Shuai