From: Dave Hansen <dave.hansen@intel.com>
To: "Kiryl Shutsemau (Meta)" <kas@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Cc: x86@kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Moritz Sanft <ms@edgeless.systems>
Subject: Re: [PATCH 1/2] efi: Fix reservation of unaccepted memory table
Date: Fri, 13 Feb 2026 08:01:55 -0800 [thread overview]
Message-ID: <b3b073e4-d51e-4fd7-ad7c-7465dab412b6@intel.com> (raw)
In-Reply-To: <20260213154838.46567-2-kas@kernel.org>
On 2/13/26 07:48, Kiryl Shutsemau (Meta) wrote:
> static __init void reserve_unaccepted(struct efi_unaccepted_memory *unaccepted)
> {
> - phys_addr_t start, size;
> + phys_addr_t start, end;
>
> start = PAGE_ALIGN_DOWN(efi.unaccepted);
Why are we even aligning the start? Isn't *that* the bug?
The memblock code seems to be able to handle arbitrary alignment just fine.
next prev parent reply other threads:[~2026-02-13 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 15:48 [PATCH 0/2] efi: Fix alignenment issues in unaccepted memory code Kiryl Shutsemau (Meta)
2026-02-13 15:48 ` [PATCH 1/2] efi: Fix reservation of unaccepted memory table Kiryl Shutsemau (Meta)
2026-02-13 16:01 ` Dave Hansen [this message]
2026-02-13 16:14 ` Kiryl Shutsemau
2026-02-13 16:46 ` Dave Hansen
2026-02-13 17:20 ` Kiryl Shutsemau
2026-02-14 15:51 ` Mike Rapoport
2026-02-16 14:22 ` Kiryl Shutsemau
2026-02-16 14:51 ` Mike Rapoport
2026-02-16 15:53 ` Dave Hansen
2026-02-16 16:19 ` Mike Rapoport
2026-02-13 15:48 ` [PATCH 2/2] efi: Align unaccepted memory range to page boundary Kiryl Shutsemau (Meta)
2026-02-16 14:51 ` Tom Lendacky
2026-02-16 15:33 ` Kiryl Shutsemau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b073e4-d51e-4fd7-ad7c-7465dab412b6@intel.com \
--to=dave.hansen@intel.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kas@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=ms@edgeless.systems \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox