From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89D68C5479D for ; Wed, 4 Jan 2023 09:04:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E782E80008; Wed, 4 Jan 2023 04:04:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E280E80007; Wed, 4 Jan 2023 04:04:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF01E80008; Wed, 4 Jan 2023 04:04:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BF84480007 for ; Wed, 4 Jan 2023 04:04:12 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 90AE2160C52 for ; Wed, 4 Jan 2023 09:04:12 +0000 (UTC) X-FDA: 80316529944.12.E3E07C8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 8946BC000C for ; Wed, 4 Jan 2023 09:04:10 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gNcgWcpW; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672823050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3v5Qr9aSLQNkwvt7Qa+s/hSgVujW47TYO8SFPz2SG6c=; b=o3wjxTf3srqrE9ePOskOJ9H9nqPv+T5ysRc5rNOIqYQaGcvQQPquUfJ0lxzEpPd1tNYDau ITjzycqC2Fw92Z7pfsEvhnRpDaXuYlxinb+ji/XmO1sOiuicnUU2amwBe7j/2li6uyx/T1 he08trji4NBNfQnZqQcCBhSl/op3FzE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gNcgWcpW; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672823050; a=rsa-sha256; cv=none; b=HwUVtAICU8HaCpJMALq450WhkzYlinAlnVJFCZI1HiGbjGeMZ9HaJZMBNeZB7+T1xmmWy7 xZ/ZNu4KQLykKG0RHsb4Vn64Wz3F6ifw1tH5P+jIVz0/koH/pBqDXm+dob5+vTkL7ZqhVt LKANnspET5xh693hQyP1ERs90ZCHtQI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672823049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3v5Qr9aSLQNkwvt7Qa+s/hSgVujW47TYO8SFPz2SG6c=; b=gNcgWcpW7T7M27wiyfRYGewM2wXoUYxGqqSuzPL1lwZ9OmLOe9EYQUvSHpYz5N6V1cBCZI sVcVaVbgXLaVuTbj5iXyoD03BUwOPEPn0MjsrnEoI1J7NXjXB5YbMJkVIh2hqn7xwsQh2I 3MWStow5Uun+HY/SBzxZBGQDVPCkd2s= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-122-H4Zh4GXbNgqGIxYLQzxoFw-1; Wed, 04 Jan 2023 04:04:08 -0500 X-MC-Unique: H4Zh4GXbNgqGIxYLQzxoFw-1 Received: by mail-wm1-f72.google.com with SMTP id q21-20020a7bce95000000b003d236c91639so7249941wmj.8 for ; Wed, 04 Jan 2023 01:04:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3v5Qr9aSLQNkwvt7Qa+s/hSgVujW47TYO8SFPz2SG6c=; b=lpQVwrn6mP8BhZtb7i37Pux5Iuv+l37I0VutuDAqFhm3IuUM+w4sa4HN9Ul+DE/oVr szUFrikabmAPSMH6KIS9EijFIqc1FdzqeafftMExAlo7x2LWH8UcJXJMc2tHHuh9rEJw tVv64DHQCn6mNbbYVs3cGzlULGqZDcGf4BVn/KcOkLsSaw9e8xX9vquVUKpvKuB0nxO8 Rm9icPSBe52fPZT6uD7D8NDCinP8BC4zXLJfMtEz1V+HMe5aY7/BAaiur/U4W6wKG1Gk Yz+Fr5Xv4pq8D0Sre21axAa5rS5epBwuWEbzKkOaXY4zrBP3AvMovkEYRkOlv4NYN5l6 Ww/w== X-Gm-Message-State: AFqh2kpYjr8kvZzZNNYYsLltpVIpRLdaCyTdccesClreXc04zDqK6dln fU+KZiMIyxhig/oT/gFlVcvMPJhimBq9UxSqIXrttb5QtG/WwXgDr7WqG5FWbca3Epp2WDh6tFp +FWRl65+HnoQ= X-Received: by 2002:a05:600c:2d85:b0:3d0:7d89:2256 with SMTP id i5-20020a05600c2d8500b003d07d892256mr32189739wmg.13.1672823047443; Wed, 04 Jan 2023 01:04:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXu6TKYF8n/sbH/DYFQlrGieorL58hStPNcoaQHix/JEwDP10q76ayzPzUHCuWo/AHMULsh+lA== X-Received: by 2002:a05:600c:2d85:b0:3d0:7d89:2256 with SMTP id i5-20020a05600c2d8500b003d07d892256mr32189690wmg.13.1672823046983; Wed, 04 Jan 2023 01:04:06 -0800 (PST) Received: from ?IPV6:2003:cb:c703:f100:8100:5a6c:eb:fd3b? (p200300cbc703f10081005a6c00ebfd3b.dip0.t-ipconnect.de. [2003:cb:c703:f100:8100:5a6c:eb:fd3b]) by smtp.gmail.com with ESMTPSA id h9-20020a05600c314900b003d99469ece1sm28460642wmo.24.2023.01.04.01.04.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 01:04:06 -0800 (PST) Message-ID: Date: Wed, 4 Jan 2023 10:04:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, hughd@google.com, hannes@cmpxchg.org, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, pasha.tatashin@soleen.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net, heftig@archlinux.org, cuigaosheng1@huawei.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com References: <20221228194249.170354-1-surenb@google.com> <6ddb468a-3771-92a1-deb1-b07a954293a3@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8946BC000C X-Stat-Signature: ucx3t9epre8ftqo1oeq97zd3b6149a9b X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672823050-127572 X-HE-Meta: U2FsdGVkX19wZzp1ajosmZlUF0Om4xCHd4tbe19n/VjxwLX0ce2nopr8fT81Q8I8R9BgjlVHsXREL3rOpH2hRcaJbO49Vvisz3dOURZiDQZl1UbdG4b0g/4M9P4M4zW55v6091AdXUvtoPDfehh3b8AYAOSZkXo6RStHrAJBqxVhm68zqz9PKQDg/YLcS8y8KqH6jskLKYJVVANdCiA7fWZ+5KVRkqpi7qIw5HYI9jPt/+JyAO9cTimVODp6ejgIpA8Nam+tZCbCK/cloXMlqAiiuLEp6frHe9JpPiufFIUCUjhU7VdRBCmuH+5JFbTqyzgkaj+nkPtRtvzo9s7bmw/UZA/7Mm5Y/czxQt0LuLaood2fXLTxv4pQHdKKmUmA8gEuniHaXejNWzapPKO/084sN3/AxMPj5+gGRaiJvte5LL706TbsQO/m10cm4cJ95dD5AeMyZgNo/vp0MFKR9mFFgv+zDkJLaw5/UbcCAj67BhgDUz+GPqcdANL3wn8aLiJC7fs6/BeMHa5gogNprQS6D5Elxv/fWSzGZw/fVN+3vSC9quqXksl37DFZcmZgLUH0PQZOveFPEi63+3O7LheEd1tqMXjCZsOwmvgA3luaxtLkWKDmQi3ylKtQ4o6NuZ8yEjQC2hF9GF74QY9sLBOz1DOkbKrnVJ656tLaCUz0w7+sLUBbWK4b/H2AK7Md2J9GeEsppE1YYEzoNp1P72VcUTB7LpuzXQApuC/X5TIQC3c/MRYKOJj2pG8G8PSVINDwLnFNZrSJbkM14I4inNekaRHxGn0Ss5q990NMj869u0K3iQPCTFCIfg+mam0TvB4jh93WJ6mY9Uot3p2awJltiDJczS0HSqRCCedCdyVD2rDSjrcurgSiVUY/L7k219re/uHsnOHkigqwlaTAjecI0dAXCxZtJtuuILmOolUu2P1SKeHmbeB7w2+G+TfXsboeHV+MRdyFMtiMTk/ 3x+8ChmL ggRgTL5CDb0j91MoeBtueotsDok0nb4lcSsIJfYxYBrZEtmLvL1QClDG9sAPBDYrgXC/bdTo6xhYkI/RG8dNiyR2vRqPDUbd6UrkjtIJ5tTrLW1zOhI0flubkeSyFVFLwUJ2nFSx97jFJNSrLSG1darCMxEw3R3Owjn1UHav3zAIjSNtVvMzJSde4hfOmGDgtOx3HrddVSBFbi0liJxUnNAOPoqB83z0QgGyVdCSP3Tv/hGCzFJGooA7SYtGGPaM177G+vz7eHijK6p43FN9o88haw/i245W3LpB9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.01.23 20:53, Suren Baghdasaryan wrote: > On Mon, Jan 2, 2023 at 4:00 AM David Hildenbrand wrote: >> >> On 28.12.22 20:42, Suren Baghdasaryan wrote: >>> free_anon_vma_name() is missing a check for anonymous shmem VMA which >>> leads to a memory leak due to refcount not being dropped. Fix this by >>> adding the missing check. >>> >>> Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") >>> Reported-by: syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com >>> Signed-off-by: Suren Baghdasaryan >>> --- >>> include/linux/mm_inline.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h >>> index e8ed225d8f7c..d650ca2c5d29 100644 >>> --- a/include/linux/mm_inline.h >>> +++ b/include/linux/mm_inline.h >>> @@ -413,7 +413,7 @@ static inline void free_anon_vma_name(struct vm_area_struct *vma) >>> * Not using anon_vma_name because it generates a warning if mmap_lock >>> * is not held, which might be the case here. >>> */ >>> - if (!vma->vm_file) >>> + if (!vma->vm_file || vma_is_anon_shmem(vma)) >>> anon_vma_name_put(vma->anon_name); >> >> Wouldn't it be me more consistent to check for "vma->anon_name"? >> >> That's what dup_anon_vma_name() checks. And it's safe now because >> anon_name is no longer overloaded in vm_area_struct. > > Thanks for the suggestion, David. Yes, with the recent change that > does not overload anon_name, checking for "vma->anon_name" would be > simpler. I think we can also drop anon_vma_name() function now > (https://elixir.bootlin.com/linux/v6.2-rc2/source/mm/madvise.c#L94) > since vma->anon_name does not depend on vma->vm_file anymore, remove > the last part of this comment: > https://elixir.bootlin.com/linux/v6.2-rc2/source/include/linux/mm_types.h#L584 > and use vma->anon_name directly going forward. If all that sounds > good, I'll post a separate patch implementing all these changes. > So, for this patch I would suggest keeping it as is because > functionally it is correct and will change this check along with other > corrections I mentioned above in a separate patch. Does that sound > good? Works for me. Acked-by: David Hildenbrand for this one, as it fixes the issue. -- Thanks, David / dhildenb