From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D36C369AB for ; Thu, 24 Apr 2025 20:28:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E3536B002E; Thu, 24 Apr 2025 16:28:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 591E56B008A; Thu, 24 Apr 2025 16:28:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E6846B0092; Thu, 24 Apr 2025 16:28:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 167316B008A for ; Thu, 24 Apr 2025 16:28:08 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2C5C96A212 for ; Thu, 24 Apr 2025 20:28:09 +0000 (UTC) X-FDA: 83370074298.24.04E1D21 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id AA9C34000F for ; Thu, 24 Apr 2025 20:28:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gO6Xnr+H; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745526486; a=rsa-sha256; cv=none; b=hOZIKFWaHCVcyjfkX6cymRpKB3LyTxTz0O63/FYt9Fy/b9ehxmo49fZHyV7M6uy3lQ/Doo d3xN9Y93bMUKPRfsBSFwv6aWbj3KxmVd3pPBoS4U9MN8GSTDNUUvP/8sWq5dyh0e3ov5Bh ookq40apOszGgJInOtQmOrP3HqOpyIo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gO6Xnr+H; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745526486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0I76ScLuFbxpVSe9NxtOhJ62w7Akb6V23z2B2mhRN3w=; b=1ZZXAjJBAnWTBozTFNGL+WJoafbDPPUB81pgrrRy6lY3ZFQxNg54gz31KrNzqltjR9S7cE 1NojbW+Y+5MhiWMeeRNCMnQuzn7lG2VD+bulCjrueD9JwKBMELI78ZNy60RZ9/TwwQNYFE IAuwFOGCKqOYuirL/J4orPEcwsZZr4U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745526485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0I76ScLuFbxpVSe9NxtOhJ62w7Akb6V23z2B2mhRN3w=; b=gO6Xnr+H6D1k4xqjwArDCvqJ4AZ6PGlJ5ebSIoTtBfbxtw/70p/1qEVCO9P2as1Y0D5Thy G1Kmm4b9dw5W+1yXIKuUqW4gObj4WTSG1/zVeByoiHGKzkm9FcdGy1iaUrDVGg+lUpQwZE wtAg0hrzGP99i3ponqF8fIlwwReEIPA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-P1QB3jAVNF6qnZnPGkhEFg-1; Thu, 24 Apr 2025 16:28:04 -0400 X-MC-Unique: P1QB3jAVNF6qnZnPGkhEFg-1 X-Mimecast-MFC-AGG-ID: P1QB3jAVNF6qnZnPGkhEFg_1745526483 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43e9a3d2977so10645795e9.1 for ; Thu, 24 Apr 2025 13:28:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745526483; x=1746131283; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0I76ScLuFbxpVSe9NxtOhJ62w7Akb6V23z2B2mhRN3w=; b=Ee42fyfB0F/Jih4keIClKpFQa9a1R+6l+AvoBY0HDMACzUiO3fRQBnUXvJlbMOBJa2 ZyT4ngQQ+9txgHvMN1DNabBMDjPRj8gP2ogm9jLrYgvjxzTXymtHQ3TSquzhYnFbx6mZ ECJiTzS/c6TsiszaPtyuW+Vocq9SIdq7eXiRvrfN14X3wjSc2N+2dto+uVZQJJcWNoW7 uiZz9bVPjtPL0YsN9azLlGQZSYL8lWpU+C82wbtk023fsKukbRFcVJH9/KRXVYdrzVVZ sWl2YaJZ+8Xz/flmHy0WUQbg1r0uIfe9z8W2aVar7bFDRDx5PIzy5magkcXcO0mDjS4M Oq6A== X-Forwarded-Encrypted: i=1; AJvYcCWiBSwJxrP+IoPZnQHVNyAAHCS3A/i3li58LNuHrFsT0c1lYIyDXl6x6cB/KYjEOjkXQaAoUpn50Q==@kvack.org X-Gm-Message-State: AOJu0YzbSNGJ1Gzsr+8WZefzQJPaIobQWK4o/m4pYt2gOHEVj7xOK7bw orjhDIZQhP8wnSeUEhUAWNhco/nKgA3pE3SbA2ItDYiqyoc0oKjLBkpGIp8GmU1z0uCWo0Z2Tot JmhztrsTmcdOMvWz5YkIb4iC8M5ABg5vtjbJZsaCkUDGd4JU6 X-Gm-Gg: ASbGnctglaUuNGU1D1PRORX/+gl5rm+f2l9GBk28vRqnwnlKjIAeDr35V2R67B2ksJU PIHnbViYzM+2iRQakg5tWq+7JnEMfR9k6OBsmNwv3kedqi903ZX3nq7QmY6IgN/9b0/Wcl0Q3+G VkmhfN8pCGTYSjSdx7SOuJfJQU2VPWfOwapiNHmHumQ0l1x2xz13f5p3fIW2x9KnikMH5WBpjsk RWupbLAiOM+IQIfHB8Fb2DHQ5/stjL6hEOAJ3jkAZWXqE5EjcJ80eZSielQTLOXF7zZbQPvMmcI T8x0UaqkBL+pwfhesIj8IlJWBwRCIclZ0TblDK7dgGjAdmhqaWOC6KtHIZYP2k/gm7p+3kIYt8j lGVORwP5oBtTD+m7NmPe4n4acK5wSXdJjYFO5 X-Received: by 2002:a05:600c:1e87:b0:43c:fad6:fa5a with SMTP id 5b1f17b1804b1-440a3184442mr7949335e9.24.1745526483211; Thu, 24 Apr 2025 13:28:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8jORysgQz4LtaBZ5IZXbkcAwl3p4WEZtkcqmjKPbZxwCC9/oXK2ggW5BZtX9YR0iGNOGJog== X-Received: by 2002:a05:600c:1e87:b0:43c:fad6:fa5a with SMTP id 5b1f17b1804b1-440a3184442mr7949255e9.24.1745526482871; Thu, 24 Apr 2025 13:28:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:ff00:f734:227:6936:cdab? (p200300cbc74eff00f73402276936cdab.dip0.t-ipconnect.de. [2003:cb:c74e:ff00:f734:227:6936:cdab]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2d8976sm32523805e9.27.2025.04.24.13.28.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 13:28:02 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 22:28:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] mm/rmap: inline folio_test_large_maybe_mapped_shared() into callers To: Lance Yang , akpm@linux-foundation.org Cc: mingzhe.yang@ly.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lance Yang References: <20250424155606.57488-1-lance.yang@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250424155606.57488-1-lance.yang@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GKSpNwD33G1r2151jaaOS8Cpz_RTH1s_Wg7c8t47hT8_1745526483 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AA9C34000F X-Stat-Signature: 3qa9b6jpbsn4b9rx9t5qpqdtjbeb5ikm X-Rspam-User: X-HE-Tag: 1745526486-810582 X-HE-Meta: U2FsdGVkX1+tolxoOV3Kyu0tc34CtGpGtrSkYfb5RgprLXR/PkCBE9Mg1YoRp724Nw16NVDIk0bvpAcvqde6LdWnztA0rfsXIiMlKlbT1SUZgzRAbbg8aJzbW454LkpjlrIDhNQxIKAi+zuG+keU3mMNFdlCKqHb2CFKABZMeN+Dk0wh+kFexXTw27UsJjV2gPoajy2G9zul6J8il8bafZjmBRM1oekHOoWLLx5BwVb/W/EHN7NI0PeKhCnTTbcDCiO56UaCNUmqvEmOE9cffmfwNzZgIV6/zBSMt1x7TmgdHDCuOpD/2ZfwspUSdRTtI08ENZ54sdCZk1I6jiotn+sZq6wm3si05xRhnG+Gz5QKAVuIg54ON+dEHxxXtcDMpGL3D4CiNfWsR8x1c7hCtbVlDw1Lqh7knR7MkRyP5pFNt6hzfcEZL7n2Afn2O8tMF5RmhtMqJu2+9WKldhUb8ZWGdC8wqYh45vSMmo+ZM186Ix+mqaVZidrB3AJWdgg0SqSfn/kG1EAvuv0OKY7L7brpg3AMplYItnOSYotWE61zPbHOD4JoFid5XkfvPSJGD3KgVppUV11rs+eBt591ara2MTITbUcz33O/FgAfaN0wbbtOnTGvhjq8RdxU7BiSSCanYUMiMF5v+9o0c5SEAevAxRMdUKWZxZZVGrgbmcOScCoNLBhOaiIrTPybIY1YBM2HX2LmTZeQzvJNlurolw96W+YBitdVl6s9Fol5mWa34nrr93NPbel1SgGsvlfS41/aoyCRCvezVLLHc5rIs03J26WqKVHn1Ut6oZF9otO7YfxfCPoXtvF0s509zZxcR8k3sqnFfYir4v0Z4kS9zcUqT2AfOS3/55NWuB9VlszAmCPTO5c3RZuqf8zBeQH2GnEXrPtupLsBjjWLY7Y83+cN7VYQk7gupb4J1ZT/irIAbJ/DxOQILE66XH5KxlV8cjM2hHKQycdPqrhZyAi aglXfham S2FE/ayNlePFuJyvBnvu0LvobqI6lhoUsHmPYDCA+dpqhfIIl0covZm/iuDI2KYgi2r0mKihh1IvvrTuMkGD6YQBhgVSY3CTFXn58IMibfvxE16HKfgybJRq9Jn7/Z6bzK3DoQ3f0Y7dG1G/KYkvS7LptpLDDh1D5ZDkOmRKLJBuqs4gsF9h1uQvAPWwLMoAqZW2mlSLLZPWkaCfjAhwr3aFmsgHwSC2eNrWLQh8Nmp5XYXg7RZNPZkTxnPgni0NPjHC2xPqL8Rk8jj9OVVEPO2vgXtQjRESn3H33VHLG5v9XWkXMsyZbjL5rLSwTqKt4tMe+E51BMyr9ASWA8VD7PxTbX2CwhEkhUUdFZWARUAfWrMvruVPW0NZTiZYOWNAIGhauvUvBWYGkDSdH0+FsCBgSPRHETev99jISVoIStuKP+X4wQbn6iNoLYJI1EhMh6E1b7pGhYbLQ+/sr78+NxcIE1aGl581RUljYSzQlqWggjpYVFu+RMkTvseAOJPNnkPDx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.25 17:56, Lance Yang wrote: > From: Lance Yang > > To prevent the function from being used when CONFIG_MM_ID is disabled, we > intend to inline it into its few callers, which also would help maintain > the expected code placement. > > Suggested-by: David Hildenbrand > Signed-off-by: Lance Yang > --- Yeah, this way it's harder to abuse ... having the test functions is a leftover from when I had set/clear functions during development and experimented with using a pageflag (which involves atomics even on tail pages unfortunately). Acked-by: David Hildenbrand -- Cheers, David / dhildenb