From: David Hildenbrand <david@redhat.com>
To: Lance Yang <ioworker0@gmail.com>, akpm@linux-foundation.org
Cc: mingzhe.yang@ly.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Lance Yang <lance.yang@linux.dev>
Subject: Re: [PATCH v3 1/1] mm/rmap: inline folio_test_large_maybe_mapped_shared() into callers
Date: Thu, 24 Apr 2025 22:28:01 +0200 [thread overview]
Message-ID: <b3a951fe-577b-46de-a7c0-8e3a33a77913@redhat.com> (raw)
In-Reply-To: <20250424155606.57488-1-lance.yang@linux.dev>
On 24.04.25 17:56, Lance Yang wrote:
> From: Lance Yang <lance.yang@linux.dev>
>
> To prevent the function from being used when CONFIG_MM_ID is disabled, we
> intend to inline it into its few callers, which also would help maintain
> the expected code placement.
>
> Suggested-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Lance Yang <lance.yang@linux.dev>
> ---
Yeah, this way it's harder to abuse ... having the test functions is a
leftover from when I had set/clear functions during development and
experimented with using a pageflag (which involves atomics even on tail
pages unfortunately).
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2025-04-24 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 15:56 Lance Yang
2025-04-24 20:28 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3a951fe-577b-46de-a7c0-8e3a33a77913@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ioworker0@gmail.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingzhe.yang@ly.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox