From: Vlastimil Babka <vbabka@suse.cz>
To: Qi Zheng <zhengqi.arch@bytedance.com>,
akpm@linux-foundation.org, tkhai@ya.ru, hannes@cmpxchg.org,
shakeelb@google.com, mhocko@kernel.org, roman.gushchin@linux.dev,
muchun.song@linux.dev, david@redhat.com, shy828301@gmail.com,
rppt@kernel.org
Cc: sultan@kerneltoast.com, dave@stgolabs.net,
penguin-kernel@I-love.SAKURA.ne.jp, paulmck@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/8] mm: vmscan: add shrinker_srcu_generation
Date: Thu, 9 Mar 2023 10:23:57 +0100 [thread overview]
Message-ID: <b3a200b7-e9c5-4627-409c-e198ac1dc30a@suse.cz> (raw)
In-Reply-To: <20230307065605.58209-5-zhengqi.arch@bytedance.com>
On 3/7/23 07:56, Qi Zheng wrote:
> From: Kirill Tkhai <tkhai@ya.ru>
>
> After we make slab shrink lockless with SRCU, the longest
> sleep unregister_shrinker() will be a sleep waiting for
> all do_shrink_slab() calls.
>
> To aviod long unbreakable action in the unregister_shrinker(),
^ avoid
> add shrinker_srcu_generation to restore a check similar to the
> rwsem_is_contendent() check that we had before.
>
> And for memcg slab shrink, we unlock SRCU and continue
> iterations from the next shrinker id.
>
> Signed-off-by: Kirill Tkhai <tkhai@ya.ru>
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2023-03-09 9:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 6:55 [PATCH v4 0/8] make slab shrink lockless Qi Zheng
2023-03-07 6:55 ` [PATCH v4 1/8] mm: vmscan: add a map_nr_max field to shrinker_info Qi Zheng
2023-03-08 14:40 ` Vlastimil Babka
2023-03-08 22:13 ` Kirill Tkhai
2023-03-09 6:33 ` Qi Zheng
2023-03-07 6:55 ` [PATCH v4 2/8] mm: vmscan: make global slab shrink lockless Qi Zheng
2023-03-08 15:02 ` Vlastimil Babka
2023-03-08 22:18 ` Kirill Tkhai
2023-03-07 6:56 ` [PATCH v4 3/8] mm: vmscan: make memcg " Qi Zheng
2023-03-08 22:23 ` Kirill Tkhai
2023-03-08 22:46 ` Vlastimil Babka
2023-03-09 6:47 ` Qi Zheng
2023-03-07 6:56 ` [PATCH v4 4/8] mm: vmscan: add shrinker_srcu_generation Qi Zheng
2023-03-09 9:23 ` Vlastimil Babka [this message]
2023-03-09 10:12 ` Qi Zheng
2023-03-07 6:56 ` [PATCH v4 5/8] mm: shrinkers: make count and scan in shrinker debugfs lockless Qi Zheng
2023-03-09 9:36 ` Vlastimil Babka
2023-03-09 9:39 ` Vlastimil Babka
2023-03-09 10:14 ` Qi Zheng
2023-03-09 19:30 ` Kirill Tkhai
2023-03-07 6:56 ` [PATCH v4 6/8] mm: vmscan: hold write lock to reparent shrinker nr_deferred Qi Zheng
2023-03-09 9:36 ` Vlastimil Babka
2023-03-07 6:56 ` [PATCH v4 7/8] mm: vmscan: remove shrinker_rwsem from synchronize_shrinkers() Qi Zheng
2023-03-08 22:39 ` Kirill Tkhai
2023-03-09 7:06 ` Qi Zheng
2023-03-09 8:11 ` Christian König
2023-03-09 8:32 ` Qi Zheng
2023-03-09 19:34 ` Kirill Tkhai
2023-03-09 9:40 ` Vlastimil Babka
2023-03-09 19:34 ` Kirill Tkhai
2023-03-07 6:56 ` [PATCH v4 8/8] mm: shrinkers: convert shrinker_rwsem to mutex Qi Zheng
2023-03-09 9:42 ` Vlastimil Babka
2023-03-09 19:49 ` Kirill Tkhai
2023-03-07 22:20 ` [PATCH v4 0/8] make slab shrink lockless Andrew Morton
2023-03-08 11:59 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3a200b7-e9c5-4627-409c-e198ac1dc30a@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=paulmck@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
--cc=sultan@kerneltoast.com \
--cc=tkhai@ya.ru \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox