From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D70AC4332F for ; Fri, 16 Dec 2022 16:01:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F4458E0006; Fri, 16 Dec 2022 11:01:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A3F08E0002; Fri, 16 Dec 2022 11:01:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66B398E0006; Fri, 16 Dec 2022 11:01:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 537238E0002 for ; Fri, 16 Dec 2022 11:01:30 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E1CA38114F for ; Fri, 16 Dec 2022 16:01:29 +0000 (UTC) X-FDA: 80248634298.13.BC767CB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 6C24040050 for ; Fri, 16 Dec 2022 16:01:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EaPLLB8F; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671206477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QXlf0fi95Q9sDBDXZydRV0Mu2EmJPmkK+rvU5zY6sMw=; b=J9FTzc3SQS2hJXhzyX0rvDy5jYW/pksCJtUiNwwp/tkS9mcAOLcL21pH8UsBoUvDmeYh0q z5BnYLhXz52qKle7g89mviI6KAwuP2/wSeZdas0GhZ/jYVkRDfogEMPCublpnH7fUKCquR iBg3CNx4Wifmqpwctulmq3AYerEdZ/k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EaPLLB8F; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671206477; a=rsa-sha256; cv=none; b=gus+ZEDCyopuzSvKO7ZAwgdoA6WocfFpUPtcTJ8ib3R+o0yWOgym2hBSLXYEH8/bJtVSQD jl2OiJsNkjfUI96OtgxraB25DbXRSKcFPj7Sd4iNtAZ/6HwZl3JW9Un3hi61y6RetQea/T 0+wZsA2nVH7QeWIa3iNG1yMCbGf9X7M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671206476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QXlf0fi95Q9sDBDXZydRV0Mu2EmJPmkK+rvU5zY6sMw=; b=EaPLLB8FgdeJJO9HMWX6O54zU2Zk86pp3UDoP9KE1zl9KOrm3luvHgNKaAWvv8cKiNBHvL I1r87pDm7cV5zY98ngfu8K7CO+18XlmlpDS3crcCvWgB2ZkgVyhEPO4OB6Dq2GIsgwCIi5 hueiN5UvvYDO6wshlAUAXxPViWTw9nY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-367-OWoVMaDQPqe1LT_K2ZWNIw-1; Fri, 16 Dec 2022 11:01:14 -0500 X-MC-Unique: OWoVMaDQPqe1LT_K2ZWNIw-1 Received: by mail-wm1-f70.google.com with SMTP id o5-20020a05600c510500b003cfca1a327fso1371258wms.8 for ; Fri, 16 Dec 2022 08:01:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QXlf0fi95Q9sDBDXZydRV0Mu2EmJPmkK+rvU5zY6sMw=; b=6ZvIeZ+XAEji0jKxYgUFa0cdFwK9LG58DtRrfp6ScepOVvux2s7OiRf+MAJoqVjcqs qTJ+p/2qrvdhn7n58eAj96s7NjjVIiEJ5nAuFxfNobilX/h7dAF0J84ryP8hHGQoO/TJ lcTe2TauN51gTXANUXfHromyisyRkrZaa7i2xyK/Z2uAm4hfJdIcNAJI93+cbfkcJPMP INcu/NYfI5SWDn2PWSSlp2zaPgjX1yO9UPCqgTsRmLNSID2iDu6Unbi3GZNCChZTYdsT XEXNyzC5qIPcGdmDdK9YSM0P8wcpCPgpigu2+TSb54tn/Ximaqrad16/VC87ojzxdwBF ON1w== X-Gm-Message-State: ANoB5pmIroMz4NXl1GZNqzkhrqpK9cyC9Hgm/6KB0vVMdxW1HR+R/pXB KjXJ2nspGFuF0+5frhuAESp14vk1MdBgUIvqMgSymCYTh9BXFNZPXchsRkv96UzQF/jpMHSt23Z A2Hs2BO/NsH4= X-Received: by 2002:a05:600c:34cd:b0:3cf:c2a5:5abc with SMTP id d13-20020a05600c34cd00b003cfc2a55abcmr26467206wmq.17.1671206472022; Fri, 16 Dec 2022 08:01:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf7lP7tl2S6qgLTN3bZPyt+ZwVs1l98BARX/cmvswH+dKAX/0oE28TgKvm09gJrmULjrIem4HQ== X-Received: by 2002:a05:600c:34cd:b0:3cf:c2a5:5abc with SMTP id d13-20020a05600c34cd00b003cfc2a55abcmr26467138wmq.17.1671206471395; Fri, 16 Dec 2022 08:01:11 -0800 (PST) Received: from [192.168.3.108] (p4ff23686.dip0.t-ipconnect.de. [79.242.54.134]) by smtp.gmail.com with ESMTPSA id s20-20020a7bc394000000b003d1da8c7854sm2877335wmj.45.2022.12.16.08.01.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 08:01:10 -0800 (PST) Message-ID: Date: Fri, 16 Dec 2022 17:01:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 2/2] mm: Fix a few rare cases of using swapin error pte marker To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andrea Arcangeli , Pengfei Xu , Nadav Amit , Andrew Morton , Miaohe Lin , Huang Ying References: <20221214200453.1772655-1-peterx@redhat.com> <20221214200453.1772655-3-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221214200453.1772655-3-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6C24040050 X-Stat-Signature: wr97o8ukrfk5x53jdexzak1uuwrsn1w9 X-HE-Tag: 1671206477-27285 X-HE-Meta: U2FsdGVkX18CmxcG1pAtRtWdktRKngXIftSD1ocz3gotwpOELP8RLaknBeDWCv+FdQfDiwEHmUFzzb0tH2TZT/MwQZuDMqBTLN+sLR4cVGRkZDZG27LUVgE1KxpcFyfKD+HZgfGNsuWzoTV0foNKSaPbD7kBRU0jX4tsBpGYfpKJ5I9Ev52Bhvz+AMfCZtAOf8v/xQQCYWT4FovrotcTdrgItmq8gNwC0howFH9Ow1yHsRCwq3PSzTs0vrIdb0SjeM4ne+mjDhwjpbd3RqjHjPFto88qI6N3AJr4atTLCHlN6TKOU4dUxga/hCN2oG/YqDlAzfvPrc+5DoIcrCpFFRNGJJGnb7E6VpasbS7b9wqr2vzoxPpGTDVOmiI5FA8PMXWGLUsslVvxbnDagIGSFMu95ajiZ1/fB/Qoulc27B5N+Eq47uT49Bd+EVsCHH4kmXUgBuyZ0gBmOep5G753mPzJ7O5rGJ5PZYCtyAljprFA8Wzpp7zq3qxXyjzc+IBWCvYNVZuskHiiHNnjk5iRXerIjh6GF59p08AusCCtKMhXT3vwuQBnbZMYfx8vWo7z+G2SWbMYXRDoNv0hBNKV8De7AB1fozLsKKwzOI01ra2egjEvsUXrK/j6BiTjx9jcuHBB910U1GKRtR+JOGIpGmnNJLBi8lsUGKrwvbzdsaWEMG73gnF8FEGzNrHZecXbmTX91T2AUviSWxRMFBUvCUy1RmCtb6fWhWbVuNAWdqz5GFpVYQtpUel/P45bm3PPdfum5jXsqlbzFDUVl451LkeFic9eiXqkq35y2BkY2x+duXqpAGJHt3hMCgt76nlqTUEsd7ZM2R+OdtHHk8uKjjnmPJCaA267PY+Ggp9+BGoXoWMYy8StPQ9pxIgi//yvFOVqJFMAsbXox/vYIz43wBq0atu3UoOE18HJ2RrztCXYTYGEOVYk3BrGmYy/KGwSPsvX5AxossR13E2MZ/t inEI8ewe ng1k44BliIRUcVJaZ+rDs7uewb7ObN7mP8PLhVkndAEpcQRpd+6ofOQt0F3R9gs8Eo/g6XN7gGLXJ/GI3ILUwyuU5HrH1ZN+Cls/S+MpMbx8Fvsk3Lw+UhKy6/iuHzvKZvNx20SO69NWxSC2dAr4pR4WVLfe8MoPIvr3RVcWr413LYmZNEcvc78mJSMeFsBs6jOzJBzAXrmuE/GDA39j1FK5qqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > diff --git a/mm/memory.c b/mm/memory.c > index 032ef700c3e8..3e836fecd035 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -828,7 +828,7 @@ copy_nonpresent_pte(struct mm_struct *dst_mm, struct mm_struct *src_mm, > return -EBUSY; > return -ENOENT; > } else if (is_pte_marker_entry(entry)) { > - if (userfaultfd_wp(dst_vma)) > + if (is_swapin_error_entry(entry) || userfaultfd_wp(dst_vma)) > set_pte_at(dst_mm, addr, dst_pte, pte); As discussed, it would be great if we could in the future avoid such allow lists and instead have default allow and only handle problematic cases. Maybe we can do that in the future with selective clearing of markers. -- Thanks, David / dhildenb