From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38EC5C77B76 for ; Mon, 17 Apr 2023 14:21:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0FD66B0071; Mon, 17 Apr 2023 10:21:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBF0B6B0072; Mon, 17 Apr 2023 10:21:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A60DB8E0001; Mon, 17 Apr 2023 10:21:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 96E676B0071 for ; Mon, 17 Apr 2023 10:21:02 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 40682C0516 for ; Mon, 17 Apr 2023 14:21:02 +0000 (UTC) X-FDA: 80691094764.26.83974B4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 1802140008 for ; Mon, 17 Apr 2023 14:20:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mbe9gMqv; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681741258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hXXWTVEI1mMsVSpGycpPWe1J+aRrdeZCdqy7/mR/vH0=; b=NypGulJxbdWi1JoCZDyK3tv8+hy2wGEOLjEfTjQE2uIloGvFAZhJL/bvisjiQYFkwdgqAd DGmYzX3OF7artPO5eYBrtOIgP62VGbHyCqViDQ4/Nvb2VYdmYL1LhO0x8E7B3qsPrvcyGz Nos8tjU4eRgS+GARxQiGzbOzs27hers= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mbe9gMqv; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681741258; a=rsa-sha256; cv=none; b=dNLj7DLkZNwQfi9y/RUo38SbwQ18cjvuMnMTwsFSrnEQMmK2BS7q04eZe+KWW50t/yTff2 su+WaUow7MNt7nexQuVeJJ/1X2hrb3E/MY2d3Ns/d0DrS6DxJNrnszc9/iC9U/QuVSAdjB CI3BqkqY1guPKBJeO0QsrhtW+6tYZjo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681741257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hXXWTVEI1mMsVSpGycpPWe1J+aRrdeZCdqy7/mR/vH0=; b=Mbe9gMqv3KDIjrZYVgpGaok4s3fIhIVlR8W8qEkToGyFMP2DDwIU+vDkJBhAn0gn0jZJuZ lLtoPIRqbCFjGKpAhZjbjoEhqeffP/gLfx/CkdnsI6ZIC49TaIndxSMrDea4hGz4FiuoED f7wHMGfKJIBTn6kq4X9+1kEyyDa2R3c= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-SZXOj2rBPQWX3LUJRYSKFg-1; Mon, 17 Apr 2023 10:20:56 -0400 X-MC-Unique: SZXOj2rBPQWX3LUJRYSKFg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-2f6d4e7faabso408517f8f.3 for ; Mon, 17 Apr 2023 07:20:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681741255; x=1684333255; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hXXWTVEI1mMsVSpGycpPWe1J+aRrdeZCdqy7/mR/vH0=; b=DW3lHuwRLKENr4PLYAcxRMwL8+ANZLhHRb7X17QgUEq4wfxQTG/sz9Wv8ERpQVn/He CDDt0EcTMFxUaFvrqtTw5HRafQLUV12/vn6+bob5hP1clEU4xYbWiulKs64QNf5sADlH efa9xwPNQUxzJeh87Rv+cclymd9RIIoaJmSyA0ksWxdOy+JYRR6P6z+3HHH5iO17LXLY G+6AAt52doBOyZxuabNMRbD9PAtV77cQiWv7rmm0k+99qquqMwtf33qtCuw2aRdmOY+f mtGLkcm5rivF46c20QryyGYqhZLyKq9FSuvS7PlfiLs4VrBlWj9D6ubV5t6oTbCcDEKs 15jg== X-Gm-Message-State: AAQBX9fRATSlNsUr0wj2oPPK9XFQt34nKpK+fpylH07QlroMztOWLsyt OK8suX8DXbUFFTspspD/yUz+BlrwSTptKGLh/nOCDC0XdKRWQsW1KhhSViJunB0TKWqCCGP92Kp S2lCsk9A4gec= X-Received: by 2002:a5d:5248:0:b0:2f9:a75:b854 with SMTP id k8-20020a5d5248000000b002f90a75b854mr3792106wrc.59.1681741254931; Mon, 17 Apr 2023 07:20:54 -0700 (PDT) X-Google-Smtp-Source: AKy350boMM0zmEGTfFZFjlk6c0N1TW//CLM7LqCyngTtQr2+J07kOHHTQAknS4PxsNoOPWRVKQQvfg== X-Received: by 2002:a5d:5248:0:b0:2f9:a75:b854 with SMTP id k8-20020a5d5248000000b002f90a75b854mr3792081wrc.59.1681741254560; Mon, 17 Apr 2023 07:20:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:db07:68a9:6af5:ecdf? (p200300cbc700fc00db0768a96af5ecdf.dip0.t-ipconnect.de. [2003:cb:c700:fc00:db07:68a9:6af5:ecdf]) by smtp.gmail.com with ESMTPSA id u13-20020a05600c00cd00b003edf2dc7ca3sm12016562wmm.34.2023.04.17.07.20.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 07:20:53 -0700 (PDT) Message-ID: Date: Mon, 17 Apr 2023 16:20:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 0/7] Split a folio to any lower order folios To: Hugh Dickins , Andrew Morton Cc: Zi Yan , Zi Yan , "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , linux-mm@kvack.org, "Kirill A . Shutemov" , Ryan Roberts , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Roman Gushchin , Zach O'Keefe , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20230403201839.4097845-1-zi.yan@sent.com> <20230404144727.e613116684dbd65a4b4745c1@linux-foundation.org> <49ee481e-452f-61c7-2da5-28de2cf3de2@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <49ee481e-452f-61c7-2da5-28de2cf3de2@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 7dotzqb81y7hypkjgcnrw17bx4es9ri6 X-Rspam-User: X-Rspamd-Queue-Id: 1802140008 X-Rspamd-Server: rspam06 X-HE-Tag: 1681741257-839992 X-HE-Meta: U2FsdGVkX19YR6+7JCk8GAYPZkLJwq++kpen6p1ox4cncZCxSfYGohYjLlA1ATo6samq/HYnc9vwl8p02d9KG8cgnEi6ltJpGlbYZT0o+Pq42pQZx0QoZBBSiQO0lEhw1Csr2XdIoSBwDyTdX0l7S6gMbtdwo+5LWR8VPDWtDgCAA1Qvu/XuFloRjlVDK/9qQdR4RQA77507lRgk237c8+qosxiPrInMtKLCBCm0P4T+XtFCXK8nI3G8aODDz/NojhCH5tMP6Qnq2JWJjeKnJhytoMKegI5rEnFtlS7gc/8eI87gpwmzVZ+2SPKwduu7pVpfcNHRhwTMBQfoK/KtsDGoI2gPRiV2VU3WD6TqGEhHGbiepp4TNv0Qqjdaf3YTE1UnN5Z3oTHd0tsajspZMejBBmwk33AOP+g53vqFYyYVgCdJ3VF3m8zUt8R7BVkOoziMaD5Sju97n8IUIAmP2cgUQ4ipNzY5GW0aTgSfX/9jLQIpUTAzCheSF8w5UBtZmjuKHFRaP4PpRAPZV+/xNdMpxjxrlvBe1n/tgIGhf26aJ5KZOyxXzSYxXlKCbORXyCKNsm3EqE/KwTY+H1yzbWt46IgRqfRPh1sM1AmRVsQE4iTQN2wVKqviwmmHT/g4wyr2XD60oXpgqsm4MbQBrxqf3sycSk5IDGjfoSVv9RjmOBZG1+e4+CRij0kJu7KSFA/hLpoOlKfPkQqL/c+nZz/QBbVtKU2GhpHYmVGOSZZvlgOfXNLy2m0yTlmtPQzO/2DMYsB+Opsr5JJAYkxedjZ6vYs7M/vDomFZxVL+MHetEMKbrL+Fq5Pkizl9cUPUJOtT3XsbEKVhWO81YtY2Z6ihTuE7c1YbnGv0jKNqcBuXBMHeBDTelB2UPYSMDgrUYp5lD4yfmPDLcWCRxjHvHIfbfW0WQ/ez0Cqj0PMUCGq1Tc84HNoq2kVJTwQnXT89zCuLPYHl3gH/UlCYqqK YToquCCk p8f5MCJxQx6U9ExqqizneBode/rWUUgudLPc1AmnKEqDPX/qcFFOUxyHPh3Qs0+LOYUYOaS0oB44dHRIAr2+g/N8T5MoArVj1pnmwffXZVGJep7GZOHTUI94xrBldjH+IYdphFamw09M62cH4XDUbEpcyeigjZhC3Ol9K/Vf5UKJ1kn90WDuwXshRcl0IzKMsiDaovbfJ6dzQ42w2LOJXmkYGyKP1cFn4eWKoQNSSrl6/5kNIqHkgjUNEj4oULyja+ylQLLt2VZWlp6E0nchlIiQlgdlCOmOLe7C6qIO4kMYt8cBajMnebygx5mD2bT4h3uW9AnECmAG8Mjbj9qS4yY4Zp419gCcuCvNhAiKg8cxgBllbJ2ZGe3cYBj6vwts8fHDq299WHXx0w5bhhcljSwx4V4UBfeOZa8gJQdcpq0Ec6fqnaiW/9Sz9pddw/2awkPV/xVil2yVhiic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.04.23 20:11, Hugh Dickins wrote: > On Tue, 4 Apr 2023, Andrew Morton wrote: >> On Mon, 3 Apr 2023 16:18:32 -0400 Zi Yan wrote: >> >>> File folio supports any order and people would like to support flexible orders >>> for anonymous folio[1] too. Currently, split_huge_page() only splits a huge >>> page to order-0 pages, but splitting to orders higher than 0 is also useful. >>> This patchset adds support for splitting a huge page to any lower order pages >>> and uses it during file folio truncate operations. >> >> This series (and its v1 & v2) don't appear to have much in the way of >> detailed review. As it's at v3 and has been fairly stable I'll queue >> it up for some testing now, but I do ask that some reviewers go through >> it please. > > Andrew, please don't let this series drift into 6.4-rc1. > > I've seen a bug or two (I'll point out in response to those patches), > but overall I don't see what the justification for the series is: done > because it could be done, it seems to me, but liable to add surprises. > > The cover letter says "splitting to orders higher than 0 is also useful", > but it's not clear why; and the infrastructure provided seems unsuited > to the one use provided - I'll say more on that truncation patch. I agree. Maybe this patch set is something we want to have in the future once actual consumers that can benefit are in place, such that we can show actual performance numbers with/without. Until then, "365 insertions(+), 68 deletions(-)" certainly needs some reasonable motivation. -- Thanks, David / dhildenb