From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49FD1C35274 for ; Mon, 18 Dec 2023 08:15:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A24D6B0078; Mon, 18 Dec 2023 03:15:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 752AE6B007D; Mon, 18 Dec 2023 03:15:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61A4B6B007E; Mon, 18 Dec 2023 03:15:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 52DF76B0078 for ; Mon, 18 Dec 2023 03:15:50 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2072840988 for ; Mon, 18 Dec 2023 08:15:50 +0000 (UTC) X-FDA: 81579230460.03.DF7A8D5 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf27.hostedemail.com (Postfix) with ESMTP id 3BC0B40016 for ; Mon, 18 Dec 2023 08:15:48 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="Pg44LOC/"; spf=pass (imf27.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702887348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=84QetDdy0YwkTJVlaghRjx9Y+piF3q674vdNZK8rIls=; b=6luIzq44UgjOps7bUFQmRDYP+9/gq/1Fx7P/6zw6stpCU6BL2GJxDcAEy1R3CBC7e8XAs2 5FhZjB9P94LuNsycfQ+PFQkCsuDXwO7k2fNhc4/45pwmPwM3paX12l1avR0t/+G32ibUS6 S63E6AwM9WrK1JXeBFjYxyhuzxMo2CE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702887348; a=rsa-sha256; cv=none; b=WsdqU2kTYH5dzCNm8glyKDsIrzvYcPHogmNuOTEO1vuVLSlxwC7B+pPWWuuvsxCfTRBRUg QaKDuCGLp1GpilX2c8VPNjWs++LxwAf2zLQfpgZCYU5Ht6UH/lUN/PgF4izrB92WhVCzPu 5vEs4PyDcATJv/+BjchdZEFptDoUBpE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="Pg44LOC/"; spf=pass (imf27.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-28b7a0d1665so158479a91.1 for ; Mon, 18 Dec 2023 00:15:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1702887347; x=1703492147; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=84QetDdy0YwkTJVlaghRjx9Y+piF3q674vdNZK8rIls=; b=Pg44LOC/Vam1ujeBTgDM3gwdj28PJZXnBU8u0ebQ5PQ0W5f8I5t6p93HtIxfIBx9Yw 7EdiSWpKqfqXhVAJAwFVsWtOw3LFMfpYlEx+pqQVRojzaMBvk+gf3l8sufIGvju629ya DTWMZqJf4T/eRn5Rt8nr9kno4hy4NbUBMNF0PlSI8F8EYy9lu16cJiqts8YirJmZ8Wz8 58lk6/vMHtJwogvVEccZliPIaT49OMtGBsR15ltGikzCm3LxhviQHfvZp/7H86DGZm+v vsB9L7mzr0Tg3EOac7e2mNfO2FVXKapyTQYn0lafX/EhsWLAIhrhcVtSIbG4NlSNxqEG AbnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702887347; x=1703492147; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=84QetDdy0YwkTJVlaghRjx9Y+piF3q674vdNZK8rIls=; b=HhRuy1JDLH1mrpOd42Nr4jkZjrMgxbWMdRZl+88sUuolPnTMk3xnYcQxoioPMK8jix lmxMiRmzBRlUb2h7wDcbK8CThV+2IKAzmuyX8nYVqLyUsnhN+qR0TWHYOA097wWyTuw3 Uy4RLfmg5lFKVTju0S2Q2T4mQ5YsZ214KWzjePSPpEwgA2HlvVQhx0Jh7QlTXHs0HElr 3fPnBymDct0FffB4uwrxwcJrpcew9rToNI2/ZfCdVjpaxcdJn5L2XUCkQwvhhn31s7U4 19gFY2LMxKQUwvLmcPsa3Wm1B4LmrfZqCuNqWdcxu+KhBT510EuMPKeROK9Yc2vsizNg Yv1g== X-Gm-Message-State: AOJu0YzgQboJHPnNWuW40C3Y+fIUgOijrgO4meXE+DbXQVPf1hWMWgZl AEwnNxTA/uV4XLemv0+WbtI9KG/c+CmP6fj4onU= X-Google-Smtp-Source: AGHT+IEG6Fg8QT0Uq7858+ghK8fKpYD8eAa0zpfFPDeozWKJZ6994Dk9sYhEJq0j59KK58E4W+chzg== X-Received: by 2002:a17:90a:f190:b0:28b:6a8a:188 with SMTP id bv16-20020a17090af19000b0028b6a8a0188mr310174pjb.95.1702887346671; Mon, 18 Dec 2023 00:15:46 -0800 (PST) Received: from [10.4.170.32] ([139.177.225.243]) by smtp.gmail.com with ESMTPSA id 16-20020a17090a01d000b0028acb86f7b5sm11995018pjd.44.2023.12.18.00.15.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 00:15:46 -0800 (PST) Message-ID: Date: Mon, 18 Dec 2023 16:15:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] mm/zswap: refactor out __zswap_load() Content-Language: en-US To: Yosry Ahmed Cc: Andrew Morton , Nhat Pham , Chris Li , Johannes Weiner , Seth Jennings , Dan Streetman , Vitaly Wool , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20231213-zswap-dstmem-v1-0-896763369d04@bytedance.com> <20231213-zswap-dstmem-v1-3-896763369d04@bytedance.com> From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3BC0B40016 X-Rspam-User: X-Stat-Signature: 3ptd143mupc36i14nnu3oon14ihyeehj X-Rspamd-Server: rspam03 X-HE-Tag: 1702887348-243867 X-HE-Meta: U2FsdGVkX18N9FsisxDOxFdPCZTWN0RQd+VpaZ3A0RW7C8HRi90haq4zFs7GJgRSoT+eC2VKE9Ui66+h9KixiW/BPK8mv3cHCUKODAMJ2SJDSvd0Wx41AVkvBcBwiGkOfeRXsUrHBtLDJ9oSwT33HP3spBTR3Om0GerFlW58tnRSSkVOwvn/yUI9JBY38nMi7lr3YeeKvfvfSv65Wnx2GMjo8Tc4U9ydXhGI3ufo7BoZne3W+rIWhuhELn8/H3jmwxUGay00PMl431uqJlra+7hEEMkn6oYufcXUgKcGeDsaNjcCgqVjqG3hmk3NQrsIxyR9lBW+qnVV5MjBVgwpsePeTwvY/pyIOOUt8A4aEHzH4fux24PGNLHcfGkgxSD+lFlGJ/hKcAvb+pfvCVpNrtSxSrb5zrXZIGtHtJHdxuL7bssc0L24j5iA71ELDR0YmuUUsjYQTlby6DKpgERtWlsZX6B5DAip39LMsgGUoPwlqVMmrBPFisrHxcvdrejldtgi4H/SF5kfC7RBRewHIMbf7rYi0ZW8eYG5IodEHuBhiTU/3dhILBAFSCAy4jpY5MEx2p0KKfmybDBxgkM9ANdm1xb/ARLF/OYOxhLD41jeM7Dv57uX1a2h17iaeQYvDCDxrIqJ3tOqfkGAcsBGTyMZw8lsPzKdjDq4O1EaGothUPGMyuEM78imr+nqcZeqpn+TgUq9ze4QXgkMQnHQ2ZFnZa9Pm8Vtw28M0tfLJN5oTUt/YKnui20cY4dM2eBt4iNHhIEK0CPLt+yxS1yFd0Z9xUlI3vZ4s+MCV+pqFgkrKXipnbtKHvDZgqa2Se/1GO0VQnQ7ZOoRyidO0GSa2EmZAEoILIVAlbET9MNuzvxbXl11iTSG+HoQYgtF3zzpu0cBX0b+ukDQjf1tEBmfEkBdoQBx8HuVB6oxa1nCzM3CtctkFzEfRFcdjF3CcOdKIuVJix73/MFmkQmcRdV 1atPHS/v xRuQ7l+umrNLY8R5rsrJyg29xzI3vh9FBS8DJngjPxoW0YM3vh7IiysdexXSqRkJpa2y4+S4s4XjAC5C6hLuSZ63WnosEb3rj6L0gvitcENkWuK05HwaOQstPDL4xWbq/iRCSbaFkAPbGFTPHCLKnsDPVXBhjt2klUjlwaRAbwd7BhYbdKP6YyD3IM85y0byfmp+1qchquxEu4P2MEJ7hZLnWhKgeHhqj/7mSU7qlTdYE2Cgy9Xz9nhg83xIAiGj5EMB7kNmF5Ki9Xj73a8UZU+Tn5H2ZGIIPE+hQIsnwXAR3QxFB3v4qjXMiqt+jRGL7gao1H7VZoJJdl6th6jIEdolMhaPZB1UzOQx4PuYwl6iH9K4oLzCjMN3+rNu/hf8d74S5JMEpGhv+aW4TbOvfqEU9NodiSNQXmZkMIWMk9SKdeTSRHhV56jOAkYf8MIp7U8ZlEfmCcx45H0hfl+wWj1uj7v+f55MzPoBB944TEdBdz/Ivb1CJu9+72llT1F8eyRLO7WOz1I4UFesxx1qn7vGy9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/12/14 08:52, Yosry Ahmed wrote: > On Tue, Dec 12, 2023 at 8:18 PM Chengming Zhou > wrote: >> >> The zswap_load() and zswap_writeback_entry() have the same part that >> decompress the data from zswap_entry to page, so refactor out the >> common part as __zswap_load(entry, page). >> >> Signed-off-by: Chengming Zhou >> Reviewed-by: Nhat Pham > > On a second look, there a few nits here. > > First I think it makes more sense to move this refactoring ahead of > reusing destmem. Right now, we add the destmem reuse to zswap_load() > only, then we do the refactor and zswap_writeback_entry() gets it > automatically, so there is a slight change coming to > zswap_writeback_entry() hidden in the refactoring patch. > > Let's refactor out __zswap_load() first, then reuse destmem in it. I tried but found that putting the __zswap_load() first would introduce another failure case in zswap_writeback_entry(), since the temporary memory allocation may fail. So instead, I also move the dstmem reusing in zswap_writeback_entry() to the dstmem reusing patch. Then this patch becomes having only refactoring. Thanks.