From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F114E7717D for ; Tue, 10 Dec 2024 02:25:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF6866B00D7; Mon, 9 Dec 2024 21:25:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA6786B00D8; Mon, 9 Dec 2024 21:25:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C95446B00D9; Mon, 9 Dec 2024 21:25:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AE0B96B00D7 for ; Mon, 9 Dec 2024 21:25:47 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2E17240EE2 for ; Tue, 10 Dec 2024 02:25:47 +0000 (UTC) X-FDA: 82877458314.04.3B3028B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf23.hostedemail.com (Postfix) with ESMTP id E0761140012 for ; Tue, 10 Dec 2024 02:25:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733797523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=byvDdZZyxFrL0iV3vkplyPEfL85cAUVSx6H+DeSwce4=; b=F5BK/HEfdl3Oa2mJZx/kpBcriXZpa4xXTpM38Wliscnk6+3X76NZtF9QSapc0Bry1Ot4Yi jeVGl64Rc82bV2dsEzmjxnP/KqQiVpbfwewuvZdWYM4pfglNofWl+eSTWGB/9yRwmnfmIj Up5Hrea4Q+vt2xE0GRjv/y1QVPqs+O8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733797523; a=rsa-sha256; cv=none; b=rv6jjum7FwS/t1ikhKYEc81xPJyG78TS8KN1xgNWgv3A+L8QDEVhXC/ty/svCbxHMcDrb0 WeVciVDrV4kZqC4g+aCsT3yO/nlrv1KhF74PiWbmntQocDp/RbyRmVqFt5lbOJqU8JIx0E Q3bIE9nJHQZOIETSugrSltOWouNeqB8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Y6jFb5bVNzhZX2; Tue, 10 Dec 2024 10:23:15 +0800 (CST) Received: from kwepemg200008.china.huawei.com (unknown [7.202.181.35]) by mail.maildlp.com (Postfix) with ESMTPS id ECCD8180357; Tue, 10 Dec 2024 10:25:38 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemg200008.china.huawei.com (7.202.181.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 10 Dec 2024 10:25:36 +0800 Message-ID: Date: Tue, 10 Dec 2024 10:25:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 2/2] mm, rmap: handle anon_vma_fork() NULL check inline Content-Language: en-US To: Matthew Wilcox CC: , , , , , , , , , , , , References: <20241209132549.2878604-1-ruanjinjie@huawei.com> <20241209132549.2878604-3-ruanjinjie@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemg200008.china.huawei.com (7.202.181.35) X-Rspamd-Queue-Id: E0761140012 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: sa8srjk43rrsfzxtafb5bdpm936a6mk3 X-HE-Tag: 1733797529-445860 X-HE-Meta: U2FsdGVkX1+XhuoV7Y6sko8jKa/Uz2OwQXcPcdshICxINvZqSrr9ZO4LTuO1sPUoNaPnh+7xnMv7DphW5YahbCUBm9A5i60K3t+0bTdeWHV0l7G0fy7udCDn7h/brtUxViABYmesTanrrafCq1w5wjO0keAPDUtD5TKsa82q44KuPpHcIoUE6KmziqTzdcbhWxbYsxR9ExrEE/7J8BS87jdZePZnOVdP8BBkMs4fj0zrWVuINlHx+EL+4vK+p32gFQS3bMvVJnAUqQC5JgcMdMjfMCRPXbxhw90xz9RSGNAvjGs5F77hPJLRa/SluyqpZpw1UKdR3y7kHhnIsgjihNGPOr8IbbAKAD/Owl4LtC6ILjjEXiQXF4pBFDf3eFm7HMqM0SilUyKQMKdfSFrTt53cAvMuMYww6LdxO0NvT6UAya9zNVeIoY+k8K6+k+eSmeAlk1hHOhdvV7UwA5e5u7Ym1wlDm8qrnDgEESP1W4JhwVW2Bai/8bH4CUeNrYJ8KY+tNO0KSQsv2t77QLeJx+UVwpL+P5DpJW34lfJ9wIQDVsWSNgKwHHPPT6+mt4FIhliYwu6YYSMT2S95DK1wqYWQ0blFD3nw2dH5P3gXEjt8gHyjuVJhLohW8OvIg8glXZX+ElPXPsamuEq3A4FTt8J3WDoLyIBE845V4Qq3S/vlineDLerwULTBTJHBR2Hxz+dCOzBC7/GuBMRajZnkplTd0MgyrEG6APR7rWHlnY8Mt6vFg5NK+ffGWwiELmvjG0cPEBf1UqhpHfobiq5k58mhNsVdxV63TSlmwxeqZUZHDF1DtoXPBEyJNWdKqzxCTMRYhmo7TPS9Gghtctjq01skYfx0JUPc4LXhLhTKgQmjzV0O8srdvA+AZxH5hLedHk6tALfEzpmwoVMYc3Uh8XSH1h2PbLy5yt78W4QpSt82nuiVAL+W/+CcOMekIIQpyZ44o7V6MEQ9tNjx3fT jWz4x7Ig 232uzp/0eY0lznSsfe2sYEQCxR09zUw6BhUnBBoKqPGJL1xjN7HB3oZ2teHPBWY4wgjXN8geT8BmVjbvl5ftvrA5naZzOf5Qt4omn1WjtBmuFx4PVTnP6D75OqoNXCu9Hyj75LobD9svGSVsz+UKiIGISYrlCGsliUSkJSS2IyRn8mYvhVOwbN4uEW+rnMpZE7lYgbagvCbY5kr+c262RSFHg0QambmQpbYtfksqS8eyBIik= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/9 21:35, Matthew Wilcox wrote: > On Mon, Dec 09, 2024 at 09:25:49PM +0800, Jinjie Ruan wrote: >> Check the anon_vma of pvma inline so we can avoid the function call >> overhead if the anon_vma is NULL. > > This really gets you 1% perf improvement? On what hardware? Yes，the total improvement of this two patches is about 1% on our last-generation arm64 server platform. During the test of Unixbench single-core process creation, the trace result shows that the two functions are frequently invoked, and a large number of check NULL and returned. > >