linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <viro@zeniv.linux.org.uk>, <brauner@kernel.org>, <jack@suse.cz>,
	<akpm@linux-foundation.org>, <Liam.Howlett@oracle.com>,
	<lokeshgidra@google.com>, <lorenzo.stoakes@oracle.com>,
	<rppt@kernel.org>, <aarcange@redhat.com>, <Jason@zx2c4.com>,
	<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mm@kvack.org>
Subject: Re: [PATCH 2/2] mm, rmap: handle anon_vma_fork() NULL check inline
Date: Tue, 10 Dec 2024 10:25:35 +0800	[thread overview]
Message-ID: <b35ed617-0508-91f1-972b-801932320264@huawei.com> (raw)
In-Reply-To: <Z1byK9X59RHFJMHZ@casper.infradead.org>



On 2024/12/9 21:35, Matthew Wilcox wrote:
> On Mon, Dec 09, 2024 at 09:25:49PM +0800, Jinjie Ruan wrote:
>> Check the anon_vma of pvma inline so we can avoid the function call
>> overhead if the anon_vma is NULL.
> 
> This really gets you 1% perf improvement?  On what hardware?

Yes，the total improvement of this two patches is about 1% on our
last-generation arm64 server platform.

During the test of Unixbench single-core process creation, the trace
result shows that the two functions are frequently invoked, and a large
number of check NULL and returned.

> 
> 


  reply	other threads:[~2024-12-10  2:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09 13:25 [PATCH 0/2] userfaultfd: handle few " Jinjie Ruan
2024-12-09 13:25 ` [PATCH 1/2] userfaultfd: handle dup_userfaultfd() " Jinjie Ruan
2024-12-09 13:25 ` [PATCH 2/2] mm, rmap: handle anon_vma_fork() " Jinjie Ruan
2024-12-09 13:35   ` Matthew Wilcox
2024-12-10  2:25     ` Jinjie Ruan [this message]
2024-12-09 13:42 ` [PATCH 0/2] userfaultfd: handle few " Lorenzo Stoakes
2024-12-10  1:21   ` Jinjie Ruan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b35ed617-0508-91f1-972b-801932320264@huawei.com \
    --to=ruanjinjie@huawei.com \
    --cc=Jason@zx2c4.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lokeshgidra@google.com \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=rppt@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox