From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53ED5C71153 for ; Thu, 24 Aug 2023 18:30:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD42C28009D; Thu, 24 Aug 2023 14:30:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D84758E0011; Thu, 24 Aug 2023 14:30:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C262228009D; Thu, 24 Aug 2023 14:30:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AF3F88E0011 for ; Thu, 24 Aug 2023 14:30:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 877F81C963C for ; Thu, 24 Aug 2023 18:30:24 +0000 (UTC) X-FDA: 81159838368.30.4AACC05 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 40A3980027 for ; Thu, 24 Aug 2023 18:30:22 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dcTHW+9i; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692901822; a=rsa-sha256; cv=none; b=Dp0eZJf+b+QhiSsGM7Lo1m4fNbqVRN99N19c2JOWz935Dvgpe+AUT7dIVeetMR/TCTU2or NU7VrVeiVDyOrAc0p+gCKgBYddKbcPbKJXMetc6IQywoM5pGbpgXInEY8tzsZtONY8XiVC XDOWUcEriWl87iIvkTsUBfxg7aKVtdE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dcTHW+9i; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692901822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1DaVCUYtUUYNIU8IoTdr4/o0Q5aZzEujz7FLGwlWzrM=; b=rnH9IEPQTkR8zcUISp/KQ6sz8rjF/XuJHNADpsWan2IJK0UtKKpYF3SHtQPUgW8PUx0eia eAgxMGWhDVUD8fU4XZMxaGaj0tzUWjRfAhoO1p0PKTDXEXfyTNKFSHzUAYej6CsYbYfRQc e2qALdiO2amH6RrNi9X2Om0hbsr4NE8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692901821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1DaVCUYtUUYNIU8IoTdr4/o0Q5aZzEujz7FLGwlWzrM=; b=dcTHW+9iApjKuhS0SUQwN4ULODDm4ZndxyeTC7ooHE0AX8iLLaNjqDa3k4evV0B0L73jhH FgDjqSTxMch3WXMuwA5MhwxaevayjAbbXhIy1BDeVwQPIkvyzTksJrz+lCQ2g1LjzXeZlZ Tx7yEhXURyntWOrSPTAd7WSIHTuMVNA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-u2BOEGSlM5WOGYoto-0_uQ-1; Thu, 24 Aug 2023 14:30:20 -0400 X-MC-Unique: u2BOEGSlM5WOGYoto-0_uQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-401b0ff0f39so3884595e9.1 for ; Thu, 24 Aug 2023 11:30:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692901819; x=1693506619; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1DaVCUYtUUYNIU8IoTdr4/o0Q5aZzEujz7FLGwlWzrM=; b=QUEhBdGGnubsE5fzZ5ahQ3mRobmKujI0KOUyw1uG2LdEZMjBup4oiQANs3+T00jOV3 F71C2XBFxTzeIigoyq4us1vcdqgQtKQqPliMfff93QVZt4YH/ejbH0hd1qFy7UQagQL6 X9TXACwYplcRfr78QV0+Cflee2PxmLGixYMKYwW06J48VmUB0C9Iwz2XT66UVk8bOM4O QAPCcfAIpDJ1ThzFRi19OZqivGHSiHtn5/6vbfMphG/j/dv1PvEM6UCTXMehz/rCxAr+ gFIB/l1Bu8amSL+WslXqkfZ1Svyxc93J+2jkOtPyxIbmovHC/QRTWi20dBlL7hWVRPCV Wmdg== X-Gm-Message-State: AOJu0Yx+e7h6xDn0trZFrfHB6RfmbaIjjWT/q24gjMivvuLnI3QFYJF6 u39rH/9QfLQD2gO6P6ite2AamF9j3KlMuWZJxAJGQEm3nod6Bg/TiKvtVzMPFR0BOc2i9x1tx6X Iv8e/1GxoxRI= X-Received: by 2002:a7b:cd94:0:b0:401:b3a5:ec04 with SMTP id y20-20020a7bcd94000000b00401b3a5ec04mr585623wmj.16.1692901819052; Thu, 24 Aug 2023 11:30:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGN04IIxMsQ/oKjnheZdkOIfcTD73tF4gyi9QjRzFBXkXJ9aEOscxTYQ2RdrpRS72cpDPmMlw== X-Received: by 2002:a7b:cd94:0:b0:401:b3a5:ec04 with SMTP id y20-20020a7bcd94000000b00401b3a5ec04mr585603wmj.16.1692901818664; Thu, 24 Aug 2023 11:30:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:6200:16ba:af70:999d:6a1a? (p200300cbc709620016baaf70999d6a1a.dip0.t-ipconnect.de. [2003:cb:c709:6200:16ba:af70:999d:6a1a]) by smtp.gmail.com with ESMTPSA id p13-20020a7bcc8d000000b003fe1cac37d8sm3325190wma.11.2023.08.24.11.30.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 11:30:18 -0700 (PDT) Message-ID: Date: Thu, 24 Aug 2023 20:30:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 0/3] udmabuf: Add support for page migration out of movable zone or CMA To: "Kasireddy, Vivek" Cc: Jason Gunthorpe , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Gerd Hoffmann , "Kim, Dongwon" , "Chang, Junxiao" References: <20230817064934.3424431-1-vivek.kasireddy@intel.com> <8afa35bb-c3ed-c939-46a4-a9a277b6d4e2@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 40A3980027 X-Stat-Signature: nbgwginrih55a1are6e385m3i7b9f5s9 X-Rspam-User: X-HE-Tag: 1692901822-11422 X-HE-Meta: U2FsdGVkX1/OyZK4aWfL76GMpC7rmOLwWVJ3gpYNmwpF+IVhNy8mmb6m8QcDPkRPUs1N4EybKuDMrKzK5O0aRBA+w5ykOCSr7nptoHdCikDPHqLUY5Y9SV5BtndTDzZU4E51Z/b5V3Ea/ESv/Rt9fpnUdqdK8yN/tEp1wzDobbPf6gEWlCZqR1Xjz/O3z8+bUr1BMsG0bvG7ZYHIsyFDC/pYmwqHaoX2eGwsY/MWpt6LMiwq6F4FXQqiOOeW1m0sW2bv1euJ1hSbZd4Ge0INyq+rnSptoxKcrhiCG220XW48XYRK5OhnoN1vLiOXMcAt/TlhttceQIExViuO9FtXx69s3VHBPJblp3iMkZ7wWi/hAWCUb1RdlpR4O6so7ZWeRl/zNefHi4LxaaAkAheSteIXxwZ0Y4mcpoPPYIm/mUlxTMVJmH02843HNqHRI9agN1HTervD0+kR9/FbdsEmpEXL9l1Xd7uQENR8f4QAQByK9NxPHxoWpxKDRW93HG9kzFZAYCOJ5p5m+VxkXcpj09v/2BiFVxJ9YQaCkTBXEQJRd2usknckxnsmO4DU6CyS4BCtI51HsSwsfNrtjnmVXDfWDYuS4Eq7QVkyv0EMEYjGqJ8nJGaLBs8EOM5c7+ZFpN6zZRpl9w5VoM5E8GtNaxrmYKaj7JSv/2qyXBWFrVSJOW7PFyWr7wF+jiy2VVVkeGkAvG8zBcWDVXoun3leZ4bgPX5dfeGjZY4swns8o/kEpcY1vQ/QHi2WS+R5ojr/7tilsSKkU4HciN/Ge4LlQukXMAkmO3AZkTyYUtkz83fuCd2YKct7WMTL89w7s9/pGdIs7/2jHJq0YyjSJfoLO5ZxVJt4MrzsegpeMS9w2aHeNP8FLVxQhve6o0DiXnPzRb3X0Izdadu0lYJUy4STn6ymXj0PXhvF5kJs6qu5XB9IYjzFiIWtlY/0KR+lftc2B4NGIdPpoe7buuQCsw9 dUjqHVQa 0wt8q4zMDiLnBw2meUmJ2hkmDZdmQy+i7k9uK/XgoU/AVKwfdPTgkdq9eASwP/vTICq0Rq2JcMg3XKInF6Oj0WZiuCCUBPTVjyAH4hWqCeZG53uyZIJvYy4uoKe0MNyNoQ5FUDtLbJhbJM04KHdeIbu5URv38yb/roeMbA8+LTLOW0zxsDbqYjcS0IbEUPiFRJas1k0KgD4c0mVEhMqUfa3czMkviVsLEj+D3TnDnU4ewK9e00wte0gg74kwRwm4s4R9J/V1xbTWbpDryj5aKUDktcrRnuomJ0cngFw9+cNxhfTJNofXJ3rlO4LdqTi+HiLaubYA3l10iEit/47ihrVRiYt6qTIqtg/KJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.08.23 08:31, Kasireddy, Vivek wrote: > Hi David, > >> >>>> - Add a new API to the backing store/allocator to longterm-pin the page. >>>> For example, something along the lines of >> shmem_pin_mapping_page_longterm() >>>> for shmem as suggested by Daniel. A similar one needs to be added for >>>> hugetlbfs as well. >>> >>> This may also be reasonable. >> >> Sounds reasonable to keep the old API (that we unfortunately have) working. > I agree; I'd like to avoid adding new APIs unless absolutely necessary. Given this, > and considering the options I have mentioned earlier, what would be your > recommendation for how page migration needs to be done in udmabuf driver? I guess using proper APIs for shmem and hugetlb. So, turning roughly what you have in patch#1 for now into common code, and only calling into that from udmabug. -- Cheers, David / dhildenb