From: David Hildenbrand <david@redhat.com>
To: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Mike Kravetz <mike.kravetz@oracle.com>,
Hugh Dickins <hughd@google.com>, Peter Xu <peterx@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Kim, Dongwon" <dongwon.kim@intel.com>,
"Chang, Junxiao" <junxiao.chang@intel.com>
Subject: Re: [PATCH v1 0/3] udmabuf: Add support for page migration out of movable zone or CMA
Date: Thu, 24 Aug 2023 20:30:17 +0200 [thread overview]
Message-ID: <b35cd8f7-e7dd-e47b-112c-62ee84c92768@redhat.com> (raw)
In-Reply-To: <IA0PR11MB7185B7B437E98F7F594D3E0EF81DA@IA0PR11MB7185.namprd11.prod.outlook.com>
On 24.08.23 08:31, Kasireddy, Vivek wrote:
> Hi David,
>
>>
>>>> - Add a new API to the backing store/allocator to longterm-pin the page.
>>>> For example, something along the lines of
>> shmem_pin_mapping_page_longterm()
>>>> for shmem as suggested by Daniel. A similar one needs to be added for
>>>> hugetlbfs as well.
>>>
>>> This may also be reasonable.
>>
>> Sounds reasonable to keep the old API (that we unfortunately have) working.
> I agree; I'd like to avoid adding new APIs unless absolutely necessary. Given this,
> and considering the options I have mentioned earlier, what would be your
> recommendation for how page migration needs to be done in udmabuf driver?
I guess using proper APIs for shmem and hugetlb. So, turning roughly
what you have in patch#1 for now into common code, and only calling into
that from udmabug.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-08-24 18:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 6:49 Vivek Kasireddy
2023-08-17 6:49 ` [PATCH v1 1/3] mm/gup: Export check_and_migrate_movable_pages() Vivek Kasireddy
2023-08-30 14:15 ` Christoph Hellwig
2023-08-17 6:49 ` [PATCH v1 2/3] udmabuf: Add support for page migration out of movable zone or CMA Vivek Kasireddy
2023-08-17 6:49 ` [PATCH v1 3/3] selftests/dma-buf/udmabuf: Add tests to verify data after page migration Vivek Kasireddy
2023-08-17 15:01 ` [PATCH v1 0/3] udmabuf: Add support for page migration out of movable zone or CMA Jason Gunthorpe
2023-08-22 5:36 ` Kasireddy, Vivek
2023-08-22 12:23 ` Jason Gunthorpe
2023-08-23 9:34 ` David Hildenbrand
2023-08-24 6:31 ` Kasireddy, Vivek
2023-08-24 18:30 ` David Hildenbrand [this message]
2023-08-24 18:30 ` Jason Gunthorpe
2023-08-24 18:33 ` David Hildenbrand
2023-08-25 17:29 ` Jason Gunthorpe
2023-08-27 18:49 ` Kasireddy, Vivek
2023-08-27 19:05 ` Kasireddy, Vivek
2023-08-30 17:30 ` Jason Gunthorpe
2023-09-14 13:43 ` David Hildenbrand
2023-09-16 18:31 ` Kasireddy, Vivek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35cd8f7-e7dd-e47b-112c-62ee84c92768@redhat.com \
--to=david@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dongwon.kim@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hughd@google.com \
--cc=jgg@nvidia.com \
--cc=junxiao.chang@intel.com \
--cc=kraxel@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox