linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <luizcap@redhat.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, david@kernel.org
Cc: ryan.roberts@arm.com, akpm@linux-foundation.org,
	lorenzo.stoakes@oracle.com
Subject: [PATCH 10/11] mm/thp: always enable mTHP support
Date: Mon, 15 Dec 2025 16:16:52 -0500	[thread overview]
Message-ID: <b3588c1a6976cf8d00fe39f5cb8918b42e4d4c3c.1765833318.git.luizcap@redhat.com> (raw)
In-Reply-To: <cover.1765833318.git.luizcap@redhat.com>

If PMD-sized pages are not supported on an architecture (ie. the
arch implements arch_has_pmd_leaves() and it returns false) then the
current code disables all THP, including mTHP.

This commit fixes this by allowing mTHP to be always enabled for all
archs. When PMD-sized pages are not supported, its sysfs entry won't be
created and their mapping will be disallowed at page-fault time.

Signed-off-by: Luiz Capitulino <luizcap@redhat.com>
---
 mm/huge_memory.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 1e5ea2e47f79..882331592928 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -115,6 +115,9 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,
 	else
 		supported_orders = THP_ORDERS_ALL_FILE_DEFAULT;
 
+	if (!pgtable_has_pmd_leaves())
+		supported_orders &= ~(BIT(PMD_ORDER) | BIT(PUD_ORDER));
+
 	orders &= supported_orders;
 	if (!orders)
 		return 0;
@@ -122,7 +125,7 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,
 	if (!vma->vm_mm)		/* vdso */
 		return 0;
 
-	if (!pgtable_has_pmd_leaves() || vma_thp_disabled(vma, vm_flags, forced_collapse))
+	if (vma_thp_disabled(vma, vm_flags, forced_collapse))
 		return 0;
 
 	/* khugepaged doesn't collapse DAX vma, but page fault is fine. */
@@ -806,6 +809,9 @@ static int __init hugepage_init_sysfs(struct kobject **hugepage_kobj)
 	}
 
 	orders = THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE_DEFAULT;
+	if (!pgtable_has_pmd_leaves())
+		orders &= ~(BIT(PMD_ORDER) | BIT(PUD_ORDER));
+
 	order = highest_order(orders);
 	while (orders) {
 		thpsize = thpsize_create(order, *hugepage_kobj);
@@ -905,9 +911,6 @@ static int __init hugepage_init(void)
 	int err;
 	struct kobject *hugepage_kobj;
 
-	if (!pgtable_has_pmd_leaves())
-		return -EINVAL;
-
 	/*
 	 * hugepages can't be allocated by the buddy allocator
 	 */
-- 
2.52.0



  parent reply	other threads:[~2025-12-15 21:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 21:16 [PATCH 00/11] mm: thp: " Luiz Capitulino
2025-12-15 21:16 ` [PATCH 01/11] docs: tmpfs: remove implementation detail reference Luiz Capitulino
2025-12-16  7:40   ` Baolin Wang
2025-12-15 21:16 ` [PATCH 02/11] mm: introduce pgtable_has_pmd_leaves() Luiz Capitulino
2025-12-15 21:16 ` [PATCH 03/11] drivers: dax: use pgtable_has_pmd_leaves() Luiz Capitulino
2025-12-15 21:16 ` [PATCH 04/11] drivers: i915 selftest: " Luiz Capitulino
2025-12-15 21:16 ` [PATCH 05/11] drivers: nvdimm: " Luiz Capitulino
2025-12-15 21:16 ` [PATCH 06/11] mm: debug_vm_pgtable: " Luiz Capitulino
2025-12-15 21:16 ` [PATCH 07/11] mm: shmem: " Luiz Capitulino
2025-12-16  7:52   ` Baolin Wang
2025-12-16 13:47     ` Luiz Capitulino
2025-12-17  2:03       ` Baolin Wang
2025-12-17 18:50         ` Luiz Capitulino
2025-12-15 21:16 ` [PATCH 08/11] treewide: rename has_transparent_hugepage() to arch_has_pmd_leaves() Luiz Capitulino
2025-12-15 21:16 ` [PATCH 09/11] mm: replace thp_disabled_by_hw() with pgtable_has_pmd_leaves() Luiz Capitulino
2025-12-15 21:16 ` Luiz Capitulino [this message]
2025-12-15 21:16 ` [PATCH 11/11] mm/thp: x86: cleanup PSE feature bit usage Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3588c1a6976cf8d00fe39f5cb8918b42e4d4c3c.1765833318.git.luizcap@redhat.com \
    --to=luizcap@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=ryan.roberts@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox