From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D5CC5B543 for ; Wed, 4 Jun 2025 09:45:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D9716B04F6; Wed, 4 Jun 2025 05:45:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B1756B04F8; Wed, 4 Jun 2025 05:45:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A1416B04FB; Wed, 4 Jun 2025 05:45:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 215F96B04F6 for ; Wed, 4 Jun 2025 05:45:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BFAE8C0D9B for ; Wed, 4 Jun 2025 09:45:09 +0000 (UTC) X-FDA: 83517234738.30.2F91A38 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 4D01EC0003 for ; Wed, 4 Jun 2025 09:45:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AC30mw8+; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749030307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N25tBxOpW4+CmaozSXoxCREQxpCpS3nehI/HEnEd2/c=; b=xlXSKzZxYdqkxkjMVTlHGrxHMNAuh9uYDGzeCCLGSJzO0M+fe7mLOjIA/ny3YB6aDXqe6r 1dwRqrsAshgqQfYhIRwFkj774BOe4qr6Wwr+lw/AB3XH98jxwWw1ZVZ676ntKyrFe0+elg d8US0EFU8Fx4ILijZE9DW0q9vK51qqU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AC30mw8+; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749030307; a=rsa-sha256; cv=none; b=PS7VGu/O8xzXQByOAG1WyQxFjeqHoU4v4FHQvtWxoR+qJ7n1h7Au4vRzLvIPx8CUUdx3/E sY5RtUzfDSs6X2oozCSNHMIqKty8bJi8cTsWSe7S/h42ggjFdRTMDqXahx8zpmGyHzKmQw VCGeLf/wqrMPJFyM4J1X2ltNji0+byE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749030306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=N25tBxOpW4+CmaozSXoxCREQxpCpS3nehI/HEnEd2/c=; b=AC30mw8+bc2m/4zS5Bd27mbcZHLxOP9BF1sfoZCgp5oMdRTods1sw6cbpbcDNflCWqZ3SL J54I4U8AkmuvA45X1FYSEMasMUei7rFy028KOtq0k7z55ccKjeoNWhCgEJfQrzDm6iJWGM u0Ov813qVP2NeU3l9NJ0S/VnXtUrE3Y= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-pNKG-uHKMMmdBQWZY6S3ng-1; Wed, 04 Jun 2025 05:45:05 -0400 X-MC-Unique: pNKG-uHKMMmdBQWZY6S3ng-1 X-Mimecast-MFC-AGG-ID: pNKG-uHKMMmdBQWZY6S3ng_1749030304 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-451deff247cso3575495e9.1 for ; Wed, 04 Jun 2025 02:45:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749030304; x=1749635104; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=N25tBxOpW4+CmaozSXoxCREQxpCpS3nehI/HEnEd2/c=; b=GI9QwZK5UoQD7Sk7eK8WzP4cP6q+Ba6jw+wRKuHQKDdu2XwFlCvzpiTdzeByipyS/Q hqqmXTzGIkvgeFJ7Y9PbVf50mULTHFRllNbP8zLfjku5ZRgwMAHoYZQnk7r+83rs0/f5 /TC9zu9MhBoIuMnGdI9mn6R64eXEGImAkysSr2VF7pMH2jSQDqgsPYdYdRAniez79z69 BHWnWv51lcPiVOfNf3VcDOxC1HNBuOuD+bmsSjtH6UHDq1L4NhelnBKiQkVJZ9ikrpGo ZfJ6tLLqADeetqW+8GEDzKwMsYGajP+r3vkl2Q6nxxr2OVjljc8+Lhp6yyBkoOXjdU8z HWmg== X-Forwarded-Encrypted: i=1; AJvYcCVS8vzOv26MiDvUFT7ZFG4kkjU/utY077eFUi2XZmM0PJxTu5ml6J3uLzrmX9gbaP7dos/jHbNJlA==@kvack.org X-Gm-Message-State: AOJu0YxjiESWNjj2yG2h7moIISLPNMbWNfhc1HndzLpHkQ0faWW2dbe9 cUHB8i1cWf8K593D1n/nV4tQCDr1qH6Kul1ipfXsqWWhiOgkZD3lhTk7fy0NYjmtAAqHlSoZd5y wsjejXtEiXu8kzbZ5wC9RSJOkvPy+PHNVRac2syLhqn0ZqZcPmlBW X-Gm-Gg: ASbGncuVxqJwqDHB5MC5LkExRZpYCbrwLE1Wqdp0EW6FoYV8YlkbcGH/kvpqCI9yfPi VAJXjvtX/ZIyu9ZWjTlJg04jLOBFN1S1rJyJZIplU4jGFvcgh+5MuXvFGQm6VIjoGTU43P7JL3j FhzQk5WkCzJugn+PtP9X9MdE6wHfkNDpSlgIU1g0P6gjKmGXxwNtqy6LEGIzVoofsobxa1l9Ifq 2QlGshpiYKNmV8a+GBYl6vova60vgEOVfrmocw92n7fdrSkX3cPMZX+9pjz2kE6ryOTBfu4pYV/ cY+D0qv39hQT8zulAZZxnd3gUZw0R7RL6bumQJBmOHVzUGmqjiZvqT9PExNU4lHGK7vfhEYjMx6 SXwvLwEfyeob+x0kv6UnZTw3in1qc/J7oz+C+mAk= X-Received: by 2002:a05:600c:a197:b0:43c:ec72:3daf with SMTP id 5b1f17b1804b1-451e61221d7mr46452785e9.14.1749030304327; Wed, 04 Jun 2025 02:45:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8k9sHoubF3xa4TwhFMghUcSSm4V4hCJo5i/46wpXB1vGZJemDM4SbI1oLdasTdXNoJZZ2jw== X-Received: by 2002:a05:600c:a197:b0:43c:ec72:3daf with SMTP id 5b1f17b1804b1-451e61221d7mr46452445e9.14.1749030303869; Wed, 04 Jun 2025 02:45:03 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf? (p200300d82f1bb8006fdb1af24fbd1fdf.dip0.t-ipconnect.de. [2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe6c79dsm20728119f8f.25.2025.06.04.02.45.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 02:45:03 -0700 (PDT) Message-ID: Date: Wed, 4 Jun 2025 11:45:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/5] drivers/base/node: Optimize memory block registration to reduce boot time To: Andrew Morton , Donet Tom Cc: Mike Rapoport , Oscar Salvador , Zi Yan , Greg Kroah-Hartman , Ritesh Harjani , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , Madhavan Srinivasan , Nilay Shroff , linuxppc-dev@lists.ozlabs.org References: <2a0a05c2dffc62a742bf1dd030098be4ce99be28.1748452241.git.donettom@linux.ibm.com> <20250603200729.b7581e017e4ca63f502c795e@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250603200729.b7581e017e4ca63f502c795e@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bdkdxxurVC7lY3RxJ8sazUnS3zlrj0Xzef_VZ1cLy7E_1749030304 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4D01EC0003 X-Stat-Signature: ordkndrkwj55raakjyibxm7onazbwmot X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749030307-428187 X-HE-Meta: U2FsdGVkX1+mCRryIf09nw60KDersplf4nrqZpxsIJGHywCQaHnTu+VdKZG0GFA4aLzaHhsde0doVBVtGXF0XTbxMmMLHxwHpKqYKpNb+wuiVCqL9fVbgnvSdHzAUvtFmGjaDWV1I02DgaVyaYTBbTLnG2SOL+7mgCXi2NUNIQR+szBfW5P8VfZ4BfXkop3EYela/W/uY4Cti4MhdQhPXqWoAlcmMq7648LFS3F2xPlYQKMnAR5KCOV1wvSxnPQKl7fq5bRHRzY2ZhMsqWf9uplS6AVzjdajKCkjUd5LcViur/b3YbbUfNKV7EvUi5aF51f7F42eceyAUwHSWInnLd0rGJM/eDl8RiAP91Jw0e0FZZm+PpebHmIMSk1TSdo/FCCxBbBbgFomFIvE3mXH3ILvzmCy89BznAs4rgqCgW5G1bZdsQzxr95Lq+X+7Rbe0Ya2zU+G6cozdAdBJz+mKHo8WHaLR+/QunBylGYX83D9vI2El4Mx55vNx1kSrDRDMhbeDu0g5/Vw9Tpu3dGCP6rTrF2vA9UTw8Bc6FqTO1Z0uZLFHwlfvz82Xva6L6tTwkn6hEecAIrGktpnsXNNjnmBOTVFmMAMJGCOoiqjM/COj6oBMPucEC4VaeGrHkCUqYkACE9f0N5o7RSU9XQLwmx8X2HR3lBeg0IeevWF/g54B+7XYF8RRx0DWbJVoVC4DYheSXc+CJNm1ZezGwhVKxBQzo4jZcioBn2Yp/h4dgMHAuG3Xazqvt2Ago8Byy6Iad6lKNo4Yk+JgjCZnv2iDKJtkDP64rdv/ze8470YwkNnhXesPczYRpHn43RbEkkN27EwTARU7XsF/VSSOzCxt2pMi6VUA6EJCRWtPhmrVnK+NTkikaPqj19OxoyGPv6MRpL/p/bXlw2SO5QtRybkCXgesQpehwDxPU1iMXZN8LxkK3b9Tzz7K/2q2OOGjWl9SavB4/cT2m1XR2JDwRb cKInwXyS Y1BExjaFvQhYD963ovvBmcHB6xhdRUC1aJ0g93DKRqZuzLKgBnAkpnW+Fv9lQRYaN5asuceX5MIq1sjwO7ItLo+EjCV2N1Jo7Og1rtVn8mowA9v99FZlyyx4c0u6L+caEc0N3kboN7+9XcWmN1wNbYCIfXGRSOz9cAH8oSWqSytXdKIox2NLbM2kC2SlbaRIH0e8jMtJvrgHWQHqtAuv+Wrc+7antWfhlJiuEdYgg6IzuPXtWF5aKeQ+cPzrwhJVlmFQbNnzCEdYWd+6Ybi99Seqjm38mJvzgbD5b1wWrP9DTR0mGDfvEuKNF4/oQnROObTHvwzV0aBD0kfovqmF4YF9Uyyi2NIHlfNOqLJiNzgH9xHic2mDR0HoO9NB4KjW187hEd3f7SToky6loTaY9hHLdq+3kEcHEqsF8EB3n3DgHB0zNBUoJPrKWgmu5iItbarSOCvR5kFCWEp/7GoYhFPXn+OysJXxGGYi8zYzOdnaz3xgKjg4ej29TX9qOfbbg2LNYkmB08YiKM3ahfHm1JcOL/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.25 05:07, Andrew Morton wrote: > On Wed, 28 May 2025 12:18:00 -0500 Donet Tom wrote: > >> During node device initialization, `memory blocks` are registered under >> each NUMA node. The `memory blocks` to be registered are identified using >> the node’s start and end PFNs, which are obtained from the node's pg_data > > It's quite unconventional to omit the [0/N] changelog. This omission > somewhat messed up my processes so I added a one-liner to this. > Yeah, I was assuming that I simply did not get cc'ed on the cover letter, but there is actually none. Donet please add that in the future. git can do this using --cover-letter. >> >> ... >> >> Test Results on My system with 32TB RAM >> ======================================= >> 1. Boot time with CONFIG_DEFERRED_STRUCT_PAGE_INIT enabled. >> >> Without this patch >> ------------------ >> Startup finished in 1min 16.528s (kernel) >> >> With this patch >> --------------- >> Startup finished in 17.236s (kernel) - 78% Improvement > > Well someone is in for a nice surprise. > >> 2. Boot time with CONFIG_DEFERRED_STRUCT_PAGE_INIT disabled. >> >> Without this patch >> ------------------ >> Startup finished in 28.320s (kernel) > > what. CONFIG_DEFERRED_STRUCT_PAGE_INIT is supposed to make bootup > faster. Right, that's weird. Especially that it is still slower after these changes. CONFIG_DEFERRED_STRUCT_PAGE_INIT should be initializing in parallel which ... should be faster. @Donet, how many CPUs and nodes does your system have? Can you identify what is taking longer than without CONFIG_DEFERRED_STRUCT_PAGE_INIT? -- Cheers, David / dhildenb