From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jann Horn <jannh@google.com>,
Pedro Falcato <pfalcato@suse.de>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] mm: remove WARN_ON_ONCE() in file_has_valid_mmap_hooks()
Date: Wed, 14 May 2025 10:21:02 +0100 [thread overview]
Message-ID: <b346ce3e-3fe8-47cd-bd30-81f9e513a2d7@lucifer.local> (raw)
In-Reply-To: <8e13926d-b685-4802-a207-ade2001cb657@suse.cz>
On Wed, May 14, 2025 at 11:13:27AM +0200, Vlastimil Babka wrote:
> On 5/14/25 10:56, Lorenzo Stoakes wrote:
> >> Fixes: c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file callback")
>
> Ah yeah I missed there wasn't one.
>
> > Is it worth having a fixes tag for something not upstream? This is why I
> > excluded that. I feel like it's maybe more misleading when the commit hashes are
> > ephemeral in a certain branch?
>
> Yeah it can be useful, in case the fixed commit gets backported somewhere,
> tools can warn that there's a follow up fix. As mm-stable hashes should not
> be ephemeral, then this should remain valid (and if there's a rebase for
> some reason then the fix could be squashed).
Yeah the mm-stable hashes not being ephemeral was the bit of information I
was missing, I would have added this tag otherwise!
One day I'll get the hang of this mm stuff... :P
>
> >>
> >> Acked-by: David Hildenbrand <david@redhat.com>
> >
> > Thanks!
> >
> >>
> >> --
> >> Cheers,
> >>
> >> David / dhildenb
> >>
>
>
next prev parent reply other threads:[~2025-05-14 9:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 8:40 Lorenzo Stoakes
2025-05-14 8:42 ` Vlastimil Babka
2025-05-14 8:50 ` Pedro Falcato
2025-05-14 8:49 ` David Hildenbrand
2025-05-14 8:56 ` Lorenzo Stoakes
2025-05-14 9:10 ` David Hildenbrand
2025-05-14 9:11 ` David Hildenbrand
2025-05-14 9:18 ` Lorenzo Stoakes
2025-05-14 9:13 ` Vlastimil Babka
2025-05-14 9:21 ` Lorenzo Stoakes [this message]
2025-05-14 10:23 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b346ce3e-3fe8-47cd-bd30-81f9e513a2d7@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox