From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2255CA0EFD for ; Fri, 30 Aug 2024 17:23:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 150BF6B01A6; Fri, 30 Aug 2024 13:23:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1017E6B01A7; Fri, 30 Aug 2024 13:23:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0B156B01A8; Fri, 30 Aug 2024 13:23:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BC7366B01A6 for ; Fri, 30 Aug 2024 13:23:25 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 43F4EC01CC for ; Fri, 30 Aug 2024 17:23:25 +0000 (UTC) X-FDA: 82509583170.10.A77070B Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf28.hostedemail.com (Postfix) with ESMTP id AECB4C001B for ; Fri, 30 Aug 2024 17:23:22 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725038483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MqG8mWruplulneERL/vN6oKiLL3eBhJAny93MEBOh4c=; b=kY26UJww/L5yhGQYh4b7mEocKhalCNb/sYOsLA84tYMxrU2cKq1e0OxwCbjRsfdHgPtwa6 1uTQ0+mZs1/NfLncfSROsg57G7wVy55PFZ/2Zh79VfNqOO6qZLjMvss1ml6juUAirbNAFL G/z+HxUaSRRrsq9or16BnoopgwAYyXQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725038483; a=rsa-sha256; cv=none; b=ySo8INZSOj0ZLaNZNMVwvo8dJ8mrok/7Do1nzGLhsJLTUV48nazMfmMvztMxkXf6qStrNg P76CQEat2Nako9fRC5BYFZvf/Pv7OZUqgArre4OFurGyFiVTkPwYSM4vg+EtFKdpZhXhHI Y/3PAquNZeaGJBu02Zh/4weTEPNJQiw= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4WwQ3D1gMBz9sS8; Fri, 30 Aug 2024 19:23:20 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g-0ANya1nR0i; Fri, 30 Aug 2024 19:23:20 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4WwQ3D0Xpmz9sS7; Fri, 30 Aug 2024 19:23:20 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id F13B68B794; Fri, 30 Aug 2024 19:23:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 7ABmumGq8hAw; Fri, 30 Aug 2024 19:23:19 +0200 (CEST) Received: from [192.168.234.133] (unknown [192.168.234.133]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 125AE8B764; Fri, 30 Aug 2024 19:23:19 +0200 (CEST) Message-ID: Date: Fri, 30 Aug 2024 19:23:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC32 From: Christophe Leroy To: "Jason A. Donenfeld" Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao References: <84682299-8cbe-4b66-9c26-17786e73af55@csgroup.eu> Content-Language: fr-FR In-Reply-To: <84682299-8cbe-4b66-9c26-17786e73af55@csgroup.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AECB4C001B X-Stat-Signature: feqpkysdhtqk7wudeoqpmag1p7skoiw5 X-Rspam-User: X-HE-Tag: 1725038602-420800 X-HE-Meta: U2FsdGVkX1/dll8pOfrzCPFFxLUVV7yowXYzWyzPKYWL2b3pKlSyTuHFZ64gPmuAc/+OsYoQQxfSgmHAKevbzPf5WRlM44wKG14EKjS2fzJO6fz5X9DlR3FxFHf3IFrpxRPow5CaEwaWdnKGVKI0Z9L8xCoxxxWSVrS7F+z0G3YDMYg3vS97xOx/x3Alsc+228G9++SG1uQYw+uZRaRIBPJoP/hRT7sg04juz8ZPMs3/4AAuSvR5qbboE/IMTnCkTGbPKGVuVoNlwGYEYZx5yX15HYdgXMXOEc3m0hbpqczLU+t5BQS5QwccXwSocb9351EsT49ZgV3mLfjruDzQXew/GsrmnXDFP/szZfpdjoIccFZB8m1R6Yuy6ylpbGXpc9dyiFRtaXvf4rzoe+F1l7q+v3LLVYVMxSNBYnuq2KSuWyXf/uFoyDIOJheYMstesilAx3fYTVYLOyk9gBjgKGQ/20ovy+IEIxw8LHNQ3iqj9A1fgGY8GAWbkb3x61Pcol1uc5XnJ/GZn9Tb9Aw6lXoS5onnFD3kW5nO2Kn9EHaBoouLeRjFf8mZh7rBZZCA5WN4INp4KlvOcdO5fuwXgfsDfmmDWuZgsBicuUq1GCGC5SMrT5KOkPdQeH18pMErsFY8dB1RTNaNU6Kt1qUlMBTmoiIlGIEXTzfPmhw9QUxtaQsuxxf3SraExa/E1nfmRu5FsQbpOftIN0VbLyIQZMju6xHdNw7LiQadpP/9sZTPlr5bySUW1PRMP6+iBCMjh42Y1pe1hyXeUnVUwsTiwIyxMBwi+DhSF8ejfHup9+PeE4W6eKmhDgyEReoaCoThBfPSMxEAO0J99j8Oi8ZDrZzGzCmpP0WzL3mOyNCKz9YMFObbJZo0R49LrUQvOhYq5dWwAcmed5lRDFfeUn2TSxF0xLd+egPgxObfEx7ftMMK+UxSzWh8zxWS3WrqXMOK6YoW7MShgdTt2NRIJ+m R+WeCUYq Nht3DWyeWsJ+gLb3DxTLy9INZggA8tmEER+vNU1zg1yxEkHrxh5RuyTl7VENEg8C4zF6su7Wykhuw3NmA2ITr6a6DIqkTuhUAEAk2HTNoIKstynIfnW3Y5Zs0/bVaDgh+WruSRJ5gzMdEP7I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 30/08/2024 à 18:42, Christophe Leroy a écrit : > > > Le 30/08/2024 à 18:14, Jason A. Donenfeld a écrit : >> On Fri, Aug 30, 2024 at 05:57:08PM +0200, Christophe Leroy wrote: >>> + *    r5: 8-byte counter input/output (saved on stack) >>> + * >>> + *    r14-r15: counter >>> + */ >>> +SYM_FUNC_START(__arch_chacha20_blocks_nostack) >>> +    stwu    r1, -96(r1) >>> +    stw    r5, 20(r1) >>> +    stmw    r14, 24(r1) >>> +    li    r31, 4 >>> +    LWZX_LE    r14, 0, r5 >>> +    LWZX_LE    r15, r31, r5 >> >> Why swap endian on the counter? > > Unlike the keys, the counter is passed to the function as an u8*, not as > a u64*, so I thought it was raw data in little endian order, same as > when using Sodium. Is it wrong ? Hum ..... I looked again and it seems it is already a u32 *. Looks like I mis-read the 8-byte comment. Or I did it right in the begining then I swapped it at the same time as I swapped the keys after my first test when the selftest was using Sodium. I can't remember. I'll fix it. Christophe