From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7FFFC433EF for ; Mon, 20 Jun 2022 23:08:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 765D28E0001; Mon, 20 Jun 2022 19:08:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F72F6B007B; Mon, 20 Jun 2022 19:08:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AB668E0001; Mon, 20 Jun 2022 19:08:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4B6BF6B0074 for ; Mon, 20 Jun 2022 19:08:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2282E20C06 for ; Mon, 20 Jun 2022 23:08:06 +0000 (UTC) X-FDA: 79600154172.18.222EC61 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2047.outbound.protection.outlook.com [40.107.100.47]) by imf28.hostedemail.com (Postfix) with ESMTP id 9E817C0019 for ; Mon, 20 Jun 2022 23:08:05 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ay7lcFWWTXpcuaEHJKRT5hgqY5jzNW8QdbQsCl3yVEuxUzdOILSAGuncIhSpXpRA99gttVBuR4dHH5VbdS0c6qdMdNIHIFMn92e1Wou5BTI2+jnzw0nR0Sp6aaLlvHVAghrXU9DZsbrwLdkqc8UxmrX5wChhyfmMUzf95AAc9kpJUCdNkXP5c+BnCdzuXsjo1Hyb7XR0g1PEiSdXoNWe04ZHJXlR/LUBva7+iDVe8+pI+diMsc1TB/AF0UWlp4EUBFcxFff+ZN5qP7BzvzhGaWAX4helBVMrX/JpdzeO61jyj9DMmCvKtM+CqhrcppQsxNSCWUyVtOBpZnm96rWE0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TRMZ3HOdoZp8bsZg9WKNaitB9a5oUh93d6JbWV+hoo0=; b=EASEPg2dUTK0nMmMpCf48p5tpNrHY8elEcMUT3lC8MzHsupz7t6iR1Urovzs/QE1SfmuCGOyU3m2Q4TmjxRhFB9OOX6+O0l2Ms7TyPGLZASN8kh+pK0FDrUBFLEqrAxuCMiOYdoP7MLrctSTUW8zeyLJ2bI3T/wuRgmlPwO6vzUdXjETGeoxOZ9vxzfIyFW+XPS/mqGZDeeQSc8F+saNI5C0q19181Mq+FwcsZuRELrMR2TozN5EiaXddcI1ZmtkcXDBirTMgj4qmLTjFy6XOM460capE9JgTXQKNbWK1Skr1fQYHFK6t3iLQnyVb79tzyo2jiMmtHizwcQI/6rb8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TRMZ3HOdoZp8bsZg9WKNaitB9a5oUh93d6JbWV+hoo0=; b=hv+Yt4NDEjkr4JkUX72OH0JV3B9taAgtFL6LGN3Sg0Ts3rAm5CqeqWXzNVJmZwirOFhJkeM/IpsTkGSgpSZWlzycF20HOTxdINP8YL6WYU581VQAKvBRpkUhbP5XMlJkWKg6tBuqVK2wQ62411XrrhToRcm1CeKMnJmq0IWzAQU= Received: from DM5PR12CA0065.namprd12.prod.outlook.com (2603:10b6:3:103::27) by PH7PR12MB5594.namprd12.prod.outlook.com (2603:10b6:510:134::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Mon, 20 Jun 2022 23:08:01 +0000 Received: from DM6NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:3:103:cafe::20) by DM5PR12CA0065.outlook.office365.com (2603:10b6:3:103::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Mon, 20 Jun 2022 23:08:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT068.mail.protection.outlook.com (10.13.173.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Mon, 20 Jun 2022 23:08:01 +0000 Received: from ashkalraubuntuserver.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 20 Jun 2022 18:07:59 -0500 From: Ashish Kalra To: , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH Part2 v6 25/49] KVM: SVM: Disallow registering memory range from HugeTLB for SNP guest Date: Mon, 20 Jun 2022 23:07:50 +0000 Message-ID: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7da90927-e7e2-4d32-0d8b-08da5311b961 X-MS-TrafficTypeDiagnostic: PH7PR12MB5594:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dgHtmBIJk7ALoh7ui3/FAxCpKuG/7TOWCDGxU5acAbyAmB9bcB3oDJ5rTsZ6VUANgUNBNXgwTATueFSK66Wf7O2OtEycKSjhWBsnFXPFA6iPZSHbKirRSMyprqCBtV12FSx2n+mzFuEoUbzGTtGgJFRF5ho1ezkXHWhchrRJW0JJMqykoeCKUo5eHL0LcF4vErkwccW0L/3JXblo8asbr3a9dqohfGf12WWN9J/2jJ7Kl5NkouY+9VgzAQGZPC72Xwl2XtF+NtZII92r7eHc/K0R3F+nillHFUq1xVQ6qvJsGt3TYEkYPUl05oO3Mx6d+vEg27AVZO9ItZTSS0oEw4Q3tyAgmFub4R9mQ+62DNzsi/klwUO+cqc07NEJhb8Wmc0tZSqQVram58LNXfgkAkFWaWA/F0eOlhwt4qXLeNDS/b1mCHwgF2bHevj7mbvgEs4UKnmYG0bBQvjLqxYnAFXqNauCmOnvVNlnJaW3WmhsTHteyYp8mzDolg3cqOetwi84YuZjOh+f8VBc2Lc62SUkSQNsSl4o9/pUo0M6g1a+t/EJFg70zQZy6LJsd3RA3Kddp1vNqzBl96HiOnhgOgeLZItHiqT+Bww4TLOybuoFPMr+F1kZ2xVLUkfjukF8i7d0AoHEvDk0fOZlu9eVd7UiWlEwEBQGQp19mXRpa6Ee+QeuNNI3SXaslXiXmvoyWw8jIa2gq2Y8b9bd8VXNTtt1aHN5rWtEMzz4kBmxSQMvUMEn4yaEz5EDVlMAOmDsCTUEZW7I/g38a1DG3VrAIw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(376002)(136003)(40470700004)(36840700001)(46966006)(2616005)(40460700003)(70206006)(186003)(478600001)(336012)(8676002)(82310400005)(41300700001)(6666004)(83380400001)(316002)(4326008)(8936002)(54906003)(70586007)(40480700001)(7416002)(26005)(36756003)(47076005)(110136005)(82740400003)(16526019)(2906002)(5660300002)(7406005)(426003)(36860700001)(86362001)(81166007)(7696005)(356005)(2101003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 23:08:01.4947 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7da90927-e7e2-4d32-0d8b-08da5311b961 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5594 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1655766485; a=rsa-sha256; cv=pass; b=Tw+EcW1H3wJYD3Lm/jSkHc4kg405/1X1UvHSLJJIXKq+W9xGYJxI/s/KXp4InLQT+3Xhwn WEFNrfjc+J+QnPzbdTFSo7b6ZAxYMlm23pxJ0AhoawrvnQI4Hd+8O5voObU+WXPCgjdOHi 6yC5hgJepKP+FzzrCQaN+TYL/6LzVlE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655766485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TRMZ3HOdoZp8bsZg9WKNaitB9a5oUh93d6JbWV+hoo0=; b=w5G6ArI0LINptufFrYjLXvjXxFs4w234+vJ6+P6FOjsGJGYj1l2Tiw9zfv2yES7XSGMwho PqLX8psW7PKg7SEdllCQ6MMtDG4486qjHrmohooD8ccoEMZhFos/Uq/asB9OQ4B7JrZQvj U1B4cmHTaROaVOEqjdlBFt4TbQhZ8qs= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=hv+Yt4ND; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf28.hostedemail.com: domain of Ashish.Kalra@amd.com designates 40.107.100.47 as permitted sender) smtp.mailfrom=Ashish.Kalra@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=hv+Yt4ND; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf28.hostedemail.com: domain of Ashish.Kalra@amd.com designates 40.107.100.47 as permitted sender) smtp.mailfrom=Ashish.Kalra@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9E817C0019 X-Stat-Signature: jjjzmwixxj5su4h5wyaghsc7gt49k7fd X-HE-Tag: 1655766485-219139 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Brijesh Singh While creating the VM, userspace call the KVM_MEMORY_ENCRYPT_REG_REGION ioctl to register the memory regions for the guest. This registered memory region is typically used as a guest RAM. Later, the guest may issue the page state change (PSC) request that will require splitting the large page into smaller page. If the memory is allocated from the HugeTLB then hypervisor will not be able to split it. Do not allow registering the memory range backed by the HugeTLB until the hypervisor support is added to handle the case. Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm/sev.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index 9e6fc7a94ed7..41b83aa6b5f4 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include @@ -2007,6 +2008,35 @@ int sev_mem_enc_ioctl(struct kvm *kvm, void __user *argp) return r; } +static bool is_range_hugetlb(struct kvm *kvm, struct kvm_enc_region *range) +{ + struct vm_area_struct *vma; + u64 start, end; + bool ret = true; + + start = range->addr; + end = start + range->size; + + mmap_read_lock(kvm->mm); + + do { + vma = find_vma_intersection(kvm->mm, start, end); + if (!vma) + goto unlock; + + if (is_vm_hugetlb_page(vma)) + goto unlock; + + start = vma->vm_end; + } while (end > vma->vm_end); + + ret = false; + +unlock: + mmap_read_unlock(kvm->mm); + return ret; +} + int sev_mem_enc_register_region(struct kvm *kvm, struct kvm_enc_region *range) { @@ -2024,6 +2054,13 @@ int sev_mem_enc_register_region(struct kvm *kvm, if (range->addr > ULONG_MAX || range->size > ULONG_MAX) return -EINVAL; + /* + * SEV-SNP does not support the backing pages from the HugeTLB. Verify + * that the registered memory range is not from the HugeTLB. + */ + if (sev_snp_guest(kvm) && is_range_hugetlb(kvm, range)) + return -EINVAL; + region = kzalloc(sizeof(*region), GFP_KERNEL_ACCOUNT); if (!region) return -ENOMEM; -- 2.25.1