From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5226E68974 for ; Thu, 31 Oct 2024 10:56:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 535396B0092; Thu, 31 Oct 2024 06:56:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E57B6B0093; Thu, 31 Oct 2024 06:56:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D5526B0095; Thu, 31 Oct 2024 06:56:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 20DC36B0092 for ; Thu, 31 Oct 2024 06:56:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 987A91A1416 for ; Thu, 31 Oct 2024 10:56:09 +0000 (UTC) X-FDA: 82733592228.15.C3FD500 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf19.hostedemail.com (Postfix) with ESMTP id E9F561A0005 for ; Thu, 31 Oct 2024 10:55:32 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=AGmG8ygU; spf=pass (imf19.hostedemail.com: domain of mcanal@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=mcanal@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730372086; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1e1Pem+qp2w/Akjj6dWKUEh4AeuCe5dpoYvS12Rnvgk=; b=E7p/WOxlKcm5OLOyPUNr7ah6hl+xCPfX58RhDmEhve6J5ER6kZWGMHvY3iwT6x2Ix3qq8Q MeTATLM1NehqdowSH86ruR23MkqpNa80beRNand+W41yS39FZOoxHw3amPWHtB6z+zkj8F zY0yLv4nhcJ2FCEc6WaioaHU5EZdooQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730372086; a=rsa-sha256; cv=none; b=GSyaRKHE0p+zaYdTybNXhxQpibz2JY0U35vMRrPdFdLLXd1impbU8WiVbhPBCqx2MP6g3j MXV9gb4R3zLhUVZv1xJ85mG7RZeJ+eDjcnLuIPSh2MHeKpDBNzE2SLK1pf99ZmTEon/5Nz GWfBnv4GkuOqEpjfVrfxO/9EhbjDy7Q= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=AGmG8ygU; spf=pass (imf19.hostedemail.com: domain of mcanal@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=mcanal@igalia.com; dmarc=pass (policy=none) header.from=igalia.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1e1Pem+qp2w/Akjj6dWKUEh4AeuCe5dpoYvS12Rnvgk=; b=AGmG8ygUmt9zRxbe2HYj47fYd2 EiRCxeRBJhijKoPrVolQe3tPVfysPtMjYtfTkYC0HlELl1ad+sr4YTi26PSK3Pq6lXHeCk4BHRDyF Z6KZ5gMf6p+XnvldU6r/AUir8KBGsjcuWD8L8fk1fW+Y7Bpg7j6ENGCB+QC0B8LbUC6gY1Gg+QhXk ldArIjA3eFO430UEK26691k2vzg+aqSImfJBCTfeNHNiaGw2sEcSyz2PD8lmYdGjbzRjYtmFwKYXu mpTp9wyEzy+y5aKhz/x/O19EIGbFgEiLCMAvsiDxRE96AMCONwG34ZmhgPp8JtkVSwn0MlrqiU6F6 RnFAcbFQ==; Received: from [187.36.213.55] (helo=[192.168.1.103]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1t6SqD-00HZkr-Lv; Thu, 31 Oct 2024 11:55:50 +0100 Message-ID: Date: Thu, 31 Oct 2024 07:55:42 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] mm: huge_memory: Use strscpy() instead of strcpy() To: Barry Song Cc: Jonathan Corbet , Andrew Morton , Hugh Dickins , David Hildenbrand , Ryan Roberts , Baolin Wang , Lance Yang , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com References: <20241030130308.1066299-1-mcanal@igalia.com> <20241030130308.1066299-5-mcanal@igalia.com> Content-Language: en-US From: =?UTF-8?Q?Ma=C3=ADra_Canal?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Stat-Signature: yudm9mo1sqfrdkenufwzd3gbihedi89t X-Rspamd-Queue-Id: E9F561A0005 X-Rspam-User: X-HE-Tag: 1730372132-525965 X-HE-Meta: U2FsdGVkX19ZtJGmhhovcalV85t2D0Z21a5CZjU90VylAJKI+6uckXzEzIKCJVJ2yrPvmz6ArupP6X4Hzil34DpTzEs108cDNi6ArkzVNH3bhbpGwNoDUbpJ+TrEGmp2Ozz/7B9d9667dJImegDwJNCpBkXG7E7XL2vlvmLdrm4uM+9ZdpbxfkXM+1og7+Iw6asuS4km6sukgUlEZUWXSuVcnr7ArwSjMR62JeSaLs8y0YltGuCBirJhZntNVDmhnwVZJad9tb1KX3ClUd8UEapz7J6I2G/F5f6y0RAOqexEqAe2U8x9nuaTms4UFxJW4KKhQXxH9I0r8K8e9p0RyMERh+gPIYS2VgCWq8qkh9UBEs8K5vi9QwCTy2owq0/jHOaNc5RrXDUZm70tdX97AcP85bmg7FIRegXausbtdrNiMpF7hQJaM0kM9te4ncfCXaZdJ5OgK+tcf4ATXAsEacigLmm/344io3Rp0kCh/HPDwDBANe6DugzSw877OLzCp5z8u+w8DUvXn1dCF9fKh/UgyumsjhMY9sB7rbNWmdKTFj1iQxc32PiX+fImknjLAIWR0jLBW/mJtOCtB8u5BWqFrcTLACGbV8hECbdxlgDC9QHGdlbxYz/CfUpb25W6FGqRTNYLS2sZ3u0iX86tkJHcfgUQ7SQP/f++AxYUsvky1zd9bOdBO4jxImANsxs2yfRVRf/zqSi/4Y16QKzZ9pJN2FBLBbc+ts8IGco0t1m9aU5FI/Po+xWD8s8K/7MthA45PAeRUQx9ZicO18ejyEiMt08UJjBoKuadMo/mybDL9nOr6GlVoFbNsaksMFyIsDaPnWP6N5fPTMIu7JTXTa0JWtOHcKsfrAxuWImogBTnDHu5WsWMROjH1dwxj+iSBKOTmHKENkItbQ11CYA0ie6s1MBnZlbv4DXyC7qYl0Nln286E7pSxQRq/VdDFGfNRyITFIpthXjByTMSMW1 tsxXY+Cv cdXwzl6Q7rgz4ZfqBOF8iAghu+Kae+VFg1D9nqaPooMH/YSzMN3OUBQs1ORRd4pyj/YC8wEnPxnts1T6igF4mShD4+dcYIW5cJzjESozrDu8ZFWfxxuLZb5uOEeVcjs2PD3OCzKIgHpjiBgemSwqiWLrD0yrW04u2m62aoKWNTubMWrIHWZjn9DY+PEHATvC5dpnH+kWCDwS6QnYEle1laiC2Q2Vn4TmjBylaibKeU+UJ6JKBwq1MLZXWk0Sura4YTx6UDV9YkcHdU4aEBgUWPvFy/g3057/9rRZ7NGKKYO8om614Fxtqsqzts5ShycUiAiOfUCyS51VmhkFRYhaWGzivBMVVKq0ESAvt03qbgJgCzQZ4dgWGG8Re+pbGX7DV/lr4gxTZOh3dvptxr9OlCbAKTFA2kVepacqdCxjA4OKO3G79tSlPjNfKPpE5ePfDPaY/Gie+IXYNn64m0A5D4pp4PT3N4ucgIeEpL5dZpwRmJfsoUgs9FCEZ9wVJvFnl6QgCTCQcdd3D7cQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Barry, On 30/10/24 20:07, Barry Song wrote: > On Thu, Oct 31, 2024 at 2:03 AM Maíra Canal wrote: >> >> Replace strcpy() with strscpy() in mm/huge_memory.c >> >> strcpy() has been deprecated because it is generally unsafe, so help to >> eliminate it from the kernel source. >> >> Link: https://github.com/KSPP/linux/issues/88 >> Signed-off-by: Maíra Canal >> --- >> mm/huge_memory.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index f92068864469..8f41a694433c 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -989,7 +989,7 @@ static int __init setup_thp_anon(char *str) >> >> if (!str || strlen(str) + 1 > PAGE_SIZE) >> goto err; >> - strcpy(str_dup, str); >> + strscpy(str_dup, str); > > What is the difference between strcpy and strscpy without a size parameter? > > we have already a check and goto err. strcpy() is entirely safe. > if (!str || strlen(str) + 1 > PAGE_SIZE) > goto err; > > My understanding is that we don't need this patch. strcpy() is a deprecated interface [1]. From the GitHub issue I linked in the commit description, Kees states: "A lot of kernel code is still using strcpy(). While the CONFIG_FORTIFY_SOURCE wrapper macros tend to make its use mostly safe, it would be nice to eliminate the function from the kernel entirely." [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy Best Regards, - Maíra > >> >> always = huge_anon_orders_always; >> madvise = huge_anon_orders_madvise; >> @@ -4175,7 +4175,7 @@ static ssize_t split_huge_pages_write(struct file *file, const char __user *buf, >> >> tok = strsep(&buf, ","); >> if (tok) { >> - strcpy(file_path, tok); >> + strscpy(file_path, tok); >> } else { >> ret = -EINVAL; >> goto out; >> -- >> 2.46.2 >> > > Thanks > barry