From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1ACC3DA45 for ; Wed, 10 Jul 2024 10:35:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 854CA6B008C; Wed, 10 Jul 2024 06:35:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DD696B0095; Wed, 10 Jul 2024 06:35:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 609096B0096; Wed, 10 Jul 2024 06:35:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4227F6B008C for ; Wed, 10 Jul 2024 06:35:06 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EC4D6141C16 for ; Wed, 10 Jul 2024 10:35:05 +0000 (UTC) X-FDA: 82323485370.20.93F4499 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 9734F1C0018 for ; Wed, 10 Jul 2024 10:35:02 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sVBgOUMm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vN6rBkH7; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sVBgOUMm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vN6rBkH7; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720607688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9NkxVGJHly6s/ra3N7fnlXAg+iaurwhd/g65FR0Huqc=; b=1/H4HmR9Egykx+t8UJPI74X5x363EIjMiUiYjDjZ3Q03oQ0lFR7P7WgT2VsW+TXXbvIwF2 6sl66c2AIrQ2kZCuIrlZY2c7V2Rgb3GTqGfyX/xNkatkZ0X1Blku+9lKmuDH+Ck4MHZ6v3 COKOUNThxsEd9t00SXN/5+0tvK7GsKM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sVBgOUMm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vN6rBkH7; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sVBgOUMm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vN6rBkH7; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720607688; a=rsa-sha256; cv=none; b=kxAT76PNwYck1ZIXooADiL6JgTQGZheLfVWVjdvpnVvV7EmiX4BWtaJO3/pcirTRIOYcIk ZzR+q7LsyqHxe8dAeV3So5dsEJZ1sCEQ9wXUDrfPn7OpWcTVSWQFpMj1DZiAbS+xE9uOHf WW/HxU3oXyzED7ja5kbG55FHDDdKVR0= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B9C5921BD0; Wed, 10 Jul 2024 10:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720607700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9NkxVGJHly6s/ra3N7fnlXAg+iaurwhd/g65FR0Huqc=; b=sVBgOUMm5Rx09/3fW4TwiQSrFsKVOUHkZjLfSGC9qIe3aGJik7lSg5oW/gT3nuh42YY3Me DxkvK4b/7FXBY26kvYtdhw1IM6+Rhl2lZcqq1QLt1o09spSvE/ylIJPlrq88ozNU48o8iv MY42vfEoh6EzS4Br4ZUQc9iLvPokKvc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720607700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9NkxVGJHly6s/ra3N7fnlXAg+iaurwhd/g65FR0Huqc=; b=vN6rBkH7Qmmm/EhNhqhSioBdilAIaKYv0Lc4/lj7+HSVCFn/D4pB68d2U1wwmWG6kly8px 7NuOWN8WEFEduiCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720607700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9NkxVGJHly6s/ra3N7fnlXAg+iaurwhd/g65FR0Huqc=; b=sVBgOUMm5Rx09/3fW4TwiQSrFsKVOUHkZjLfSGC9qIe3aGJik7lSg5oW/gT3nuh42YY3Me DxkvK4b/7FXBY26kvYtdhw1IM6+Rhl2lZcqq1QLt1o09spSvE/ylIJPlrq88ozNU48o8iv MY42vfEoh6EzS4Br4ZUQc9iLvPokKvc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720607700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9NkxVGJHly6s/ra3N7fnlXAg+iaurwhd/g65FR0Huqc=; b=vN6rBkH7Qmmm/EhNhqhSioBdilAIaKYv0Lc4/lj7+HSVCFn/D4pB68d2U1wwmWG6kly8px 7NuOWN8WEFEduiCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A9A471369A; Wed, 10 Jul 2024 10:35:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SlgZKdRjjmaJbgAAD6G6ig (envelope-from ); Wed, 10 Jul 2024 10:35:00 +0000 Message-ID: Date: Wed, 10 Jul 2024 12:35:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] slub: Use alloc_pages_node() in alloc_slab_page() Content-Language: en-US To: "Christoph Lameter (Ampere)" , "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, Johannes Weiner , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20231228085748.1083901-1-willy@infradead.org> <20231228085748.1083901-3-willy@infradead.org> <624cc2ee-9335-31e5-4177-97fe676b6e76@gentwo.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <624cc2ee-9335-31e5-4177-97fe676b6e76@gentwo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9734F1C0018 X-Stat-Signature: et6kuwzn8jfqost3tp1dr89uukixcsu7 X-HE-Tag: 1720607702-367291 X-HE-Meta: U2FsdGVkX1/Fkabv2n6mJwVMal6rEbFiC57szNA45OZ6KOkomSPPqL4tkcEk7+Fxu1hqucf7nisK372qjYdAP3eW18Fl7oLMkAn9oQkgZXLEltAxLTptygjdXBONphXc6tKc46v9d4rlc9U6riy8Jqhe+DvkkYVZFVKrljUsLHP/R/BcpSCJiaiQbva8B4J2Zd5IyEO0E8Z/rUyE+6ht0guX2HIRFIst5AkBRQv6S0AjX02ivseV9yl+HOCLAavIqaED1oTJoL4td/VP/s4spjLaCVMvAktWyZYMNisOV4/HVslW12OjYy9fwEl45gbHeI/6MuDHrpGmFZq0d1MN75ixDnYCJ0BDqr68dNEZh90u/ysGeTCc/dEGg1kAqeCY1CNjMGlw0JAmZX3aUsTscormaRGkFJVwlpSK4e1T4FdTmbXt+ahWVRsU4zFGnuDUjEv75svxnfsKnD/lkXq6XH1ED6DcTBoilH/jYfyTy/g9GEHis2Tlsmc8VxDJV1LUnsD1rnKW18s9SAZQJhzkAZN9eN4KmrARZPfzy60c04tW9+SDJKq5+KhevPLQ6IHAsBVNIsLgzFsX8TBKilcLJZZk4l71sRnym5TTOGvur5lUSYXpt8iq3mkSn2p4lXEdsyuWH6sXMhyiqT4ZcZymzcXYifkQ33AP53q3OjMSqGB/bS097UO+mKXv3VAb4JojAuV29IDxZ3QDh5rsWOOg2iEg3miKKVXhKPOtamVVyO4s7OPWR/NyFfRQ/0OxsgHrFmfEf2E8VXPt3xN7ZnQpbdJqnJukxnHrbE455hqe/U5HS4N9orlzLUVbfBXXd0tA/Gsh4gOdrEouftcsFTMAlr6uAgqeWukVuK48SlQTuF3xZTBHV0YLNy6dbQv5LAV4LqWeLFDzhGGloWiFZoSU0qcBcjGUl0uTX33+WW8aY6omBVF1A66GsbS4q2fiWeFf4y7bhtUPad8IvTkMgtM Ewe4rmR0 sDtHRIWDDHC489uPee012liiB9yiDxHRzo2lkvqpVIY5w+vhUDDydj4u9xi4EeKcoRrosn/fS8zPQf8ZOzQFvsJOmJO0GNwHLIAPseVrExV1Z+Da9EdJFAYA4cUxN5BS2EuwljJ+OT8DzPyh2qjaYBD4x/YnVpN8N9dZcA1ejBz3rZDYa7V6deBenK6cmt1/S2n7otxCb6PzKJbJs9YJ9H2JgB3H2nq7pbUK4BnNY/2pDhu2wySBrhxyLOsUcRXtm3ItDnpaEEekUtGV/M7+5tDriIEWlQqMg+2HoX84AsbdLtwLJvTzmmwsgDHBLM98dLUbzzjPpjIOYfoPr04GvPSt8gsl02zJswA83CjW7xkDqKO6e2pN+UNQNNdoEWCMIW2qi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/9/24 7:12 PM, Christoph Lameter (Ampere) wrote: > On Thu, 28 Dec 2023, Matthew Wilcox (Oracle) wrote: > >> For no apparent reason, we were open-coding alloc_pages_node() in >> this function. > > The reason is that alloc_pages() follow memory policies, cgroup restrictions > etc etc and alloc_pages_node does not. > > With this patch cgroup restrictions memory policies etc etc no longer work > in the slab allocator. The only difference is memory policy from get_task_policy(), and the rest is the same, right? > Please revert this patch. But this only affects new slab page allocation, while getting objects from existing slabs isn't subject to memory policies, so now it's at least consistent? Do you have some use case where it matters? >> diff --git a/mm/slub.c b/mm/slub.c >> index 35aa706dc318..342545775df6 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -2187,11 +2187,7 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, >> struct slab *slab; >> unsigned int order = oo_order(oo); >> >> - if (node == NUMA_NO_NODE) >> - folio = (struct folio *)alloc_pages(flags, order); >> - else >> - folio = (struct folio *)__alloc_pages_node(node, flags, order); >> - >> + folio = (struct folio *)alloc_pages_node(node, flags, order); >> if (!folio) >> return NULL; >> >> -- >> 2.43.0 >> >>