From: David Hildenbrand <david@redhat.com>
To: Lance Yang <lance.yang@linux.dev>
Cc: Liam.Howlett@oracle.com, baohua@kernel.org,
baolin.wang@linux.alibaba.com, dev.jain@arm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
lorenzo.stoakes@oracle.com, npache@redhat.com,
ryan.roberts@arm.com, usamaarif642@gmail.com, ziy@nvidia.com,
akpm@linux-foundation.org
Subject: Re: [PATCH 1/1] mm: avoid processing mlocked THPs in deferred split shrinker
Date: Mon, 8 Sep 2025 10:33:19 +0200 [thread overview]
Message-ID: <b30823ea-b987-4284-866b-9e179a2d8eb7@redhat.com> (raw)
In-Reply-To: <bc1182e7-3f70-4645-b8c4-a97898e57041@linux.dev>
>>
>> If I run my reproducer from [1] and mlock() the pages just after
>> allocating them, then I essentially get
>>
>> AnonHugePages: 1048576 kB
>>
>> converted to
>>
>> Anonymous: 1048580 kB
>>
>> Which makes sense (no memory optimized out) as discussed above.
>
> Yes, my reproducer also shows exactly that. It's clear a lot of work is
> done but no memory is actually optimized out ;)
I'm not really concerned about the scanning overhead. The real harm is
splitting a THP without any benefit.
--
Cheers
David / dhildenb
prev parent reply other threads:[~2025-09-08 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 4:07 Lance Yang
2025-09-08 7:38 ` David Hildenbrand
2025-09-08 8:13 ` Lance Yang
2025-09-08 8:33 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b30823ea-b987-4284-866b-9e179a2d8eb7@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=usamaarif642@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox