From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by kanga.kvack.org (Postfix) with ESMTP id C41976B751E for ; Wed, 5 Dec 2018 10:57:46 -0500 (EST) Received: by mail-ed1-f69.google.com with SMTP id l45so10098918edb.1 for ; Wed, 05 Dec 2018 07:57:46 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 05 Dec 2018 16:57:44 +0100 From: osalvador@suse.de Subject: Re: [PATCH v1] drivers/base/memory.c: Use DEVICE_ATTR_RO and friends In-Reply-To: <20181203111611.10633-1-david@redhat.com> References: <20181203111611.10633-1-david@redhat.com> Message-ID: Sender: owner-linux-mm@kvack.org List-ID: To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Ingo Molnar , Pavel Tatashin , Oscar Salvador , Michal Hocko , Wei Yang , owner-linux-mm@kvack.org On 2018-12-03 12:16, David Hildenbrand wrote: > Let's use the easier to read (and not mess up) variants: > - Use DEVICE_ATTR_RO > - Use DEVICE_ATTR_WO > - Use DEVICE_ATTR_RW > instead of the more generic DEVICE_ATTR() we're using right now. > > We have to rename most callback functions. By fixing the intendations > we > can even save some LOCs. > > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Andrew Morton > Cc: Ingo Molnar > Cc: Pavel Tatashin > Cc: Oscar Salvador > Cc: Michal Hocko > Cc: Wei Yang > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador Thanks