From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5351DC48286 for ; Fri, 2 Feb 2024 03:05:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAE5C6B0078; Thu, 1 Feb 2024 22:05:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5EA36B007B; Thu, 1 Feb 2024 22:05:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4E2D6B007D; Thu, 1 Feb 2024 22:05:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9A9696B0078 for ; Thu, 1 Feb 2024 22:05:34 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 518701A0F2D for ; Fri, 2 Feb 2024 03:05:33 +0000 (UTC) X-FDA: 81745373346.05.ADEE99B Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf06.hostedemail.com (Postfix) with ESMTP id 65879180010; Fri, 2 Feb 2024 03:05:29 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706843131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vs95XZqneYJThQhoKzfxghh2WrFnDGv/GlyRoD2l3Ac=; b=5gwET5foOPttbILZYCHiRuX4UoJ3qsOtmegCbZtQEzA9xTzuiM5cCb3vIR2N8nb3o3lIfh TQPbsJ1TxIOAG3njeYeDpoaC92aJ7e5OtoI0ZTG559piDjSFEjVxFHDQ6k4S97pfFwomfX mLFS1iezy/4Ji0AVyxyx9S6uiqbOix8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706843131; a=rsa-sha256; cv=none; b=R9aVqdeznvXAwvHyYNWA93dMntYbMANVyMfaORQnUdAu+RcIlrY6iNBV5Kuk8uL7f2urSz KzrE+5LUApt6obapuJqC6ipv8ZwnMuHfZ4zeiFsFkmeojbPHMnlARce3CsjmphSuyQHNdO gvEv+ewiuZOql0aOxny4ZxDbPUb5PxQ= Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4TR0vd2M8Wz29l70; Fri, 2 Feb 2024 11:03:09 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 411F51400CC; Fri, 2 Feb 2024 11:05:01 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 11:05:00 +0800 Message-ID: Date: Fri, 2 Feb 2024 11:04:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH rfc 6/9] mm: migrate: support poisoned recover from migrate folio Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , Tony Luck , Naoya Horiguchi , Miaohe Lin , David Hildenbrand , Muchun Song , Benjamin LaHaise , , , References: <20240129070934.3717659-1-wangkefeng.wang@huawei.com> <20240129070934.3717659-7-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 65879180010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7rx3atyhsufrt333mhcwu7pw18q6hi6x X-HE-Tag: 1706843129-841961 X-HE-Meta: U2FsdGVkX19MVbZvMNHJjuCmP51AH1lztsfHZIJ6mo4JBJXgkVA80E2hhfFb76omxs4d7jCtn4gYF3nrm1uUlOeHNDE1znYscK8MF533JMxab5SJpzFkLwayhJ57LNpzGXwzVagAPi6AQlcn36E424QQEyS/SqpZ0I43AUgVt/06r8vTxgpTdxPumEHo8ByiN6rwfywg5fR3C9sGCc2SlVv2ksB4XAmhCNj6QoM/xMfYOIVzk4u1VNTvEVDJ3hOFg5PJaDFGCjW1ajJg+etilnWdSblwDGkIr6/RaACPZ5qQ8d/0HiNXGAgqHzd5zNyaH3CuQyRbr6Don8I8ZL8FhvyHS6dzeUSkC3ISsQ+UpQLSfwybp4+lde4I9+S2PG7b/eTW/qBOeqz7XG1poNgFT8uew4aSwALMjo58MnlblwoIHnuX5EFj97SFHwowBnK2cs+LGi0PlkfhekcPX+xzxX6PlvJfpP/zZ2ACHC/6IMnLEKh0dkWmFhGT/UccZt8AOmH4xUXNuZAGzfdr7brVg8IK8B5nhKcRYTiQv3uMKOrB8jQ+F1nuC/DaDjiifnt4pk8q4HYOuT9zf+2hO+2Xmm7+MpR2IirOz94Z1sG+GsFrI+jUsbnA1XIAGA/930b6zfw4Xg7yJHKgriSimQRKg0Y6ylRmpbR+Z8GyVrkvYMYVcHKIPi1CN3wTo3dwustClOB1eKkq9eKrTjOTUQfZxpqxAuHB5QvLpRd+wPHr/iwhAb4i2McsKkhkPkNUfukZhj/XLX7aXf9HCrnm0IoiALIm5CQUUdow9VIgwG86j3w54lU90tAmK+4sJXIubH8bnLrBeJHeKAvMdV1/7+0U7XSWrOm2/VbLPpy3wEytSWKbl479d2IWuHdnZOKyAWHdrXb7JX9oNwkR8A8DQd1UxWjUe+2u2Dac95YCjumQB7VojZW7OoJj7WD1fOZ/qoEJng4iHUM5Xmswoz8y3+U P5mYcMID 4Fm955g/7eBRfVLQH3QudOh75LXurQzDQdp7BmsDWXUk+s5ePYZoDvZkKDOG05UWog/yQ4GmvYcepsB2RP7uX9kL1heoCCw8+xDT1pS6ubN9NHXJj72UJ71OiGoi50kXr/5Xs9njMlPvPrrRouPZYwf6tHY63HVouFn6GYEK+THdAUKkmu/gBY6I1kfRosEmkhGbU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000067, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/2 4:34, Matthew Wilcox wrote: > On Mon, Jan 29, 2024 at 03:09:31PM +0800, Kefeng Wang wrote: >> In order to support poisoned folio copy recover from migrate folio, >> let's use folio_mc_copy() and move it in the begin of the function >> of __migrate_folio(), which could simply error handling since there >> is no turning back if folio_migrate_mapping() return success, the >> downside is the folio copied even though folio_migrate_mapping() >> return fail, a small optimization is to check whether folio does >> not have extra refs before we do more work ahead in __migrate_folio(), >> which could help us avoid unnecessary folio copy. > > OK, I see why you've done it this way. > > Would it make more sense if we pulled the folio refcount freezing > out of folio_migrate_mapping() into its callers? That way > folio_migrate_mapping() could never fail. Will try this way, thank.