From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C6BC4332F for ; Tue, 12 Dec 2023 23:40:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10D718D000A; Tue, 12 Dec 2023 18:40:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BEB38D0009; Tue, 12 Dec 2023 18:40:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECAC28D000A; Tue, 12 Dec 2023 18:40:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF26D8D0009 for ; Tue, 12 Dec 2023 18:40:23 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AE04D140B17 for ; Tue, 12 Dec 2023 23:40:23 +0000 (UTC) X-FDA: 81559787526.25.D20F246 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by imf23.hostedemail.com (Postfix) with ESMTP id 0AB9A140013 for ; Tue, 12 Dec 2023 23:40:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YhAzsy8D; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf23.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702424421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+XUhg/gz838xI4R2n1f8w70CxgHijv28GkiMO9jNoo4=; b=a28++Fh9oJn5AIVKzsflOpqf7NLF9Jn6oOunJdWPMM8r7VGBFdjVgDH34nhMCO7I4fUWkU djhp/qhhR4d6RjFhXfBdHNwRYdGrOuJ2nFnbZmSUK8vgjpSZNrdETloTkA7EcydgebDLU8 aR3XNwHglTTkBBJKWzup9hm5pdtqY+M= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YhAzsy8D; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf23.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702424421; a=rsa-sha256; cv=none; b=GOmOwZ3EG1WpRd+zHxkY9s8NrGn6Z5lN4ucSmEp6ih44w0+FmtqV1q2/Yd35rD8ZtuQwga zHAg8Mxpa1q90/0cpedyystjywbOnagSs7YFCedwUJrq9Q0YkISwZdg15aQiTqF7DTRqOQ 3rZR87fAmU6vb6CyT8fq3f/8aosQZsY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702424421; x=1733960421; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=rYt9y8KfAs0S4u+oQu0MTYyoDHJrw5FTNqxPbQrg/eU=; b=YhAzsy8DTOLXhyRdtouml3Fbw2Yg2TI2vfJFnu4uMi+Va2LQBj513bf5 OFJ0ac7+xLLpBXeeASNRcij3p19/qIC7sTo3E51/cIhje3hu5ndKGDJ2S RFiKZRl7VdOEgsRViq1Dwt8NqT+hQe8Bfj4ho25Yw4B1ck871elzgnj1f KxurBsa4sbzOFuvoS4klBh5W9A5nf51muJDlZzRinwMJIQLhTc7XDm4/L N1CGn5QM0tdQbPRBkVW4075NRw7oUbeX45lv7HqctgtKx4YEzev+qHDbJ +wMk9AdQ2kB2nQ9+qA2yaXWtgTLZYHwXwxJBqks1WrtlIqU0KcLefNaYw Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="398730468" X-IronPort-AV: E=Sophos;i="6.04,271,1695711600"; d="scan'208";a="398730468" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 15:40:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="723414887" X-IronPort-AV: E=Sophos;i="6.04,271,1695711600"; d="scan'208";a="723414887" Received: from rfield-mobl1.amr.corp.intel.com (HELO [10.209.75.26]) ([10.209.75.26]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 15:40:19 -0800 Message-ID: Subject: Re: [RFC PATCH v2 3/5] padata: dispatch works on different nodes From: Tim Chen To: Gang Li , David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com Date: Tue, 12 Dec 2023 15:40:18 -0800 In-Reply-To: <20231208025240.4744-4-gang.li@linux.dev> References: <20231208025240.4744-1-gang.li@linux.dev> <20231208025240.4744-4-gang.li@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Rspamd-Queue-Id: 0AB9A140013 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: syeqwe8iy8dib8jbmmgipefoorzokmti X-HE-Tag: 1702424420-304411 X-HE-Meta: U2FsdGVkX1/uMxVnEG1c9xrlqB9DlwT6GcGoIiNZZ1XJL7oC+oXrdJMoonDcoawVFjiFvp6Z6dmiO5arobm4Cw8rECIHc1W15Qat57AQSuIpU9moIez+GWoNaoJsLXWohW0JpPufOnw7bu57GLrRQIMpgScuZebSkpbDHfoRGhUFmMFrnNLN9jXaIjlYvJVw+gqh/m5mXphOqDsna0JSlRm2qvptcj8qSI/Ta92PFXdJHZ0TAyZmlAmFHSdb+YwzENP3EkJbwJgjjvREnBFkAaora2Y2JwH4zvZKVNZlo8SMwshz3/mLpWcfRwFJq6JBv6sMcgssX/qdgObPqKmmQgyEKrR549EvPgVKTXSbbgEb/HVzR/B+vRqBGeSl3cgqWNRrSRfH/Tj6mJwsaR22kKix0E5GbNITh2G4Rs91KKPfXh9vyi8RpVmjLQn5YY9+Q7Ss6GwkZeMu+nbqS4EuWGBkHzwJ76Pd9XmUkbHlIaA6xIOQie8uU0vRoODWuB7ozT9AqC5NM5g6BD86+Glxvu+20iNAQYwR3eghh19ISfocXV/EJQDtBLL1zY/x0Clc0Q0jXAbRkK5453aIj+TCIWrvIzP1QgubJO/cIF79kB9WnMxsbWjb/G+AT3sXK3Ll6yj39JIT+RXDiun116gKWojDBm9u0e1qGWd72BTYbODEfSouzLYEfioiynV51eSgfB7HszdRjfvAsmwOVIlAE2FJHUO72A7xcIYISwerLvfGz/fIGVrmpgdLZGIts5gDOCXDgZcbQbv2m3N8oNTXiRNRHk+r0W/W62XTWUM/N4JCwq0V9/l+Y918WovCJ504PbynaGRStxvT7vvgK9aPCLaYNT8Bw18yiJvUvSBkyAQdtKS0bSPlGWj7c0CAWIJoNaELrpRdMIA4+zid1jIQ6Zo7h+1Syw7CHRDg5MFNbcRHBX6TpjtDxllOP0vH9AEgZU9gAGMABuKxe4Ba+tB g8tSL9kj w62G0iPqFGCnfLYGImFnXZIhNynhpP7saR1HB6qWnRoL1PuoDO8zV1P6/DTZqpT7XGcg0FFexYjuLlqGjNHBUIXtlmsNTXLRHHopbqUmE02w2SpEP1hi15786bT9deoy9UNq5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > =20 > list_for_each_entry(pw, &works, pw_list) > - queue_work(system_unbound_wq, &pw->pw_work); > + if (job->numa_aware) > + queue_work_node((++nid % num_node_state(N_MEMORY)), The nid may fall on a NUMA node with only memory but no CPU. In that case = you may still put the work on the unbound queue. You could end up on one CPU no= de for work from all memory nodes without CPU. Is this what you want? Or you would like to spread them between CPU nodes? Tim > + system_unbound_wq, &pw->pw_work); > + else > + queue_work(system_unbound_wq, &pw->pw_work); > =20 > /* Use the current thread, which saves starting a workqueue worker. */ > padata_work_init(&my_work, padata_mt_helper, &ps, PADATA_WORK_ONSTACK);