From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2EBDC2BD09 for ; Mon, 1 Jul 2024 06:47:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B94A6B0089; Mon, 1 Jul 2024 02:47:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36A006B008C; Mon, 1 Jul 2024 02:47:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 231C76B0092; Mon, 1 Jul 2024 02:47:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 031036B0089 for ; Mon, 1 Jul 2024 02:47:55 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 601B0C191D for ; Mon, 1 Jul 2024 06:47:55 +0000 (UTC) X-FDA: 82290253710.17.F323F33 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf11.hostedemail.com (Postfix) with ESMTP id 11EF34000C for ; Mon, 1 Jul 2024 06:47:51 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=AkbzC9wa; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719816457; a=rsa-sha256; cv=none; b=Hyfb2dgrhbOgt9I3km/BlxIDw9J7jvT3HWRJTZ+9qhYqEIR749pgvTxAIOX3ifdzrqqExO CswLGOJ+VFbASCTN3iL7xsakn8wg5rZAWyV70nIEHyegTdLbGmAxtwcbLhWQSoIMc24K/k 4MQVAynJZuXGv03nt717NNVgls6VlXI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=AkbzC9wa; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719816457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tv+yLIfmdzLl29R0nyvxyY3onm0/k7/t4uet1fUaQvM=; b=nmKo2g+SCDO7yn0YSsCLx7Gk2LTZKTkKea2jTtz5CwV2i1ItSJRXDCrgKmFJ+heWqSF0sE W7P4Pv1sP9rvT+wmhC9vg1nwdm59/h3kz17FuPQiHcqL6MrDmGdocwBtw2/fMht0avJx7I 6jXLfWC482jQL8He3W3anvwjaYLUhQA= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1719816468; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=Tv+yLIfmdzLl29R0nyvxyY3onm0/k7/t4uet1fUaQvM=; b=AkbzC9waBjAn115FZcpaRxnrhES2S9YwQN6HtgCdYgZCBNR2LF1LIE/iJp2lxmZVGjfJMa/1fRV4nV71GpAX1M9tVCnzvo5WQRzS4MaoQ2z7MkUeQN+PIuw+yY5x3wdcsRfPLSzHTFSQMvItFoUgQolb8kJxhx+ec3DWYvO3sLo= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R761e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033045046011;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0W9avhwJ_1719816466; Received: from 30.97.56.67(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W9avhwJ_1719816466) by smtp.aliyun-inc.com; Mon, 01 Jul 2024 14:47:47 +0800 Message-ID: Date: Mon, 1 Jul 2024 14:47:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] support "THPeligible" semantics for mTHP with anonymous shmem To: Bang Li , hughd@google.com, akpm@linux-foundation.org Cc: david@redhat.com, ryan.roberts@arm.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song <21cnbao@gmail.com> References: <20240628104926.34209-1-libang.li@antgroup.com> From: Baolin Wang In-Reply-To: <20240628104926.34209-1-libang.li@antgroup.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 11EF34000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: et57haec1z815a58bea1ohspugnta9f7 X-HE-Tag: 1719816471-703847 X-HE-Meta: U2FsdGVkX18SJzMI2NhjeYjLdxpLP6ib42dpcGjSapizgfgkNGy5CrC/4/pCx1KWkPf/LaEit+Dc5vykEoDf/aAsqY56mUazw4Kb6fqI6huUXIXnvq/1f7tLvfPDfWLOv2LJC5/cMjLvB8A8nu18qhPFgVJzqC2g88j7ejAuSG5X7cmc7e9xg/j6cVLu3h+CP+xmCHYPBXJNjEcmqrLRhBCtbdlSKugJGDLVKhBxaG/mVi5Bf8e50qE161iZ/60m4OPWWkPdtFpkaq1zzQ8qvMgzxswIrOdW3X1nCDU77ZY5VSaxPg5lyWDQhwDJ776emxvXzkli0VfiDp6Wei0z5AEhH4KtVhhcLL/dQuh6DDFZV6T9W8quEnOCW45Rcjz9dCMswDyl2jMbUZlvr5Wxnzbryy8PueiUpNzXZh4yFoajgS4qvqtNpE2hP6YwMENU9OZA2g+M94OzrN2tO4HPaXLVGkkO/8hfojZO9WAKaUKUO/mCZ3hMzLg7v72Wpc4ZEqSfLmrAv9zmBLzoh5KJtWB38OZMlAFtL3dAhD7uME6stM4ZgG1lwt/gcbVuV+nWUYkFurkv1UE41eEWXops8//jaLoS+jJjNyFZqpVhDVB6+F8jGyP7dw+vM5roVFaZMAiH6BaZy0Zb2RAHf+Bn/wC3v4tLK1BkV7K/25JlIF/VZmRifOVT5SNPfXA8Sz6P1Y3hh5zd6sGqJcFSH6ttnb1nIQ/JkH5I9AQFJXRiSImM092VkOsbbo42DnL27TvjGgcz+8gdK0ahh80VoxJzfvh/Xav6vK2UpQ18f2Ntm33z4hgRUqU2FodFQi6zvCdX1K3lHtPWp6jPoT8frYJf1kqpsLjYpXbGVMRkteWVFIBNTnC8zXnMl299csGeeutvj4NRP12pWagojmmF/FFY8NCI+7fxOeuCDN9jiEe45I7nafTLa0zRZp6ASj8GWwb5fOW9HI/wOM18lvE0/o/ gxLb9jxZ pr91yEW2pM/tYrOGLsTCCjHVoXX/DX36sklstuvtnBMMzBzEYaQHPLUGW8STO/RftIIv6RwzkaPk8A6KMRq10UUpRuwfxxbxPm19GtO7EnTbxKwtYMMA32wuGaS9ce3QJVTk4KNM/tMdin8VI+Ja5jY6Ay3NcH1PW8KfZZAoIL1gvJJ8rusSp3hUuiaATlNTPD7XBFYGCA3WeQeebgRDpvGi3c2RQ1sCbY7++lxM+w0xa+JotbfoD8DbeKd94AnifQJY4oP/7lf/gbs+7xcH4rhjN/BD/shVFRYRoStl5DDcF87up1jDFCtrtrbfvakvcovuXrUG3yW+0S0NPV5j2xQx7LFaftFKRoT37UW6JH87j7i5lewiMqvrXxVC6sZHkRm6AQQF8vpRLeG9/tjTrBZuqDzHEfMSaH/r9A78R405d245411OVu/povFeuqqdNgCki X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: CC Barry. On 2024/6/28 18:49, Bang Li wrote: > After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for > anonymous shmem"), we can configure different policies through > the multi-size THP sysfs interface for anonymous shmem. But > currently "THPeligible" indicates only whether the mapping is > eligible for allocating THP-pages as well as the THP is PMD > mappable or not for anonymous shmem, we need to support semantics > for mTHP with anonymous shmem similar to those for mTHP with > anonymous memory. I did not see a consensus that "THP*" related statistics should contain mTHP in previous discussion [1]. In addition, if we all agree that "THPeligible" should include mTHP statistics, you should update the corresponding documentation to keep consistency. [1] https://lore.kernel.org/linux-mm/202406262300.iAURISyJ-lkp@intel.com/T/#md7a77056110cebcc2a9b3cd7e4a8d682667f6ba5 > Signed-off-by: Bang Li > --- > fs/proc/task_mmu.c | 10 +++++++--- > include/linux/huge_mm.h | 11 +++++++++++ > mm/shmem.c | 9 +-------- > 3 files changed, 19 insertions(+), 11 deletions(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 93fb2c61b154..09b5db356886 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -870,6 +870,7 @@ static int show_smap(struct seq_file *m, void *v) > { > struct vm_area_struct *vma = v; > struct mem_size_stats mss = {}; > + bool thp_eligible; > > smap_gather_stats(vma, &mss, 0); > > @@ -882,9 +883,12 @@ static int show_smap(struct seq_file *m, void *v) > > __show_smap(m, &mss, false); > > - seq_printf(m, "THPeligible: %8u\n", > - !!thp_vma_allowable_orders(vma, vma->vm_flags, > - TVA_SMAPS | TVA_ENFORCE_SYSFS, THP_ORDERS_ALL)); > + thp_eligible = !!thp_vma_allowable_orders(vma, vma->vm_flags, > + TVA_SMAPS | TVA_ENFORCE_SYSFS, THP_ORDERS_ALL); > + if (vma_is_anon_shmem(vma)) > + thp_eligible = !!shmem_allowable_huge_orders(file_inode(vma->vm_file), > + vma, vma->vm_pgoff, thp_eligible); > + seq_printf(m, "THPeligible: %8u\n", thp_eligible); > > if (arch_pkeys_enabled()) > seq_printf(m, "ProtectionKey: %8u\n", vma_pkey(vma)); > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 212cca384d7e..f87136f38aa1 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -267,6 +267,10 @@ unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, > return __thp_vma_allowable_orders(vma, vm_flags, tva_flags, orders); > } > > +unsigned long shmem_allowable_huge_orders(struct inode *inode, > + struct vm_area_struct *vma, pgoff_t index, > + bool global_huge); > + > struct thpsize { > struct kobject kobj; > struct list_head node; > @@ -460,6 +464,13 @@ static inline unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, > return 0; > } > > +static inline unsigned long shmem_allowable_huge_orders(struct inode *inode, > + struct vm_area_struct *vma, pgoff_t index, > + bool global_huge) > +{ > + return 0; > +} > + > #define transparent_hugepage_flags 0UL > > #define thp_get_unmapped_area NULL > diff --git a/mm/shmem.c b/mm/shmem.c > index d495c0701a83..aa85df9c662a 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1622,7 +1622,7 @@ static gfp_t limit_gfp_mask(gfp_t huge_gfp, gfp_t limit_gfp) > } > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > -static unsigned long shmem_allowable_huge_orders(struct inode *inode, > +unsigned long shmem_allowable_huge_orders(struct inode *inode, > struct vm_area_struct *vma, pgoff_t index, > bool global_huge) > { > @@ -1707,13 +1707,6 @@ static unsigned long shmem_suitable_orders(struct inode *inode, struct vm_fault > return orders; > } > #else > -static unsigned long shmem_allowable_huge_orders(struct inode *inode, > - struct vm_area_struct *vma, pgoff_t index, > - bool global_huge) > -{ > - return 0; > -} > - > static unsigned long shmem_suitable_orders(struct inode *inode, struct vm_fault *vmf, > struct address_space *mapping, pgoff_t index, > unsigned long orders)