From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A53C02198 for ; Fri, 14 Feb 2025 18:57:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A9AA280009; Fri, 14 Feb 2025 13:57:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 257A5280002; Fri, 14 Feb 2025 13:57:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AB09280009; Fri, 14 Feb 2025 13:57:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DF084280002 for ; Fri, 14 Feb 2025 13:57:31 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 53C654A1D6 for ; Fri, 14 Feb 2025 18:57:31 +0000 (UTC) X-FDA: 83119458702.14.4325E5B Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf07.hostedemail.com (Postfix) with ESMTP id DEB7A40002 for ; Fri, 14 Feb 2025 18:57:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FmRbxWtw; spf=pass (imf07.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739559449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eGdKlaIu2Hqo7A9kcanHsEPpJXJZk+mSCaKNb2WNuBc=; b=mdO45OHdxazO5FWAhnDxS5vlaFOs4YJPwmcptRbMMZMEu0Y0q7GQpq8OHgWQwpx2IDh1Xe pR5RW0WBQ6hc25SG1IbquTiPchu2r7B+3KYZw43WQ7pOMN/fn61iyGuPTGfHo2qiebaThq 44WXOnDjxeEe9n7sYfC+uQuQ7NxNMfU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FmRbxWtw; spf=pass (imf07.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739559449; a=rsa-sha256; cv=none; b=Eh5SmwKzhVtd5ORDxsC/nCvUElRRF93NYvcVOOM/AI6Xy+rtlSZao606gn9O1tBux9tdzb itgJf+jJaPXsdHDO+RgM6FuFiM7+PgURHAAMx5iajZ33P5Pe7Tbf4xvxuuSapaMLrhEeOl u71swh5rsgznghsIONCeucqNKOobAfc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739559449; x=1771095449; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=01G4botHn6BBAsf41dd0Vwsbuo4QDB4SsneleeIzLt4=; b=FmRbxWtwwbr3e7OtmLbmNR793cQYl3mL69UOLqGruEY3LPVx5PgG+xle 5i+7kp5qiJnL50CwDBWTrD/ZjlW71MsEE2/5FSKcyUiQHV0/CBASCVI6b p5u441VjcvVmOe3XcVn94ZhajroyetyzS7FWpYv+EESxCYoaQx0OcbRTA S5HXV1wzlDJs3vEcouBFQOuSCE6BGK/+TPPI3tho/qvlMfoFO++XX04zT XsD2PApGubTyDqLaGcP7eEEjDgnNK9DgSpEpWnXvPJ4E5eNaqlDCCoGU9 6DIhaZYnqgv8p8xFuy/xLSIaqSUiHudazj+UsZusOQfgREoBxAc34t6hS g==; X-CSE-ConnectionGUID: Zn40enKWTueqlwO5Cr3QDQ== X-CSE-MsgGUID: ao4uiAC+RfGY2CJ8pbHcuQ== X-IronPort-AV: E=McAfee;i="6700,10204,11345"; a="40459357" X-IronPort-AV: E=Sophos;i="6.13,286,1732608000"; d="scan'208";a="40459357" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 10:57:28 -0800 X-CSE-ConnectionGUID: tCk+ebBoTMOrfCKt5V8UDQ== X-CSE-MsgGUID: J1/Q6msNQB2UMwyKSKYQMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="144457851" Received: from tjmaciei-mobl5.ger.corp.intel.com (HELO [10.125.109.21]) ([10.125.109.21]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 10:57:26 -0800 Message-ID: Date: Fri, 14 Feb 2025 10:57:30 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 07/12] x86/mm: use INVLPGB in flush_tlb_all To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-8-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250213161423.449435-8-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DEB7A40002 X-Stat-Signature: wrn4sax6hpp1zf4uh7j5pr11ccdgpo9z X-HE-Tag: 1739559448-317344 X-HE-Meta: U2FsdGVkX19XrexwDLAW/PnOI1XiO+d/5mJrhpHfKlvdFWI7HGgvx/90C73heWMlIni0H2OqTX3s/fDzfMvMGc9zHkyOSNElSZeyGGCEEc4/nmANdSsEEWoGkeBGH7QBqyP2IG5CbrMidsQr4dqfmj6f2KSNuSXF0Ch0iu+Nosq0HaswvCqLQ5VAT+rZjmYiJTv3xm5j6xDzaxpO3Li5f3p6ySX2BkKDkVRke3i9KposL2utxnO6fC+W781nD8LnACCWa8FS5fP/Wy3ON3+ofZuU3mCumdQgpc7zL0zkHrPRjASqM5UgPzklxkWYRrYFtmwdY/wJ1Cst3tXwF7kDaD6rWFjhlPNcdHbU4dzXchP1rIY4diUzytdeHpppetpxkRIJYLMJYGIPHlbk6fApcyUoPFAG0hQ37fZgSFV8nHM6dQhUdH+MM7KwDkIK5GEyOtGgpfc3RQ26bwkFnHcAMb0BiRKOMAjR6WXKom4QMW2Kf2IIiLL8z2IfKOYThGycn15fYO49eqq97yQib3eFyLVjTpAfyuuUHh9pmKz/hAmRDCfHWIEDlec1Ko2zGm/RDQfJ1iQ2EIA9lNuZEDJmvhoH5DJPzr10OjWozOhymubyn2BXQZ02LmijnTqpoaL4TjPAZzbZ/81Jvm5A6teKfjBTODoJ5shAdu8CvHykn+lxHD7XAsXEy7LaOWQ4AmViub/eCrlScL2EjuskgtjiuFT4uHy3ZRPie3VL3JxW7oKzlnBh5KK8USBlbtlt6zRV4kW8PLmpfDRRMCU/+IY665HIWt6PVUnE2KJge3RxluWQGFmLNcCnqnjiiH4uNy3KkibpqlrM6h3TxrnMcbz8QE2Z2t1xLqgRjtOzKAyME+GbPl/RuuntjCnjTsYKBKRrj9GgIdZY7iLJPjesok/mTDbfqDIF9ujouVJ9PTAwnbTs4P1b60teEq3b1gYVmc/TJLezTjdewcU6uFDLsY3 JlZ+EYYj bzhXRWb+o0iljEDLfXzy9lEjMFc32ZCRanni7Ih13fJT2wRrNL3ANLVOhIlWIEpcEbL73K6jnPk5zmud7XCCk/3uApIEEB4iPjFU+orFbLprbl1VeCYmRAwtDCQG44+JZ4Z6+PiHL1m8CXMIhUZR39pSsPc9wFTbuHafeycHV2vTXpoOmsYO20cgijAsHFQMivmJXJnTDTfP8iVUF6Z5vMRsUqiKcmbIXpXytucTEFjNsRCD0cA1gEnemg/uEEYNSD6zLfMoPdEUZF+X6Mj3XZFCcJNvObX3KC0WjlytrYB6wFudue4QaOyB2qbcX/AYaQrmf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/25 08:13, Rik van Riel wrote: > void flush_tlb_all(void) > { > + if (broadcast_flush_tlb_all()) > + return; > count_vm_tlb_event(NR_TLB_REMOTE_FLUSH); > on_each_cpu(do_flush_tlb_all, NULL, 1); > } This could use a couple of one-line comments. Also, let's just keep the NR_TLB_REMOTE_FLUSH manipulation even when using the INVLPGB. It's still logically a remote flush even if it doesn't use an IPI.