From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E07D5C5321D for ; Tue, 27 Aug 2024 01:26:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AB006B0095; Mon, 26 Aug 2024 21:26:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55B9E6B0096; Mon, 26 Aug 2024 21:26:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FC606B0098; Mon, 26 Aug 2024 21:26:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1F6816B0095 for ; Mon, 26 Aug 2024 21:26:11 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8FB2E161095 for ; Tue, 27 Aug 2024 01:26:10 +0000 (UTC) X-FDA: 82496284500.14.AD88A11 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf27.hostedemail.com (Postfix) with ESMTP id A93F840015 for ; Tue, 27 Aug 2024 01:26:07 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724721882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TimVU2Rt96tQaOoXqoQck7HKb4ptmk7izNEyl/WlRPM=; b=ML4YRYj+GYd3qM6QMG6Z4QbMbEIasDmfmH0hADTfvqJTmE9cJi8Dvdn5vX936X1MJtJsDs CpYkNokdgV+MhZI6FObz29tJjp7YTJUfXdrIrSFbJd888v1W1k48bAybW9nxWhT8mTnU1w eES+OWKq+SyL/Hm1vGed75aFB1z3P8Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724721882; a=rsa-sha256; cv=none; b=unN8OJmDLNy3Ld/qiJLY++18+KbjGXeBrOM9zap0ReRuGJtKmOFjtT+EQ4u8izpTC7at18 vHnh0E0EI94K1EVsU5uvvP1OrcyhNvdBuUMdPn0TF4pq+9em6iEiT9gznKNmIk3x9nWXJD ZwDoe89T0mo38LTxWZA0pgI8PINrIqk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Wt8x86sMpzyNtY; Tue, 27 Aug 2024 09:25:16 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 94FCC1800D3; Tue, 27 Aug 2024 09:26:03 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 27 Aug 2024 09:26:03 +0800 Message-ID: Date: Tue, 27 Aug 2024 09:26:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] mm: memory_hotplug: unify Huge/LRU/non-LRU movable folio isolation Content-Language: en-US To: David Hildenbrand , Andrew Morton CC: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-6-wangkefeng.wang@huawei.com> <81c2219f-5dcd-4838-8c8d-767b7ff9f714@redhat.com> From: Kefeng Wang In-Reply-To: <81c2219f-5dcd-4838-8c8d-767b7ff9f714@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A93F840015 X-Stat-Signature: ocmhnzasxegwp4rm1uhrfokforcjqux5 X-HE-Tag: 1724721967-107746 X-HE-Meta: U2FsdGVkX1/oTBOdSC/sv4VAQ6FjEY1V621yiPsRp1WU/Kh5LNeT6T/ND1MgdlAzCeFrJkFrC7jPsltQ5pteG+tCEHEwy8SxIqWhqDYKkjPqYw1wt6d8nzn1B7D//QH8p2ZxgDWse9hWtRPJFZ0nxcdKxW+URLASbj5zli8+j3Jzq0Q4fKpdh8Y51RqlkIYx5BZSKTkSmyX+1fovKrWaBzFbkuvtf4xnHQ5U/teQhFBD8YpYGqbQWDyE/eorN216y+rXpBLskKDmpQj9Pey7OW52JBsPiDDmOLtfyP74KF5Zvyxn6SBuq69++Qk4awsFHSWhTT3ZCIrNLmay6ZYrVLBhnqV0WKP5F6dqKBrr7nT2syCVgBGzu/IlAkoBvsBa+jU8RdtRkET4ZfjlpHCUOnLojvpsev6w2r4gdAKvag9hmxpHa14ahcRz+HlLRT2KzAuMciNrH+0ccdNwXaSWlY//ARMSk/oRQBs3bv8Y/cbEdgVSZr2GgG4/ZoifmRr5KWQSy6f2CXWOr5uIk/9eyQr2cBOHfGQJ7QIZvpcUwYEqo0e7XeUZXo5o2vEMeH4+JGG2Ggn8XgBeTcPHlgXuCvkF5f0gsDcR+4un3u/sY9Ve9QxyP+lOQZHLAIq8XV6B86ttDl+erbKyKESKK9+a0ML4X0BTVXKNOEGrlV7xCsoh8Hnns23UtGOh0/HJ9HM184zSIU3E8YGK4+Lj0cdhKX3i8AR6Rzuy9qunvZZeUL/rKFOg8G9msOv0PzLOUTX4OFI5TpITUdjLDeSVd285xAp7OnFCKE/EJ2Iyl3WuMgHaH2ljyzT7GlkUjuoDBLCXFWEFwmC01Su3oGWldeWSqnUF5de4ogERfjC301DNhKaiAmycnuQy3eCZZnfc35fJa3BroKSg2NPmlP9yoEZO9nJMGF/7WWK3v3H3YwmwWlSk3PDe33of9bqU3mJQL3NMXtATPSkGM8UjzxBsts1 NMaQf6ak yXXOLjpv15NE/W2fErtWIhzZjGwYc7pXw9yVXvlccHHO7wocEDks1nQOb5+0ExHS35QEje1A4wa8WAZSchPSbe0HgU/ecWnn9xyOKOscWMPqv/5IDq1a99FOjTnEyRDL8KBSuPU3jO4ae/S0Za3c2+mlk8wm8J5jB89nDiPC+6wjiuJtETZQ5Ih+o652eNy6krYwbZmKnVG5FMWtqYLXCV558ZokedwHYlD3z1gfCjYzxAHnvBBF8Ev1pPORS53Nx41FIjsWqnkzHCYXN6pFeYMzhPTox0Wtcx1nsPa82N9hbc9jS0zWtwa34j7yViDhR1F9nXXe48m0yJqg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/26 22:55, David Hildenbrand wrote: > On 17.08.24 10:49, Kefeng Wang wrote: >> Use the isolate_folio_to_list() to unify hugetlb/LRU/non-LRU >> folio isolation, which cleanup code a bit and save a few calls >> to compound_head(). >> >> Signed-off-by: Kefeng Wang >> --- >>   mm/memory_hotplug.c | 45 +++++++++++++++++---------------------------- >>   1 file changed, 17 insertions(+), 28 deletions(-) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 02a0d4fbc3fe..cc9c16db2f8c 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -1773,14 +1773,14 @@ static int scan_movable_pages(unsigned long >> start, unsigned long end, >>   static void do_migrate_range(unsigned long start_pfn, unsigned long >> end_pfn) >>   { >>       unsigned long pfn; >> -    struct page *page; >>       LIST_HEAD(source); >> +    struct folio *folio; >>       static DEFINE_RATELIMIT_STATE(migrate_rs, >> DEFAULT_RATELIMIT_INTERVAL, >>                         DEFAULT_RATELIMIT_BURST); >>       for (pfn = start_pfn; pfn < end_pfn; pfn++) { >> -        struct folio *folio; >> -        bool isolated; >> +        struct page *page; >> +        bool huge; > > Please use "hugetlb" if you mean hugetlb :) OK. > >>           if (!pfn_valid(pfn)) >>               continue; >> @@ -1812,34 +1812,22 @@ static void do_migrate_range(unsigned long >> start_pfn, unsigned long end_pfn) >>               continue; >>           } >> -        if (folio_test_hugetlb(folio)) { >> -            isolate_hugetlb(folio, &source); >> -            continue; >> +        huge = folio_test_hugetlb(folio); >> +        if (!huge) { >> +            folio = folio_get_nontail_page(page); >> +            if (!folio) >> +                continue; >>           } > > Hm, remind me why we are changing the hugetlb code to not take a > reference here? It does look odd. Different from folio_isolate_lru(), isolate_hugetlb() will check folio and try get a reference of folio after get hugetlb_lock, other hugetlb operation protected by this big lock too, so no need to take a reference here.