From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99490C71136 for ; Tue, 17 Jun 2025 09:26:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BC286B007B; Tue, 17 Jun 2025 05:26:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3944F6B0088; Tue, 17 Jun 2025 05:26:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 283CB6B009A; Tue, 17 Jun 2025 05:26:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 17DB46B007B for ; Tue, 17 Jun 2025 05:26:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B737C141B34 for ; Tue, 17 Jun 2025 09:26:53 +0000 (UTC) X-FDA: 83564363106.25.B578F90 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 33DD51C000A for ; Tue, 17 Jun 2025 09:26:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LCpjHcHN; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750152411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hk/BPIhsLuiwabR6FYxikcyLQpMTxlPRv796ypZ5BV4=; b=Fj5f/6wkk2vNRwee1THFkx3I3LSvA7PcCdI6iVY6KqpJMT1x8pAoQlM4JcX4sANyFO0SdX fIqNfNtez+nbR2hNB1UUk1IOEfzKBQQgvmpaDQcrs545LmhiG3vYO9HfVYUy3KFgt5/uJI ycCmKEQ/z/YUZf6eYa4xml4DjI7Dh8Y= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LCpjHcHN; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750152411; a=rsa-sha256; cv=none; b=DyS0zsEo/QrvD905lgXgDc/tGNcwIi0bi3daSCPL/nlmRMIRy0Bzi5Bpe+GHtRCBDLeRjS Vxyzm4NNDVTIoGCC3wi2xkDwvcoIqRbQianJy7AjXqpq6IR8gjN7IFxPvGbTHjwznk+hSe iNAe0QPUdL+MlnOC+aY0j0g+kO+YL5A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750152410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Hk/BPIhsLuiwabR6FYxikcyLQpMTxlPRv796ypZ5BV4=; b=LCpjHcHN/LvWDb6PFOEPFv4DEOY9VpopltfhQYnTv1TmShFLIzUP+w7n4mVgIsymP0n+rr l4Y6KztLlQXKqvGCrmrLRezR+9uduHcHPCQV+9E7dX3jNcjDtfvUoGHLgZDvKMXN3wP0Ce LyIhxAzX+9gyXl6msxBwsFbEVyaXxcw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-NjNEJZLtMTqYeerhOTUL7Q-1; Tue, 17 Jun 2025 05:26:49 -0400 X-MC-Unique: NjNEJZLtMTqYeerhOTUL7Q-1 X-Mimecast-MFC-AGG-ID: NjNEJZLtMTqYeerhOTUL7Q_1750152408 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f85f31d9so2102406f8f.1 for ; Tue, 17 Jun 2025 02:26:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750152408; x=1750757208; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Hk/BPIhsLuiwabR6FYxikcyLQpMTxlPRv796ypZ5BV4=; b=se45AW0aZK4GKRIDHAJaTvEGNgyAYl53JJN5ZeXw+rHbTnk8eQxyv/2Jpu3AKRI12J 9qu2/90wccBUwUznvuAFrZsHaQscvSZvuIEvkfjckcswMmGUm9y1A6KyuW7ZvdqZ1mjQ dX4FM8um+cvOSCuB8puHoX7nJLqMDo4brKqh3jNfN0k6aCNUuFhxJqcMQ/Uu92FvHr1J iqviPms+xDc9L3Bk/p9Ores2Q2h6lkX0JoBGL+agAbRv+zDaaORzdj+al/KuM3QUiqyj CTk5nqNqVQ27hAo4hgen4g4g7/DcaEc1Ery7rYkqsiBAM080fktOhAZWMv3eUAhzSXGY HKgQ== X-Gm-Message-State: AOJu0Yye5zhpFBBTLmB+3/+AuhbKyjEuUONEWL20AF0Jqg8kEh1OLx5b NKcBZEQ37ovTzw5gCPMpPbzMuvJrkgtmXml+ZyzCAgCwTbvF5TxMbVObqPtv1eAI/msBUNcXlP7 cT5DF9TATsbUmx8z2GZ1HLfROlPttBRmE9ZPQT5Z95iLuVC12UoZm X-Gm-Gg: ASbGncuDMuF0Iz8bcJKo8hbMnHxFxFO6g699ta7aXowP+OR2ys/BwBKaS8YIBKVVsin FI2Sq6ylpjyTKwvDiMhje38udpWOD6GN9qUNrzLfexRB4eKsBwT8d+UqwkbczHWeR8g4r+zKJmc 71do9KO0hERIVrrj3c4/KTwLasP3qILCgKTFrGkX9BnBZGivSA3sEaaPt6bDq4GIIeUPC0+JVYw XswsC0nZ0KmlYa8U1gZeoHfYpV1OIJ+IsX1oOGIOELl1M6SphLFZzVB/4cp/NThfNPUbC76Vef3 SKtP0HcewL4lZMxp8yxoPkBCzxG3p8/Nn9QPPBw/xv/hUbHTp8CG+dfz7wWj6kXPjmmEUNGGT7N NhWqsVCYBPyLQ+0PVlQf7ws9HBq5Psfdql4xUy1FKzn8Mv8I= X-Received: by 2002:a05:6000:2089:b0:3a4:f663:acb9 with SMTP id ffacd0b85a97d-3a572397762mr11631646f8f.9.1750152407857; Tue, 17 Jun 2025 02:26:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9GzR1TqRnCT0Ecax6PWVz9Y2kIUUwsOz9gbW3DR4Uq5mpu2c4hBo9aKPgY/qa/zS7oaUfjQ== X-Received: by 2002:a05:6000:2089:b0:3a4:f663:acb9 with SMTP id ffacd0b85a97d-3a572397762mr11631622f8f.9.1750152407481; Tue, 17 Jun 2025 02:26:47 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b7741bsm13584395f8f.98.2025.06.17.02.26.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 02:26:47 -0700 (PDT) Message-ID: Date: Tue, 17 Jun 2025 11:26:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [QUESTION] xas_reload() in iter_xarray_populate_pages() To: Dev Jain , ziy@nvidia.com, willy@infradead.org, dhowells@redhat.com, hughd@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, aneesh.kumar@kernel.org References: <20250526063524.22597-1-dev.jain@arm.com> <918d552a-085a-4529-8f20-a060b1f0c9f1@arm.com> <5bbf39b9-ddfc-4d97-8f08-8bd43223982f@redhat.com> <8b8ce450-0300-4eed-a80f-2e8e18fb4e11@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8b8ce450-0300-4eed-a80f-2e8e18fb4e11@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FLF7S94vK0xhpGZRt9UKerWx_fMSX0GZDQahzsZDtl4_1750152408 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 76t477d7188zymk8g1u9dmsqyxdrpgdg X-Rspamd-Queue-Id: 33DD51C000A X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1750152411-457056 X-HE-Meta: U2FsdGVkX1+X49dGmhK9w4TkEeIkY4V1nA+1/ygHsnvD6/4L2EJ+ebij/GQNPZ2J8ygw/2MFzDoAUlGCwmuZG6MWByWihkoTPrF8wMA3fDxMmWDosk6pPba3FX9i4NRUGtB5LCXdicOmM8hA/qge6MwAt2DeV7ktSWZ/rXJXLK20mavHL8SW5ArMEF7QSVpwnou9BvCaqJml7hcXi4PO9FUH8cQlz4RaEm08+206cRgi8PwynVmda+qOS19/9OXvyegeoatK1DH/kIa3baJwS2T5eN4uTlMHC8eQilfWyJwrL7Ug9OH59+89xGsftYvVHLOHM6nSfKHJZ23rkz2PqC9YgLPrhpm4vprvsTLDfqOZwBPRyWnAO0HQEsbo/yEDc7KWpPCNwpUkXhS9f/Kx72DXaVnDDuO7MF2vZuv5Oe9k6fXmsTc78dHPX45zGgYbf7GpsoU0fJWpGzQwxBTVYa9uq2aSVt9pZ78dTpLGbLVITS5baL3Pjzwowhx8kGTKd8rsDrnBsBGbEExf/0FOAdBFWa4wGvO+ZpuXTYV1ArwqolDDAJM5G34jhiijOrrSC9MnxjOE0N8MBbRIlnnBGyQCVDcBt9wNZon+FqTc9KPZkp4g3LPMiNhgdFcpyBFB491MIjaLDwXlfuxB8HmYJvEbP8xWYthtMlp2MchYyyrhynXg1ET5ZKOlbn8nmeyuFJVkT+vJqbLOcLz/Eq1K/Edezx28Xrzru1XbNeGSAXvRDrvjqxKMKqlF0oRGcf/iYSnXJFqU9he8MzwpRDRotkN/4NEkxBOmZDs1wM5x2nBBXTRCzId1NVx0uZNk+lvvyz1uUYucfFQcgp5Fr4zZGAFxC8G53z9Kfv1TT0Uk/e+cEeCUp086JjixSDEAJMnXRcJrSUDnyDAzSOcGX1N3Efrdkr1dcvQHFl4PivrL5m83d4P+CeqHnn1x5825OjV1SpgBrhNi1MkCEVnsw2n F/5g748v azl6z4KLSrWMWdrNFvJTXACGi3ZYVneGnoLDki4pDsk2qHaZhs07YmKxJqtB1OqbYAPSze+CxqGIgbyvPv12MGiowQl0o4CaoLfDV7cAAoHkMo8KrCQB6HI7MtBnvFTcAfWP608b12a3IrOreUb5o6QZmSS/AAYX0FXcE/jphVqTV9Ujxa0a/AS7EGwgJ6uVLduqt8xRP1tI8wx1eVmK8+NdKolziOxLSVOefPjNdiPiTWqFZ4wYpH9eL0w72BBW0R/hmIRqJtdp+cyGwJvvrhHjJpSG1Dl1V7WjI8v/iXrdPoPufhAU6NOWzLJTT8ZC5Vekw86imEii0vngsS8esHiW4oUcLizxBdJfaoslV/5CHCPZqEa2tHvCd+eZX+b3O9+vf3IFG07q1gCFJJqNDDufQ21Bx3e70fTOhjdPMnpySs6zn2vbxFLl/+URXbz8qLa1ezEOqZyiaA/YDYiGVqxQ0RFOxPpN04hEs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.06.25 11:18, Dev Jain wrote: > > On 17/06/25 1:17 pm, David Hildenbrand wrote: >> On 17.06.25 07:10, Dev Jain wrote: >>> >>> On 26/05/25 12:05 pm, Dev Jain wrote: >>>> Hello all, >>>> >>>> After doing an xas_load() and xas_retry(), we take neither a >>>> reference nor a lock >>>> on the folio, and we do an xas_reload(). Is this just to reduce the >>>> time window >>>> for a race? >>>> >>>> If the above is true, then, there is a negligible window between >>>> xas_load() and >>>> xas_reload(), because only xas_retry() exists between them, so why >>>> to even reload()? >>>> >>>> Thanks, >>>> Dev >>> >>> I do not completely remember our discussion in THP Cabal; I recall >>> David Howells maybe >>> saying that the folios are already locked, so it is safe to do >>> xas_load and then do >>> a folio_get()? Even if we remove the redundant xas_reload(), I still >>> don't understand >>> why we won't need xas_reload() at least after folio_get()? >> >> I think the points where >> >> (a) this should go all away soon >> >> (b) there is the expectation that the folios cannot get truncated >>     concurrently. So we can do an unconditional folio_get(), don't have >>     to check folio->mapping etc. > > Well...pretty sure the file read path is taking the inode->i_rwsem or > i_lock somewhere, > > to synchronize with truncation/reclaim, can't figure out where. Reclaim > takes the i_lock in __remove_mapping and > > then freezes the folio reference, so the read path must lock i_lock > somewhere. I mean, if concurrent freeing of a folio would be possible, the function would be horribly broken :) -- Cheers, David / dhildenb