From: Shuah Khan <skhan@linuxfoundation.org>
To: Chengming Zhou <zhouchengming@bytedance.com>,
akpm@linux-foundation.org, shuah@kernel.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 1/2] kselftest/vm: override TARGETS from arguments
Date: Thu, 3 Mar 2022 12:17:56 -0700 [thread overview]
Message-ID: <b29de093-72dd-1dc5-b591-2a75f49cdb2a@linuxfoundation.org> (raw)
In-Reply-To: <20220227055330.43087-1-zhouchengming@bytedance.com>
On 2/26/22 10:53 PM, Chengming Zhou wrote:
> We can specify which testcases to build using TARGETS argument,
> for example: make -C tools/testing/selftests TARGETS=vm, cause
> the ordinary assignment of TARGETS in Makefile will be ignored.
> So we need to use override directive to change that.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
> tools/testing/selftests/vm/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
> index 1607322a112c..0b330a5b1840 100644
> --- a/tools/testing/selftests/vm/Makefile
> +++ b/tools/testing/selftests/vm/Makefile
> @@ -53,7 +53,7 @@ CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_32bit_progra
> CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_64bit_program.c)
> CAN_BUILD_WITH_NOPIE := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_program.c -no-pie)
>
> -TARGETS := protection_keys
> +override TARGETS := protection_keys
> BINARIES_32 := $(TARGETS:%=%_32)
> BINARIES_64 := $(TARGETS:%=%_64)
>
>
Let's not override TARGETS - rename TARGETS in this file.
VM_TARGETS?
thanks,
-- Shuah
next prev parent reply other threads:[~2022-03-03 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 5:53 Chengming Zhou
2022-02-27 5:53 ` [PATCH 2/2] kselftest/vm: fix tests build with old libc Chengming Zhou
2022-03-03 21:27 ` Shuah Khan
2022-03-03 19:17 ` Shuah Khan [this message]
2022-03-04 14:50 ` [External] Re: [PATCH 1/2] kselftest/vm: override TARGETS from arguments Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b29de093-72dd-1dc5-b591-2a75f49cdb2a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox