From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A1CC43334 for ; Fri, 1 Jul 2022 06:33:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06EAF6B0071; Fri, 1 Jul 2022 02:33:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F37F56B0073; Fri, 1 Jul 2022 02:33:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB32B6B0074; Fri, 1 Jul 2022 02:33:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C60906B0071 for ; Fri, 1 Jul 2022 02:33:16 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5F01C60D9E for ; Fri, 1 Jul 2022 06:33:16 +0000 (UTC) X-FDA: 79637563992.15.2C9EC09 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf11.hostedemail.com (Postfix) with ESMTP id E37F540049 for ; Fri, 1 Jul 2022 06:33:15 +0000 (UTC) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2615pHTw024331; Fri, 1 Jul 2022 06:33:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=43E8lWSoKTQumIYPANAN9tbxhnCu/ars1CPwWA8NO1U=; b=JOKedKyLCivY7mYGp6FCPDuKCovFSWCAVRjPFXI3fesIQGWMJgvA7YSSjsJzaPt5BvxX GKtTEgQ9vHzZM8HoW6mA/B7zjYPAqYHrecJltsVT3PRlxSiDS6H8ZdksNGmGc0rhpeQa zfPKQSi36nFnLHhjqSHcMyxgS/XYNwN/jvRWp8wA8HqHlKQnnp8Ny9q/WbRpsO0VhCnj /Je01xQghaXKLjsRrLz121EVqY7+tVb5zOiih8hxDKKgaPp52nyPPXfn8rg6nQ8LMYap 3p/3ClpF3X5Na2AG0X8q3XTFfAEfLCGWRK4npqXxNz5++7mm0gj1ItRK9NK2j4bdNiAb uQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3h1u1c943y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Jul 2022 06:33:02 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2615phKY025370; Fri, 1 Jul 2022 06:33:02 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3h1u1c9433-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Jul 2022 06:33:01 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2616LMe9026261; Fri, 1 Jul 2022 06:32:59 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma03ams.nl.ibm.com with ESMTP id 3gwt0918hx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Jul 2022 06:32:59 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2616Wvsv22348128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Jul 2022 06:32:57 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 13857A404D; Fri, 1 Jul 2022 06:32:57 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 66371A4051; Fri, 1 Jul 2022 06:32:53 +0000 (GMT) Received: from [9.43.53.136] (unknown [9.43.53.136]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 1 Jul 2022 06:32:53 +0000 (GMT) Message-ID: Date: Fri, 1 Jul 2022 12:02:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v4 26/34] tools/testing/nvdimm: Convert to printbuf Content-Language: en-US To: Santosh Sivaraj , Dan Williams Cc: Kent Overstreet , linux-kernel , linux-mm@kvack.org, Petr Mladek , Steven Rostedt , enozhatsky@chromium.org, Rasmus Villemoes , willy@infradead.org, Dave Hansen , Linux NVDIMM , Vaibhav Jain References: <20220620004233.3805-1-kent.overstreet@gmail.com> <20220620004233.3805-27-kent.overstreet@gmail.com> <62b61165348f4_a7a2f294d0@dwillia2-xfh.notmuch> From: Shivaprasad G Bhat In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 8oemeT4kbVhWz-CORfaTBY1vKeWOi9_V X-Proofpoint-ORIG-GUID: Qyas4CxWbLYIFtodCSyStsjrbn6FwLO0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-01_04,2022-06-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1011 mlxscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2207010021 ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=JOKedKyL; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of sbhat@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sbhat@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656657196; a=rsa-sha256; cv=none; b=mR1brsbv59O0l1NR1u59Suvx8i6b+tytGvkXLy+aezAC6B/Ar1PVybrFPo9PA1kRBvJPMU rRGSEglSotx2iPiJp71Q35dy/wrywp6P1g2BDpiM4LZuUHtsRbWIuDQ1l7dtTs3u+zyUNg gxJFWI8DSiEGSPDo49xYjC35DVO0ufE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656657196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=43E8lWSoKTQumIYPANAN9tbxhnCu/ars1CPwWA8NO1U=; b=KSFTdhRrOuTgqxz8IbeRa6idrMakEtVmqTfeNy8AJRNFS269BKYczVI4Zcl4/Z+RZS31KN tiofiAf32/ZM4f54QtM9sk5iJcTxTaibmUhUTbMpAtyWWENRuImLaxZDtoRkhmFwtiumgr EqDaE3ZHZeu0mkH9JV8ENWR4z3B8PlM= X-Stat-Signature: cbez94zpkcoray653d197r8ad77qh47b X-Rspamd-Queue-Id: E37F540049 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=JOKedKyL; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of sbhat@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sbhat@linux.ibm.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1656657195-44786 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/25/22 05:12, Santosh Sivaraj wrote: > I don't have setup to test this now. Adding Shiva and Vaibhav who could > probably help. Thanks, Santosh On Sat, 25 Jun, 2022, 1:03 am Dan > Williams, wrote: [ add Santosh ] Kent > Overstreet wrote: ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ > ZjQcmQRYFpfptBannerStart > This Message Is From an External Sender > This message came from outside your organization. > ZjQcmQRYFpfptBannerEnd > I don't have setup to test this now. Adding Shiva and Vaibhav who could > probably help. > > Thanks, > Santosh > > On Sat, 25 Jun, 2022, 1:03 am Dan Williams, > wrote: > > [ add Santosh ] > > Kent Overstreet wrote: > > This converts from seq_buf to printbuf. Here we're using printbuf > with > > an external buffer, meaning it's a direct conversion. > > > > Signed-off-by: Kent Overstreet > > > Cc: Dan Williams > > > Cc: Dave Hansen > > > Cc: nvdimm@lists.linux.dev > > Acked-by: Dan Williams > > The ndtest build requires [1] as the build is currently broken from nd_namespace_blk/blk_region infrastructure removal. Dan, Could you review [1] and see if it can be included as well ? With [1], the this patch is tested, and works fine. Tested-By: Shivaprasad G Bhat References: [1] https://patchwork.kernel.org/project/linux-nvdimm/patch/165025395730.2821159.14794984437851867426.stgit@lep8c.aus.stglabs.ibm.com/ > This probably also wants a Tested-by from Santosh, but it looks ok > to me. >