From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DEA5C678D4 for ; Thu, 2 Mar 2023 07:13:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC15A6B0074; Thu, 2 Mar 2023 02:13:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C570A6B0075; Thu, 2 Mar 2023 02:13:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEC016B0078; Thu, 2 Mar 2023 02:13:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9C0316B0074 for ; Thu, 2 Mar 2023 02:13:14 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5BA8E1A0727 for ; Thu, 2 Mar 2023 07:13:14 +0000 (UTC) X-FDA: 80523091908.25.1C5B31E Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by imf15.hostedemail.com (Postfix) with ESMTP id 0A67EA000C for ; Thu, 2 Mar 2023 07:13:11 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=rWuj+oY9; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=OZOSbFPB; dmarc=none; spf=pass (imf15.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.24 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677741192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kGZk/ZSES0uDeincOVUYwzfC8LsnwfhTz4QhmBeE1uo=; b=3+H1Aoljt2Yb2t9p1xCwe8LxISwev/YNeL6XilIZ7v4OyMHgF8l00KR1NZYU1jnUsSx8Nh k7PV429VtaM7s6QjSgQ6YmbcQfO7g39WzMxWpM/lJ+vy7OBr+7o11ib1b5gBKdfQcfU3O/ Aq1L9xmF3nZuzOLfeLGiqKD6KKySKpM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=rWuj+oY9; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=OZOSbFPB; dmarc=none; spf=pass (imf15.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.24 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677741192; a=rsa-sha256; cv=none; b=7vfVbDhonUsag7W5yivpnTUwfdWEzOIc8+aKbG4UtJVA1GVzF1qDjIz3PbZF/OLLilTROA IOTTQy5cNUSTYFGC9rBvx5+h0p+txfnLB56ImSDWLCO0AsiUL3JXgSrRqkDJE/gxMlGpOr gIC2lVVuAmJLY2R6HH3U8I601QN0An0= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C136332007E8; Thu, 2 Mar 2023 02:13:09 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 02 Mar 2023 02:13:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1677741189; x=1677827589; bh=kG Zk/ZSES0uDeincOVUYwzfC8LsnwfhTz4QhmBeE1uo=; b=rWuj+oY9nZyiLBlQ65 Z2lbPD/6Wc+HW7YZdFLPmSGzFiz8EY7Pptdm4m+a1AW4IpaRxDjSHFLDhKolcqoK vZ5BcM5SczEOStXZ3ziqhulDfXeFmPZX3otZfxOBSbOMsqd6v/LXOutKDdQlMEhE 5vtiRUCc1SGophm87H5r+iJWi0Hl8oC1QEgkd7DJALk9imESHMQWP9JwHnRuDvXP JOdJJw6+1nRL63ALo+U1bl9/RpQJJMVOTZ9PS2J5Khu5F9xM0FzZ7hVgWkhGpoHI Pz5UXm1g6oeFY2Wwu1Y94aCb+nWQG3PhhWuatKDwe/Q/Ue1cVJcJ0YNBKHRoS+fh jIYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677741189; x=1677827589; bh=kGZk/ZSES0uDe incOVUYwzfC8LsnwfhTz4QhmBeE1uo=; b=OZOSbFPBkowy8HYOohMIePdMYe0ca 8pjqNX4CV6DtjahbMVk92ejsYszVZnC0GOR0EzjdWE44eMJg6Pa1umUBJDQeVVZJ B9XY1Y2iEDjrhnp3Xm3AuCjB4tH+MwREq2ibPretWPNSmQPuPDyVtBYqW31/N8h9 GCJUHB+qA1XI5t631UweyWWOenWQ/gXGi1GZzw3eCuNSL5b7cspH3vUhTDjnmgT1 IajsEiO6OmhFfyXd/ZUMMeunX/8B2wjVX5Ytbpjj6nt2yr3VYAU0/ZDAb3N/y72F maXPD1C5wFTBujLWAtJRpUTGmAhWgck6D2ukqoqDNDWBx24bJJZNGNHKw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeliedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 73253B60086; Thu, 2 Mar 2023 02:13:08 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-183-gbf7d00f500-fm-20230220.001-gbf7d00f5 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20230301102208.148490-1-bhe@redhat.com> <20230301102208.148490-2-bhe@redhat.com> <5edd5304-ef11-4607-9189-a07613ecfee2@app.fastmail.com> Date: Thu, 02 Mar 2023 08:12:48 +0100 From: "Arnd Bergmann" To: "Baoquan He" Cc: linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org, "Geert Uytterhoeven" , "Christoph Hellwig" , "Luis Chamberlain" , "Thomas Bogendoerfer" , "Huacai Chen" , "Jiaxun Yang" , linux-mips@vger.kernel.org Subject: Re: [PATCH v2 1/2] mips: add including Content-Type: text/plain X-Rspamd-Queue-Id: 0A67EA000C X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: wfjkciy6i47mnauw6w74kc6nek5moqpi X-HE-Tag: 1677741191-254246 X-HE-Meta: U2FsdGVkX1+sbYOTdPyAF4TYZ8xA9y14XPbDlEg9B7SrlcJGhfrWsm2VqJVJC1cQNbsGt/o8bbmjjrkc+bqtgH1sl2dEQggSLK6Uu0BlU9jnFaCEChPkZXO4dqkGJD8LQ97q69HOmYtfMclmowgVYlugWdT0lZS06vPXxlp5VVUxYUzVTYCfUE/2Sbg1afGZLPkU73nSdOpET/jYFK5b72UGVEOZjVpy4gGhfnhx+shZQv9I2ooSjR0uHm+z3ka7QmnHnZgKu/3ZBu70Uwczz+E7+2nkxORw83bly68W9JvvcscNkoYuqU1v9YdZLeWouQzOOx7w8KX6zlqczUJHXNGVqeAVAw/9aEMXOx2Me6wZBxw5Eh4GJEuSCnz5DbAKWVLLILTqdkzcJqanoKn+FfPsy2RhLyP2VCl9ktNSL0/x/ZveTUy/QVKDMg8Q2w6b73RlxBX8GOiQq/AQxzGOA4YF33AQecT2ACFxz11llXuXH9UYkslxEX+8jQJvQb2nTmXzbvFs490etqlD9MdW6c94nTB2rvBZ3m9K1BtqmpsO741bm+W5nc/62l3h0+b8hyZWK4cgcT8ipbPl91cBXKW2SWzf+eteEyCHOnJX0IGfAHER6RBOFapIPhzQdC0v5o+9VAlaKKRylVWMJpnKEzv23z0QfU3UfPO6S/sNtzyXD32RBsXWalTnHWV7KeJJ7Q0rxfwxQz0C1RpQbUUpunZp+6m+ofHVsfabeJNZdi9iPz3t40PsgbC/+9tYtZNbe646x7RXUscFoB2QTCCPmt6HsSgDausjrXktTk+PxQjZPSbllGJCtKxrPLcxCnF0ncz02ifS5qxlxVGZ0uYrS/BG/KnDf10WM/V3QXdYbk2EtTomrh2e3ius+HP/UvgD1iCE5awzVSmuDsVtbGM0whkP0b1aVyw+rElevg5hmypW3Un/Ei4y22tFX/AYmtpCJOIWe+gtTIWGU/fkD2T 14pgOg0R P4yRZqUjKiTHTJo6Ji9AVALpJYPkw2/PJBjevYwUancN+V6zczybHcn7avTAN7JmJOKxspR1L9H35lobTJcgt1YJtvXh1sggUc9NvCleEwUzXR/JtgybAkkKb2Rops+TYlcJbrQzw7ahau4s9JBGdVq1uwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 2, 2023, at 05:12, Baoquan He wrote: > On 03/01/23 at 03:06pm, Arnd Bergmann wrote: > > Yeah, defining mmiowb() to wmb() directly is also good to me. I tried > to comb including sequence and find where asm/io.h is included, but > failed. Mainly asm/mmiowb.h including asm/io.h will cause below > compiling error, the asm/io.h need see mmiowb_set_pending which is > defnined in asm-generic/mmiowb.h. Moving asm-generic/mmiowb.h to above > asm/io.h can also fix the compiling error. > > ============= > diff --git a/arch/mips/include/asm/mmiowb.h b/arch/mips/include/asm/mmiowb.h > index a40824e3ef8e..cae2745935bc 100644 > --- a/arch/mips/include/asm/mmiowb.h > +++ b/arch/mips/include/asm/mmiowb.h > @@ -2,10 +2,8 @@ > #ifndef _ASM_MMIOWB_H > #define _ASM_MMIOWB_H > > +#include > #include > > #define mmiowb() iobarrier_w() > - > -#include > - > #endif /* _ASM_MMIOWB_H */ According to the comment in asm-generic/mmiowb.h, the intention is to have the mmiowb definition before the #include, though this would only be necessary if there was an "#ifndef mmiowb" fallback in that file. If the definition to wmb() works, I'd go for that one and leave the include order unchanged. Arnd