From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A7EC00140 for ; Fri, 19 Aug 2022 00:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8814C8D0003; Thu, 18 Aug 2022 20:47:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 831888D0002; Thu, 18 Aug 2022 20:47:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D2C98D0003; Thu, 18 Aug 2022 20:47:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5DB768D0002 for ; Thu, 18 Aug 2022 20:47:14 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3703912058B for ; Fri, 19 Aug 2022 00:47:14 +0000 (UTC) X-FDA: 79814503188.24.70A51C5 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf29.hostedemail.com (Postfix) with ESMTP id C879F12000C for ; Fri, 19 Aug 2022 00:47:12 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id s206so2557395pgs.3 for ; Thu, 18 Aug 2022 17:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=lYKXgue+zNpIvfPSql7O+R7TEPDE0QJoKDwJiREWf7Y=; b=Yf1ObBTNqWoadaVv8CCeNUYTVV68c76B6bJj+OWtTMqEm6y9RVLZxi8pXcWODx7ozI ysK0w8bPJ3a3/qEWgxWHSf8bNRPyd+gQ7P8S6Vy+EiuTtxmLhLMP9IGRbIxjif5isELg CkB/mjrtD+rDJdFW9t9OnB0z1vy3zsqUsMw+O7MfuvbBQUojyYNprPOTHqsI050/FEBC 0AUP1wXNqc+Dc8g1iMp63xR65paoeeLq/qNmRaUBSjL51/fm5ViMoCa1vMcMTpN2Hzka HZEvd1RftSYXrbo47FE9XPrlCNrx7zuzMGz7N92/ip6K6zZM5wea7ywlo58ZwoXdj0Nq rIcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=lYKXgue+zNpIvfPSql7O+R7TEPDE0QJoKDwJiREWf7Y=; b=xe+5ljGrGU8vTVuRyBx2BZ84MzUrLOu82plQL/UBYx5N55R7NogQeVfhodY8dBWeUJ Rsa9+MLnRmDukqUzkPCq5ThnkhV90QJEtmAUPeL4RomGTR3R76vukHzOPWKFEvla8yfp TlUTNiwZJ01J05oZc/7dBTbFWDN2YdHRTxYExSZFyouNhMAeUGmhO2bTP4h6ZW+ek+EO A1A2L76YUYXDqWmaYtdSOwhA/r6O5Y4LJNe0ODXIWw3IOLCa9koMHXNgOM6ATSVolIVQ XqZfNCyBxVBgi8ROa6w+UobYsbvTeK5tZR+yfj5YY32n5SkUx/k6zTN3jr1Up+tsm8x2 HfKw== X-Gm-Message-State: ACgBeo0+i8Jjmo+Ju4bNnrzwGKfkb1wqY6JWgRGknqRpk/ycLNSiLEod nvrMFvw3NogQd1wU4Y9QlcMJzjmflzid2A== X-Google-Smtp-Source: AA6agR5Qa8kN5z58ES35WCTjV5f+v9cONWrgP5RrInMX13yzSlj1T9r40gTJhrGdtS/rCxl6RfxTMA== X-Received: by 2002:a6b:3b87:0:b0:688:9085:cae8 with SMTP id i129-20020a6b3b87000000b006889085cae8mr1861996ioa.118.1660842039991; Thu, 18 Aug 2022 10:00:39 -0700 (PDT) Received: from [192.168.1.172] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id bp17-20020a056638441100b0034366d9ff20sm754283jab.160.2022.08.18.10.00.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Aug 2022 10:00:39 -0700 (PDT) Message-ID: Date: Thu, 18 Aug 2022 11:00:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: generic/471 regression with async buffered writes? Content-Language: en-US To: "Darrick J. Wong" , fstests Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org, willy@infradead.org, Stefan Roesch References: From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660870033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lYKXgue+zNpIvfPSql7O+R7TEPDE0QJoKDwJiREWf7Y=; b=qxVdev5GLbxlfUy8ILVgGtTc3mRnWAGR+Iuh49KLJn3+6ht+wTqyoREKPYFUyqN8wALkA6 SLc5FbYiQxfiopNFzHjgpj+Q6s7S7sQOgpFIdLUtTyfkW8H8/jpGZ0AuUj+jBZqAgJnFWd YIPf39JqqBhjWyNUByhfVW5APLWYpWU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Yf1ObBTN; spf=pass (imf29.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.177 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660870033; a=rsa-sha256; cv=none; b=NxZfa9zXS3h1UYZW87WJRVOql/Dbt5JubRr7Bx1+6KANA+WZYVu5twPgbBDpFVJPPNy422 8g19LDE/8KXRRgxnhUZkxC0KkNUVio/qIpYtf3Eg24YbiNJz3okrMwZMbiHqdbzBSzJzcA ycTvRrTKDVmHBC5iwJ7ljXUQ3xPzR1Y= X-Stat-Signature: nbw5mxqwk55dq1b5ps46jxzc89euuodk X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Yf1ObBTN; spf=pass (imf29.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.177 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C879F12000C X-HE-Tag: 1660870032-443315 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000140, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/18/22 10:37 AM, Darrick J. Wong wrote: > Hi everyone, > > I noticed the following fstest failure on XFS on 6.0-rc1 that wasn't > there in 5.19: > > --- generic/471.out > +++ generic/471.out.bad > @@ -2,12 +2,10 @@ > pwrite: Resource temporarily unavailable > wrote 8388608/8388608 bytes at offset 0 > XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > -RWF_NOWAIT time is within limits. > +pwrite: Resource temporarily unavailable > +(standard_in) 1: syntax error > +RWF_NOWAIT took seconds > 00000000: aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa ................ > * > -00200000: bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................ > -* > -00300000: aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa ................ > -* > read 8388608/8388608 bytes at offset 0 > XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > > Is this related to the async buffered write changes, or should I keep > looking? AFAICT nobody else has mentioned problems with 471... The test is just broken. It made some odd assumptions on what RWF_NOWAIT means with buffered writes. There's been a discussion on it previously, I'll see if I can find the links. IIRC, the tldr is that the test doesn't really tie RWF_NOWAIT to whether we'll block or not. -- Jens Axboe