From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14024C02192 for ; Mon, 3 Feb 2025 10:25:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 841EE280012; Mon, 3 Feb 2025 05:25:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F156280011; Mon, 3 Feb 2025 05:25:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61CFA280012; Mon, 3 Feb 2025 05:25:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3EB83280011 for ; Mon, 3 Feb 2025 05:25:09 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B5F794C997 for ; Mon, 3 Feb 2025 10:25:03 +0000 (UTC) X-FDA: 83078250486.24.95F9972 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf29.hostedemail.com (Postfix) with ESMTP id 6209C120002 for ; Mon, 3 Feb 2025 10:25:01 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=kVml5rMz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=51YV7zQJ; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=N33Tb0gP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="wEhrPT/8"; spf=pass (imf29.hostedemail.com: domain of tzimmermann@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=tzimmermann@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738578301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B28xHbzd2hSvBb41dA9gCOLpTarCHR/BaSSB5aXAzmE=; b=slVut7gY8Qy1JnKArAvMjqduufNEvuaLCECZYys20+kZpj/QfQU3bRHwzmJr1vfIB6q/DP XTCLg88sw6yDdW8e0HI2hq0zfnKoxYh0et/iT2RJkcjNYyxYVQF2dpX/Sj2nAZdk9wQ60V X9+8qcGfeXqMn8FYV9WuOyTGErLHlLg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=kVml5rMz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=51YV7zQJ; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=N33Tb0gP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="wEhrPT/8"; spf=pass (imf29.hostedemail.com: domain of tzimmermann@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=tzimmermann@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738578301; a=rsa-sha256; cv=none; b=3UE9wljRcH7Mm08DlIrEwNERA4VJJ3cp0i1kfrCkQyraGY/glMWkXF4aHx/yAIav5tmo+p kQ5tyGRCv2QU1dG00KEMBGl3xscuyvZUmxhFU1RbyaP4WuQ+rKnyKLYzx1NKPXr+tiVN0D R++MHKuvMUP9cdn9HC4savm6+8Z4lyU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ACCC021162; Mon, 3 Feb 2025 10:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1738578295; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=B28xHbzd2hSvBb41dA9gCOLpTarCHR/BaSSB5aXAzmE=; b=kVml5rMzwj6Mwq9nkEEWgZMd70SwGi4dGGX2F1clbb1ObPWby+eEBTKskLNoWPpm5Db2xs 8J0HuBIEPKMtTHh1eifC2GU2bVWgGd/JXZSpOph4lLn0hSEx/NZC8aT4dqOokWu5BWfbnX 9HokWVvzjJDMkolC84B7+8D5y8bExkc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1738578295; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=B28xHbzd2hSvBb41dA9gCOLpTarCHR/BaSSB5aXAzmE=; b=51YV7zQJ9lvtzsnAC6WL9iurrxUXkpIVdxn83XCCXL0dxy06DdRml3YsvjQ9Cr3VfY7dZW TX2kb068i7xywrBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1738578291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=B28xHbzd2hSvBb41dA9gCOLpTarCHR/BaSSB5aXAzmE=; b=N33Tb0gP0bU8paofonS6m9YOkE0SPwjgxH1Oovu7uQPdR6nN4Ei/eQHVj1/kpaXQRI9i+S tbP078ZmOz5p4w8rjBf/fiEA+ZBftKovD1jK+LiNcuJXFsGB1bylBdKrg8aGL855VaMsww oPOH3wI0CUUgAUGi8xC02Wme5gEBTGw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1738578291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=B28xHbzd2hSvBb41dA9gCOLpTarCHR/BaSSB5aXAzmE=; b=wEhrPT/8SahloHtQvQQe+m1cdpJzkUxSdeYNUl1EFQMx2kfrapHMllBpSP8Q6cvG732ZTZ /3RHYh4X3fS75uDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 529AA13795; Mon, 3 Feb 2025 10:24:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IMHVEnOZoGfpcgAAD6G6ig (envelope-from ); Mon, 03 Feb 2025 10:24:51 +0000 Message-ID: Date: Mon, 3 Feb 2025 11:24:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 0/3] expose mapping wrprotect, fix fb_defio use To: Lorenzo Stoakes , Andrew Morton Cc: Jaya Kumar , Simona Vetter , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , David Hildenbrand References: Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6209C120002 X-Stat-Signature: acqng9sapf1s6f3x3mq9agyctd54h9hu X-Rspam-User: X-HE-Tag: 1738578301-690596 X-HE-Meta: U2FsdGVkX1+Ci604T7JGDSRne5qBdkO6ixDtpwubd9FC5HltFM0DRazzRAPKUIbmn0xRcrSwIocDrdJ10sU5Z0w4+8PwZc4R0MMCnoLOeYIQIMzr9A0iQfKB4QJnOmOl5BQutTzFffO/ZWn8xaQino4HAjXDwqEfoR0CYE2yL2SGdtoyvrZWLX9Mxhy+JdVRMfS219em8fFoH1dusu5GXvascH0x3gHf5tGlKYyVGZRlONGXinvnG5h59ShCmhFkT61AKinSjcmhJh5ATcwN8WrBd7EgLDnT1Wo9tslsdkLEHVC996Sd/96tJXzIvRkQXhStVljBAjmth2m2m9nZlBXfKOvUW37UlwjfvGWedcrzw75iJ0vBEMxI76eZa1BAOxY8HLAGwcbURwrQ4xW3z4ny+rLbm7dPYUkRFdEOwQDgw78s/RvPYimrjvoUP4NkqB/Je4syJ3KBcBLFz/QmZ8aPMLTL3kUR62jx3qPsDeFdqjy1Yss7iZ63RNm4+lSd5+GSNFuFuA59qFiKXW/bpSkuWeV948Ipl4EHPFzjhsqYTY2Q0KDI8V57pE30/0QGTJv6ZVmREGHQ76IiDnAJ1qmAwMovZ+knMpJT78fAgOZXkBC1b5nm3hXohQGPEiJLUXZRzuplZTdHTxNB47UBkSdFWfco2am62zhNXYAsXFt0QZaKeo98Nh/eDDkr6sddNqdwRDqiF+yGcfmmT+7Tsf8FDGkdG1oVUEZwkoXT3m1aFsTmKM5bgUWpefABRm0Kwk6LJUvBgKf8oaVQtG4sD7yCAjaKqZCxMuKpo8Sd43pYkaa6bO/4FSyVCdO8ZRczJ3Mn891+0Widjde4ki+haUESvyHwKkTJsZ+Bsf40Fd1pLQFnBXiCjbQKlTk8Q+A3z+IH5zxkQ8kV/ZlbDf0kQTkbIGaSmtV0Ii9ZbrMUp93PYEiIxdIfzZlIB9TDsLaO8knJG2aljlQ0ZMbpXae +b3R5t4v 2mwVSAXUv1A5dHH5B/yRxLoxzdEprw5DBTU99QsKMx+i0J8lraCtLdGUkTL6kT8jmdxXuP6f9XmgWErSrVC1CngZczojTc0W12xy6KEOybSuzjXkWfwAqF/SQZK+8NN8nqnapB7D3aFHfW866hsxgksj1+XMM1A6e4xVMaR6u5n1c6G6sptbru9UiSepNLR7aKGK5tN+WV9N1R3woTjN6tb+guRkf0TxQ5h9FDHggkZUue8qRYf0CKUt9igtFuCbceVuQ+P5XR+XEVMwmmEMRZbtPo9hjrnMryn9GcN3pcTlS7TSk+lkB0WmGuviCfTCp0bJ/nJ9qTYK2q4+QgquhjHkGXm4H+cVQkx6kByU8nTsSJt8oDzuJ+nAgbQdc4QgboLeU9CWm1JRiPxvSobJnmrW145Kiabmu5hB5pY7UYqWm3FTmdCb5ewb7piPG8BKLZ9WzJEwRIc3YHGozV5tIE9gkNLy/rtyOC8tt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Am 14.01.25 um 00:15 schrieb Lorenzo Stoakes: [...] > > *** REVIEWERS NOTES: *** > > I do not have any hardware that uses fb_defio, so I'm asking for help with > testing this series from those who do :) I have tested the mm side of this, > and done a quick compile smoke test of the fb_defio side but this _very > much_ requires testing on actual hardware to ensure everything behaves as > expected. With a recent Linux distro, you likely boot up graphics with simpledrm, which uses fb_defio as part of its console emulation. To test, boot the kernel with the 'nomodeset' parameter and write to /dev/fb0. Best regards Thomas > > This is based on Andrew's tree [0] in the mm-unstable branch - I was > thinking it'd be best to go through the mm tree (with fb_defio maintainer > approval, of course!) as it relies upon the mm changes to work correctly. > > [0]: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/ > > RFC v2: > * Updated Jaya Kumar's email on cc - the MAINTAINERS section is apparently incorrect. > * Corrected rmap_walk_file() comment to refer to folios as per Matthew. > * Reference folio->mapping rather than folio_mapping(folio) in rmap_walk_file() > as per Matthew. > * Reference folio->index rather than folio_pgoff(folio) in rmap_walk_file() as > per Matthew. > * Renamed rmap_wrprotect_file_page() to mapping_wrprotect_page() as per Matthew. > * Fixed kerneldoc and moved to implementation as per Matthew. > * Updated mapping_wrprotect_page() to take a struct page pointer as per David. > * Removed folio lock when invoking mapping_wrprotect_page() in > fb_deferred_io_work() as per Matthew. > * Removed compound_nr() in fb_deferred_io_work() as per Matthew. > > RFC v1: > https://lore.kernel.org/all/1e452b5b65f15a9a5d0c2ed3f5f812fdd1367603.1736352361.git.lorenzo.stoakes@oracle.com/ > > Lorenzo Stoakes (3): > mm: refactor rmap_walk_file() to separate out traversal logic > mm: provide mapping_wrprotect_page() function > fb_defio: do not use deprecated page->mapping, index fields > > drivers/video/fbdev/core/fb_defio.c | 38 ++----- > include/linux/fb.h | 1 + > include/linux/rmap.h | 3 + > mm/rmap.c | 152 +++++++++++++++++++++++----- > 4 files changed, 141 insertions(+), 53 deletions(-) > > -- > 2.48.0 -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)