From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF59C433EF for ; Wed, 8 Jun 2022 15:17:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F8C66B00A9; Wed, 8 Jun 2022 11:17:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A81C6B00AA; Wed, 8 Jun 2022 11:17:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 750886B00AB; Wed, 8 Jun 2022 11:17:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 63DD56B00A9 for ; Wed, 8 Jun 2022 11:17:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 32AEC80F7B for ; Wed, 8 Jun 2022 15:17:04 +0000 (UTC) X-FDA: 79555421568.02.7FD5B96 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id A2ADFC0078 for ; Wed, 8 Jun 2022 15:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654701423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y8H9jGB7E9Z50aLgeVMMhOdyAwsTkxFP1izvYrfhgfg=; b=RA8oGHf3moQi17BWYwf+nWOSbdXxkWLU1z+KxxJKfioDm4TnD31H5yjm4stQ9zzcddQuNY fQf3cX/y1evtP7kCwRDENETKn3gNGtmZfDaEvyvRS1J0Q0JT85VlshEc7OOEX+wNpzvYCY 24nm6TIDSXFAZE5ZE3kGtNhL33G8Kbc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-483-gTfRq0x8NXe8LljDPUh5kw-1; Wed, 08 Jun 2022 11:17:02 -0400 X-MC-Unique: gTfRq0x8NXe8LljDPUh5kw-1 Received: by mail-wm1-f70.google.com with SMTP id m19-20020a05600c4f5300b003974eba88c0so10003603wmq.9 for ; Wed, 08 Jun 2022 08:17:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=y8H9jGB7E9Z50aLgeVMMhOdyAwsTkxFP1izvYrfhgfg=; b=pi7HbIlkQFKD4/hL/1gx4QxIZvrBzttKAMpZbclI1rTFfd8PZTHn9WTsJnW3auVPmY wFllDnwIj7g0/eu2x/jS3hTqJ9Xk/BI/2GXxnjc8M9hdm1PIosSPfVcgFO2m3L7D8aow bjSMRNQRPycEFwpmtKu0EOk7TwtEbmwbW73lI3TaIFt4zypvKNMGcZ9yWkGUGCZgb1YK 895vjew4o+glMzMuiY/4FDd3jgCg7BEM+UJJC91CSA6Xa/rr26Te/Tjbd8NHD7fIrhBs rFzVloQI+CRMZw3OloxJsiA6N5eD7aaDv5g6/DmxL+zQ91Nk0wZM5uXUWn/JnjOZLHBs En7A== X-Gm-Message-State: AOAM532uQdGPvNzz6tggXqAXbBZpZoO+7stYaEQcivj2eKPmEhWyKMN5 wfv5USmue+FOWnXVqIBcz3QREfrKDwz3VacSTmPN0l0DqymyyxmfbnrHw3uO0o5dgAxlgweKXDl XqpBpgPX/ZSU= X-Received: by 2002:a05:600c:3ba6:b0:397:5508:652d with SMTP id n38-20020a05600c3ba600b003975508652dmr64645337wms.126.1654701420810; Wed, 08 Jun 2022 08:17:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzACjV0q1j/MZdf3myhyht9jNflmTjecKJCZdzLXqgYUj70QjsvLN+eY19mHafUixzLazP+zw== X-Received: by 2002:a05:600c:3ba6:b0:397:5508:652d with SMTP id n38-20020a05600c3ba600b003975508652dmr64645310wms.126.1654701420494; Wed, 08 Jun 2022 08:17:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:ad00:db2:4c6:8f3a:2ec4? (p200300cbc705ad000db204c68f3a2ec4.dip0.t-ipconnect.de. [2003:cb:c705:ad00:db2:4c6:8f3a:2ec4]) by smtp.gmail.com with ESMTPSA id l13-20020a05600c4f0d00b0039c55bc2c97sm7819484wmq.16.2022.06.08.08.16.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 08:16:58 -0700 (PDT) Message-ID: Date: Wed, 8 Jun 2022 17:16:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 3/3] mm/swap: remove swap_cache_info statistics To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220608144031.829-1-linmiaohe@huawei.com> <20220608144031.829-4-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220608144031.829-4-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RA8oGHf3; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf28.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: 6jknmfksyfktq5h4uj5z1wigq5q8an61 X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A2ADFC0078 X-HE-Tag: 1654701423-274675 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.06.22 16:40, Miaohe Lin wrote: > swap_cache_info are not statistics that could be easily used to tune system > performance because they are not easily accessile. Also they can't provide > really useful info when OOM occurs. Remove these statistics can also help > mitigate unneeded global swap_cache_info cacheline contention. > > Suggested-by: David Hildenbrand > Signed-off-by: Miaohe Lin > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb