From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE539C3ABAC for ; Tue, 6 May 2025 09:16:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B17146B0088; Tue, 6 May 2025 05:16:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC74E6B0089; Tue, 6 May 2025 05:16:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DC046B008A; Tue, 6 May 2025 05:16:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7EA2B6B0088 for ; Tue, 6 May 2025 05:16:29 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 619C4B973D for ; Tue, 6 May 2025 09:16:29 +0000 (UTC) X-FDA: 83411927298.04.076B153 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id BDD7D14000A for ; Tue, 6 May 2025 09:16:27 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746522987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xlLOCeZNV6OWR+CgkAQMmtFnz2xxho4/KNVauJ5MheA=; b=JNgbUDSp3GqHaEPv2ZJyCF7+slzGh6VkCiVHw4dIiRFCqULeYAFpqi4qMK99kXfuKSG9h6 u1PhPPp3Ss8rCFqK2tW+Gm+EQxv2WuqqyznFf8Cjdw3f9fmB96CCkbEVu0KeHqrjCRHRru Zyie9JIOqJgHi+tGx3pQWeaal6zeXzk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746522987; a=rsa-sha256; cv=none; b=y5+TidWTXbfgLyfzfnOtV66ehIU9NHWUivZKXzVgW/vJfR6u3m3UtHPbnrqVZIlOSUaFtQ ER/rEnO7E+MbdfleWZ05OCprWkNEn6TZFlvTJS5onoftFNCwlORViwczR5a3dY0XNK0E8R Z8imX98thev/sMQ8MRYw1UHryUqKxG4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4569F113E; Tue, 6 May 2025 02:16:17 -0700 (PDT) Received: from [10.163.54.208] (unknown [10.163.54.208]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8FC403F5A1; Tue, 6 May 2025 02:16:19 -0700 (PDT) Message-ID: Date: Tue, 6 May 2025 14:46:15 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Optimize mremap() by PTE-batching To: Dev Jain , akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, baohua@kernel.org, willy@infradead.org, ioworker0@gmail.com, yang@os.amperecomputing.com References: <20250506050056.59250-1-dev.jain@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250506050056.59250-1-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: y5539k3yj7isx9jr6kgxzkqek61iyofh X-Rspamd-Queue-Id: BDD7D14000A X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746522987-260975 X-HE-Meta: U2FsdGVkX19LMgz9PA+w/1LQ5vwstqPm6XzBf5BzzPAPvSYZSMZSyteJQZdZljgzmQTYvAh9Y4fVdPjxP3Vszh3o5YuWRDy5RkHcNoLtYsu+TEGSjqXtWetYfmV1nDQjMzLZ1I9kWptzM53YcF6bh8lR1V0VAXFnAGOxs4/7gp8BBnL/RyB4fL6IUrCIjK4cseZZvh/99hSZZn7GPscJsZJEEfjDdPvFGH4eS6702iVFD6dXxNzhaj5gQMbolNapN9q+OAE46xeP2qzwRFIxQ2L6DMBpQ1pDKRA1qBu1wO8jbnqrLt7PXvM+URtTNsmxIMoxjLzt6pZPHyVhYl07GYRs2k0/c/HceRxaDUR0XpWdc/uVyq8KNsrxWnxMI+RLwetHkQAow81eHp/QJGU1NhxLvcUGBXYIdhUTVR/Dqr9QV8OR+WWoWDtE2RsMViV0kWQ9ahh/B2jpWA2Oy/euj6nmANqVcGt00l/N53lYNJ7Xfh4d1XYFrLzbckbatf5Hx64debPH9QC8oBJASQlg7t3+a4sJCZ8hthAwYn0c9v5CCB+tKH1zx8ZS4dpMzLKpv6D5W9IWKDYGrKHaQSnohTT70bwozQiM3X517MKteFBa7Eovb62pD059iPVZ5S++ZF7b4qoWIWX8qx+wzL97w/8mAT/nJKBunfjGhXqs8hkdAD7j/Qp/FdRBpk/O/FZfljGjvXgRqnIQtnGP2qY5+CMq3fV2aA+LnB6TkF0r06xTEknHd2daHZ7Rt/z1QRXOW16xswy2/nWIn+tb9i7yH0TUi+beN/zBGxbbaNSqrX5u5sZfmzlOlMTI1I3Zy+VvJY5UlNmTcIO66php7nMAi24eo+oj8q5sjBihJgkDTQM7k+OqgiV4sLJAwNUBGkNiwFcrD+eD8LZUcRrZmZxrsNAmrSI6qxXS5E/1CL9m5fcuHW3mzzXn+FZ9eYfxC8DvgOWcEFREfIzZ6EfmuBB uJuuWVkL KR3vUk8s433nj8eRrieCqQcDoPb0e3VGUBTQS9Jh0CHCmSnz9e0L1gUySTjEfYEf6OxFSnYzPv03Wyds0VRPbpH8576fkRoFLy+/Xq3MWUVJ4Nzv6KDjkrW+Kcl720egBENXBJwPtREgm7ygNWF0P8w1tkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/6/25 10:30, Dev Jain wrote: > Use PTE batching to optimize mremap(). > > Mapping 512K of memory, memsetting it, remapping it to src + 512K, and > munmapping it 10,000 times, the average execution time reduces from 1.9 to > 1.2 seconds, giving a 37% performance optimization. (Apple M3) That's impressive improvement. But could you please re-organize the test description into a pseudo code format or better provide the test program itself (which should be compact anyways) just to be more clear about the scenario where this helps. > > Dev Jain (3): > mm: Call pointers to ptes as ptep > mm: Add generic helper to hint a large folio > mm: Optimize mremap() by PTE batching > > include/linux/pgtable.h | 16 +++++++++++++++ > mm/mremap.c | 44 +++++++++++++++++++++++++++-------------- > 2 files changed, 45 insertions(+), 15 deletions(-) >