From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF40E728C3 for ; Fri, 29 Sep 2023 16:03:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C10368D00D6; Fri, 29 Sep 2023 12:03:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC0C58D0023; Fri, 29 Sep 2023 12:03:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A626D8D00D6; Fri, 29 Sep 2023 12:03:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 92C4C8D0023 for ; Fri, 29 Sep 2023 12:03:13 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 598AEA04E1 for ; Fri, 29 Sep 2023 16:03:13 +0000 (UTC) X-FDA: 81290104266.08.FF779C9 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf14.hostedemail.com (Postfix) with ESMTP id 8E3AF100030 for ; Fri, 29 Sep 2023 16:03:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Rhux69uz; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf14.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696003390; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AxxOYCOcBAEgIYF5ux4H97KiIA06kyejBb/12t/8jPY=; b=v4y9rwrNbb9rVTN+qxSTwz+6HFGhcBwLwzK3wjEvB8y7z1jloaEapNhnkNl4V47oKq1icQ +95Gq99zJGRt4mJAxqKmRxSQ8sOVnDv5Y2bY1k381yKwfH3kfYOE0YdKMfOUvutE2fxxfb htgJZ0KMeA05l/Iu2tqLydsqYgHAsbU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Rhux69uz; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf14.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696003390; a=rsa-sha256; cv=none; b=joCzsshnH4bIfOhT+VSOAQSaovHRIDLX5D5Y3pxBUwkigVyvZ6vsMcnbpsIX5lLB6dY10H P+0aeL1rLeCQSLUX6CMzMdXSOjPQqWSy/QJiz0UF6kPn2S7BvjqNMoY0+Dmnxoj1mbrXuD hg5KcYw3LvPrgHu0fcrto/w3Q/hqRMw= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1c746bc3bceso1695545ad.1 for ; Fri, 29 Sep 2023 09:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1696003388; x=1696608188; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AxxOYCOcBAEgIYF5ux4H97KiIA06kyejBb/12t/8jPY=; b=Rhux69uzWLYJkwEus8MAaa9nBiCQBm2nxqqdnDC4HD3L3oNcXBJaMNaRkvjR8oEryf BJhlGGcWLLfQHIHdZDHNS/hqV/jn3NWyIIZ0PuOMnAO8rFAFYaaUomYzxFbORkrZxPkq aOdgkFDKMU6eYoO+Un2ipw9l6Q27pRpwuwO5fJfomXnS2KZeaNYdObgUELQUEj72ZFzJ P4xEO4gFVQ57FXisXx0fMtYoMgWx4jZCMNg+TVUfQNWliaxin0Vqcqe9O55jtMBM3opz 5fomRlVNLa1Mvbd1+/faucuiySuIcOFA+FgCXRvxCsBRV8PmkF5N2ub3NlmQegnFukrs c2kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696003388; x=1696608188; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AxxOYCOcBAEgIYF5ux4H97KiIA06kyejBb/12t/8jPY=; b=kmDggr5aA9C6G71RJOFJpVqzBPJ7XBH8EI1G9GWTWlUsr5jk7Ej3tzu1nT8FbNqe7l I8ZrgovSeLkpifz9AD7qEWDp4n65EhaEoAsP9xt9//fTwmMKe+syqLOeZy6CQKQ6kq5A caXQ571yFud58m2HYcC+pVIMm97spu8hwD0RFPqQzjpeDVnzPMZKSDhrjSNIXKRYSFzw OP+tlQPYTGdP0U8oDWzLxOOz0CIyBnon0doIHe2ANmLEqf95MqGl67B4UJ0bzRmt5844 ebi9RpH+S2PirAvj8vwz+tYIUIk1skyXx1/Bzdd4EsxUyBnahkxd+Y0yVKzoUmVmC1js uQRg== X-Gm-Message-State: AOJu0Yyu8hH236ex/+wDDMJjaGe0s0VXJLCPHOizcHwDfHvZz3bmaenz 5rOrvybeCM/Cx057f8URbsjR5FUMwAiB0MLI50M= X-Google-Smtp-Source: AGHT+IEo9c0Z9thjc2US9kqnZKG6QU/rq3sYw4vNZkJK3FsntPQRNPSF32ptUAT1/+mOb360STF/JQ== X-Received: by 2002:a17:903:22cc:b0:1b8:2ba0:c9a8 with SMTP id y12-20020a17090322cc00b001b82ba0c9a8mr4669460plg.2.1696003387929; Fri, 29 Sep 2023 09:03:07 -0700 (PDT) Received: from [10.5.77.75] ([139.177.225.231]) by smtp.gmail.com with ESMTPSA id x4-20020a170902ec8400b001c5f62a639asm13265774plg.196.2023.09.29.09.03.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Sep 2023 09:03:05 -0700 (PDT) Message-ID: Date: Sat, 30 Sep 2023 00:03:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [linux-next:master 8008/8345] mm/shrinker.c:100:1-7: preceding lock on line 83 (fwd) Content-Language: en-US To: Julia Lawall Cc: Andrew Morton , Linux Memory Management List , Muchun Song , oe-kbuild-all@lists.linux.dev References: From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8E3AF100030 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: oo9b3bfmj4ksjdc5xkcfmw9mhmj1izcc X-HE-Tag: 1696003389-665713 X-HE-Meta: U2FsdGVkX1+bDfSjqdeEZn5E8J48IBDuC4TERI5WiVE1LfrzudeESS6NDyfGwRaMrl0EMT6E+RS2GGO7l00vh3+kVKO8sjQgschXaYTs/Kcncr1QIgk2PbxlXOx9K8jXdb1VFfVnbvk/ouzcP0F5mpV8E1JJkxyDyEPEw6l/vfTp7wLHu02aM3vpwlL46tFYCxpp54gLyysX0cLmgiZ3yykjXfo1tX76ZrMvhbzZwYVDnMeNrfaarMzcJBeQiITRDQEX6S1ITnOSjgnPF0cII39Y8YsH0SBWmyP6ZbgOcsGm6K1y1Ua7HsznlUpchDSaoxRCuuswyNWzMOoouQStJcvR1/h3qW68kc1DCMQNgi1PJEfcayglK3N2pjvl+21B4IZXyeDNmkpo/q1xQElJPMC2+koLNFb9ZfVneubHguQ12v61FseXBsExdHXVCE9weYCNbrvu5OJI9yJbgM4eCWGU0CmdY9GO/3l+3FJVIblt7+pUinFJG2yVFvFinp0vC69Y3Hy9I0FAtlBakTCjgqNaI2vbdODUuFgfrSdlsizba01+JwOJKuSzTX63uvdkU7m8OJIxYtuElzSFEqvUlJUmdgzQtB9wVoqlKfQYooas2pMMn+whSvXO90E+sxHHKovr6PJdfnP9f5UAwdBV70XuvZmoJhc1icnxlOPdVNg39E4GOf9/Ar/jLMvfEr0zVZdPi9Dygtyn6WXba7aoPy4JRwtYrAnnBT9XvQzqO4qH+l0kovssfBA+MiJPv3zkO4LyhsjNQ7iXmQ3ZE/yNV6+jX/JUk/KJCUStCs/pAxy5qSm6kZZpGoNBHkANqM1AvZSJyGddw0U7R/BuETZr5qkII1C+Fm79IpdEGneDnYwuAzfxOlez7MPCSc1LNyQzHayheeGrOxqQb88KRNYKzI5qv1CQbJcSrTr/zPRUHLuc73gg4223tf9ICT2y+ZMKK3R+6+NSqSI39SKmhjG PcagR5qM j683mv2EBux6jhO6/WfwgH5K7cWIbMlcWxV5F/tg6xmzVva9bChaUMi4NSP09RFqQzPGPpgybsPwRRSjrpWXv/V6LPasFF4M9gWvi49dxo2f+O/T8Sy7mUZNVb8Z38PwDC3KU+ZnKnfhXl4wBzhf9x3JupwmsIf/EJQFluL48zr1T/xFZfXubEMapa67NsotpNOSMMtaaZ+FuDE9DgZDtyq4PIKILlo12dvhHbW8gnLuunEX1Mba8Q3QKmxHXt5RL7WVzwIkuC+9vqHSV7WhWcLuUsxvxB3W6r0+MKgPvnIczcve5XWGM0C6tlBUkAqBs40FNmm8v/QnP2rP/SwWTHUmrsd1gXt0rH0NQe3yBAFXNmfKS41SG5nhUkFkMuIFRaOxqm28jCuEgZwfs+xHctaI8eOMWClYLvBiuQu25Zfpd3pFvmWYU2zEGVtLiTvYrRG3AWC9+YuahjyNG86qyGeup9n0S3IFf2ldxPlt/cZplvlSN2cpehBQb0Cs8Iy6ogTJukas7qaysjhb3l/D41W9Ok7y8K1hOzc/73geM5XfcHQQ730Hk/o4nuzkqDWwxfiGWqfVJGXPuYUfuHMfXlw3L5pKsDrem06FUQ9Op/xKccx8vPveoVnUT23GtBFVYEP8xjmwzzDz32LKDt4Sq1Y4oatI6TmFhxY4pA2f/gukDvSl256x4iteU9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Julia, On 2023/9/29 22:33, Julia Lawall wrote: > Should shrinker_mutex be released on the error path? Yes, and this has been fixed by https://lore.kernel.org/lkml/20230928141517.12164-1-zhengqi.arch@bytedance.com/. Thanks, Qi > > julia > > ---------- Forwarded message ---------- > Date: Fri, 29 Sep 2023 21:31:25 +0800 > From: kernel test robot > To: oe-kbuild@lists.linux.dev > Cc: lkp@intel.com, Julia Lawall > Subject: [linux-next:master 8008/8345] mm/shrinker.c:100:1-7: preceding lock on > line 83 > > BCC: lkp@intel.com > CC: oe-kbuild-all@lists.linux.dev > CC: Linux Memory Management List > TO: Qi Zheng > CC: Andrew Morton > CC: Linux Memory Management List > CC: Muchun Song > > Hi Qi, > > FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: df964ce9ef9fea10cf131bf6bad8658fde7956f6 > commit: 3b0ec351e30dfbe71675deb22da8a9fe1894c87f [8008/8345] mm: shrinker: convert shrinker_rwsem to mutex > :::::: branch date: 9 hours ago > :::::: commit date: 3 days ago > config: x86_64-randconfig-103-20230927 (https://download.01.org/0day-ci/archive/20230929/202309292114.VMjkyBBq-lkp@intel.com/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce: (https://download.01.org/0day-ci/archive/20230929/202309292114.VMjkyBBq-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Julia Lawall > | Closes: https://lore.kernel.org/r/202309292114.VMjkyBBq-lkp@intel.com/ > > cocci warnings: (new ones prefixed by >>) >>> mm/shrinker.c:100:1-7: preceding lock on line 83 > > vim +100 mm/shrinker.c > > 2babd0d6e9cfca Qi Zheng 2023-09-11 76 > 2babd0d6e9cfca Qi Zheng 2023-09-11 77 int alloc_shrinker_info(struct mem_cgroup *memcg) > 2babd0d6e9cfca Qi Zheng 2023-09-11 78 { > 2babd0d6e9cfca Qi Zheng 2023-09-11 79 struct shrinker_info *info; > b6884b5f15cf5a Qi Zheng 2023-09-11 80 int nid, ret = 0; > b6884b5f15cf5a Qi Zheng 2023-09-11 81 int array_size = 0; > 2babd0d6e9cfca Qi Zheng 2023-09-11 82 > 3b0ec351e30dfb Qi Zheng 2023-09-11 @83 mutex_lock(&shrinker_mutex); > b6884b5f15cf5a Qi Zheng 2023-09-11 84 array_size = shrinker_unit_size(shrinker_nr_max); > 2babd0d6e9cfca Qi Zheng 2023-09-11 85 for_each_node(nid) { > b6884b5f15cf5a Qi Zheng 2023-09-11 86 info = kvzalloc_node(sizeof(*info) + array_size, GFP_KERNEL, nid); > b6884b5f15cf5a Qi Zheng 2023-09-11 87 if (!info) > b6884b5f15cf5a Qi Zheng 2023-09-11 88 goto err; > 2babd0d6e9cfca Qi Zheng 2023-09-11 89 info->map_nr_max = shrinker_nr_max; > b6884b5f15cf5a Qi Zheng 2023-09-11 90 if (shrinker_unit_alloc(info, NULL, nid)) > b6884b5f15cf5a Qi Zheng 2023-09-11 91 goto err; > 2babd0d6e9cfca Qi Zheng 2023-09-11 92 rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_info, info); > 2babd0d6e9cfca Qi Zheng 2023-09-11 93 } > 3b0ec351e30dfb Qi Zheng 2023-09-11 94 mutex_unlock(&shrinker_mutex); > 2babd0d6e9cfca Qi Zheng 2023-09-11 95 > 2babd0d6e9cfca Qi Zheng 2023-09-11 96 return ret; > b6884b5f15cf5a Qi Zheng 2023-09-11 97 > b6884b5f15cf5a Qi Zheng 2023-09-11 98 err: > b6884b5f15cf5a Qi Zheng 2023-09-11 99 free_shrinker_info(memcg); > b6884b5f15cf5a Qi Zheng 2023-09-11 @100 return -ENOMEM; > 2babd0d6e9cfca Qi Zheng 2023-09-11 101 } > 2babd0d6e9cfca Qi Zheng 2023-09-11 102 > > :::::: The code at line 100 was first introduced by commit > :::::: b6884b5f15cf5acf6886ec0704d799035477ad7e mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred} > > :::::: TO: Qi Zheng > :::::: CC: Andrew Morton >