From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D36CD4848 for ; Thu, 5 Sep 2024 03:08:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C83296B0406; Wed, 4 Sep 2024 23:08:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C32376B0430; Wed, 4 Sep 2024 23:08:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF9266B0431; Wed, 4 Sep 2024 23:08:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 928496B0406 for ; Wed, 4 Sep 2024 23:08:36 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 44E0AAAFFD for ; Thu, 5 Sep 2024 03:08:36 +0000 (UTC) X-FDA: 82529201832.25.A11A6A7 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by imf28.hostedemail.com (Postfix) with ESMTP id BBFCDC0007 for ; Thu, 5 Sep 2024 03:08:32 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=HO0RoLPt; spf=pass (imf28.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725505637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jV2+cn/4uNfPspURtuX++pQoMUnXb+at2wi4UK8kjLc=; b=EkefFSAC0LLHK0Xy+fodfA2As8t+/KPMgK1goPgz4EsUwDW5lkZo2ufT92G2ppFJFOJzfN IclSDZhIOJjkx6YI40uh5ZmObUne5v/rsJ+7q6U+8B97Bi6mZvGL1TOXGqSNWnlskfFoTo BWN7dsuM9V39POavnRxGBlhsnqxJB/8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=HO0RoLPt; spf=pass (imf28.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725505637; a=rsa-sha256; cv=none; b=w9of1hnFoFwtPh+EQEglivwWcHN0+CgNqvsJWdVvR8IyTvSkEagaGgwQ1HCv/TDW1Lg3PF yur8mJ0cvIgxA0KpRwUBY8ZOsAuo6xlENqzcbZK5DvzlpgngIyomUuNAX7ctJiV58whsIp 96N8gjEhFH/A7BIzhbFM/hrd5DrozUY= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1725505704; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=jV2+cn/4uNfPspURtuX++pQoMUnXb+at2wi4UK8kjLc=; b=HO0RoLPtq1OPCGowW32Xc6MlKKCesvHDPhWKVImWE+7yjrDUzrPFdhQoQVxN5YnFF+szf69QTUN5VhC5eeLo3nXCNfBqlD8ZL7l7FTshxqMzocJph4CCysmNWnhd1PhI8q2b1IdrqSMmhEEyK7qN7ff/q8vpQppXHi0ebfklu5A= Received: from 30.246.162.144(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WEJd1a5_1725505701) by smtp.aliyun-inc.com; Thu, 05 Sep 2024 11:08:22 +0800 Message-ID: Date: Thu, 5 Sep 2024 11:08:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 2/3] mm: memory-failure: move return value documentation to function declaration To: Jarkko Sakkinen , bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20240902030034.67152-3-xueshuai@linux.alibaba.com> From: Shuai Xue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: s94caca3jdnzgjxcmki9y6gaetoyts36 X-Rspam-User: X-Rspamd-Queue-Id: BBFCDC0007 X-Rspamd-Server: rspam02 X-HE-Tag: 1725505712-447592 X-HE-Meta: U2FsdGVkX1/QO0Kht2+53OoGM2FhDRvdaxgLVfEqhX4qkBw6c+kcTm5Xs0tRVjdHL9zhuif1fgOwAqCc1yEseUYQaIVk40vz/0NDfLZNBJzjQTXud+tz2mEWUfCtaLwpnsNR7iyk44hn7Fvu9lKMJymmsXFu+y+/iZEIAuA6VDeY+HhoMnvtUa0V5Q8hf99mD8hyXUZ7IF2uGV7pebpcAVkwwhOkQFoG5Ftgcuoj7Mo3pzDGl3ss/1wqEoZ6volj2g02CRJdbvCjzHuFFp4H82EVUsrFCTIqMrxRGWCxLYhdoj4oCXw1aA9exIKDm9XLGcJS79z32WsiVcPFpkiH/z/D4ZI0cjx3gjWa1RdIEtM2CUCBzmpQWjQClg/gezWcgcFZXro+x/9b/KEeBJS1201KMJ0Fn9GD1zts939QzZ5WA/LGmFTiaN3zPzK0c3ecU0k9JVVAH8pU9EUQJwFXjoEcWjJ9QCvF8l4yoCajujTnBuEyiucaNFOGllDEioSbVsTDrCItM8Jcugs1BcvvTyvrmySPVNqcN9ku29YCiCSFPrMKba84zXmAsIAdAL+9dKPdR/YAUnq5mXjcMYYWN1bALS8J7BwmFJ/PpGFJIQmdFyHlHSrrRLtWC/kecZjbzrfpdwuuEKGjSbxpoIsLeYE/4XYi/hPDMaQMBgBsIY9olV1jiaOFoOfKVJNabdzVz61nvY0kaKaOMKKdfzPP7BEApWQJyr5twmO/ZGYYJUufCaJnlo2YAo1jLBCiC9tPN5MuU3EMUMfkjbfwJZxK23tZ1C8wi30ObwMzaTkl8uZd8JhvEQN0VQIeOwRw7KJtlho/taIHd6pxFEGWz99vbHV/eLoZMZXy22WB7qNiOotLtPnmrMMuZzs3Fgzv9R1AJ1d7E0z/Mrnp2PKvob8XDk3qs97NeDuO/GaIkAMWOfkl8Q/TkTkRVoekm9GuEo7vUmxpwwQ9dzpX/WR/WGz px5Tyvh7 KaYz5768fwjTrY2r+0jhAjvDJe0SQ12E1iJwD5Xu0WHqYa/aQSMOGwVhIQaA2HDIauIXzeLJBIT/XTvLkKGpvzxyK3kFuRgYqzkI6HUZIgflAXlkwNHBV0OTUde/cZkSxcHJiPAf1H7BhGy4YHplDNsCzmYQhYlQ8mS9OPOFF+p6XDkLMhzsp3MPHHqECMgXZg79C6Wkzv+pp531lBY6GXI5YtAvNLgnJEjcGybWdWayTROUzknUJRdduHjGHp8hBPgamoP/22RX/rNC5/ab1FzK7wzMup7aFrgwj7BShKmsrZlkUNaIqsiGoWyzqScAVwG9z1TIlwPB80cM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/9/4 00:10, Jarkko Sakkinen 写道: > On Mon Sep 2, 2024 at 6:00 AM EEST, Shuai Xue wrote: >> Part of return value comments for memory_failure() were originally >> documented at the call site. Move those comments to the function >> declaration to improve code readability and to provide developers with >> immediate access to function usage and return information. >> >> Signed-off-by: Shuai Xue >> --- >> arch/x86/kernel/cpu/mce/core.c | 7 ------- >> mm/memory-failure.c | 9 ++++++--- >> 2 files changed, 6 insertions(+), 10 deletions(-) >> >> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c >> index b85ec7a4ec9e..66693b6dd1cd 100644 >> --- a/arch/x86/kernel/cpu/mce/core.c >> +++ b/arch/x86/kernel/cpu/mce/core.c >> @@ -1361,13 +1361,6 @@ static void kill_me_maybe(struct callback_head *cb) >> return; >> } >> >> - /* >> - * -EHWPOISON from memory_failure() means that it already sent SIGBUS >> - * to the current process with the proper error info, >> - * -EOPNOTSUPP means hwpoison_filter() filtered the error event, >> - * >> - * In both cases, no further processing is required. >> - */ >> if (ret == -EHWPOISON || ret == -EOPNOTSUPP) >> return; >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index 7066fc84f351..df26e2ff5e06 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -2199,9 +2199,12 @@ static void kill_procs_now(struct page *p, unsigned long pfn, int flags, >> * Must run in process context (e.g. a work queue) with interrupts >> * enabled and no spinlocks held. >> * >> - * Return: 0 for successfully handled the memory error, >> - * -EOPNOTSUPP for hwpoison_filter() filtered the error event, >> - * < 0(except -EOPNOTSUPP) on failure. >> + * Return values: > > s/Return values/Return:/ > > https://www.kernel.org/doc/Documentation/kernel-doc-nano-HOWTO.txt > Hi, Jarkko, Thank you for the reminder. Will fix it in next version. Best Regards, Shuai