From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 515E7CD4F24 for ; Wed, 4 Sep 2024 19:58:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB3BA6B00BE; Wed, 4 Sep 2024 15:58:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D62E36B00F5; Wed, 4 Sep 2024 15:58:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C057A6B0109; Wed, 4 Sep 2024 15:58:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A0EA36B00BE for ; Wed, 4 Sep 2024 15:58:16 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E7DA91404A5 for ; Wed, 4 Sep 2024 19:58:15 +0000 (UTC) X-FDA: 82528117350.06.6D84B3B Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf02.hostedemail.com (Postfix) with ESMTP id 0D1FE8000E for ; Wed, 4 Sep 2024 19:58:13 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LOggQ1Gc; spf=pass (imf02.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725479798; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cPICdxGtZMm7EVbsBiDOXLzIL+MnaADtVMssqy1cp2c=; b=YTWmQW8m8JHwLa7jJUf5lu813p6WfxcJkPt2e4P8i6XtkrsVi03KREKg+fhsDcP7FYh3yX RV7KulFWKXcXqKaChpBJmEiCU2hoEtS6h4OFjsy5ohVAiq4PFoDK3MZKVQtQH0i/wl/qgH zukN0nRE+zbxDIRlCaYxELy90XbCaXs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725479798; a=rsa-sha256; cv=none; b=egVqMCWHmDpaUJsEE4q6h2KtCNvLBspJqfvzG59iye9/XqHXd6h6aj6XLOow32JAAZXgPK x1f1512YhOM3V7cflEWqMslA5qi7mzswEVFN+BPKiA4YvaioAIVpCXmj9AhZAYrNn5FrSl ktxj9NEfZh4CC/dNl/lrugXKkXScUOU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LOggQ1Gc; spf=pass (imf02.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-70b2421471aso38056a12.0 for ; Wed, 04 Sep 2024 12:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725479893; x=1726084693; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=cPICdxGtZMm7EVbsBiDOXLzIL+MnaADtVMssqy1cp2c=; b=LOggQ1GcQR7U/JJk0g27KlnuORtNMLt2y1VxntqmJEtlTWtDobg1+p7MLiCiOoM++W oWcj66PsK3Eh5VMCy04ez6u1S1iacWxMh73JOcF+YBhUsyCCJKHEeSZn8kPt+2UIaukn 3rw2B+qqmML7oWWCg3cjyfFVYMfy2+GDUL0OKEHv7PDJRzt74dtm8zf74c1SVT6w9n1i 2jl1JrILhMLecUWdE0nf0NZSORb4TZ869qZNaPfm9pYtiios87Cj+EjXs++O81ULb0QZ YN/+dvWZXm7nA41YBPagLZ5mSllCyklWY3p5QWOieL6h8diZxZhvIuhJbT7MlJMMErL1 2xcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725479893; x=1726084693; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cPICdxGtZMm7EVbsBiDOXLzIL+MnaADtVMssqy1cp2c=; b=fUYJPHQan/KRKBYgbHNbjpO5H6ySKH+XZ0DiveVRunJcCpasxV9v5bZFE+WvNXH79g 2UpOcCNFAqwoMFjuVWn9mWD7eJvYMRUrZawt5rpXhvJ/nQCiRCEab7FWM+qBXfm7UGJX 5TNENay0Bb6oQ19KFWY2/uODMKYvhwSD/QlBKVyAIH7pH4zDH0eaCs33e/gbw7wdpOCo vtfeTwrIfMkEe9BG3Y43jLihtMKUZkX40fsthmGHAnqJGk7FD1WMI8w8gpfIRDO0e4Qc 5V0h8OF1dwOyW6xTADpea79WUWcCW/EorRwicIcjR2p/G354FDBg+8bh6fn9vMZxVVni BpOg== X-Forwarded-Encrypted: i=1; AJvYcCW9esotwuzpNJVsyEuXUOXUt7rp8ndfdzbbedNEQMHgunUjgU0TuCmnejO7pqVzStrIKDeD0CGkXg==@kvack.org X-Gm-Message-State: AOJu0YwsI0NnKXn2Uk0ociZn7bumA9doMT201tPYHld87ivTtK743L7L PY+BYfzIkYIG0Zf0ACPmjbhMXyR1HR1lzRAo0IVJuc8tDrPkmTX6fSfn7Q== X-Google-Smtp-Source: AGHT+IHiuHFL/47pKWStSEZDU1pmVIBJvuKjwmas3mljqR/n/RvBLMuLXDlS66q4XOAagB8218fbcQ== X-Received: by 2002:a17:90a:70cf:b0:2d8:f12f:6bed with SMTP id 98e67ed59e1d1-2da5592440bmr7912187a91.3.1725479892758; Wed, 04 Sep 2024 12:58:12 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2da53740084sm4907126a91.32.2024.09.04.12.58.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 12:58:12 -0700 (PDT) Date: Wed, 4 Sep 2024 12:58:11 -0700 From: Guenter Roeck To: SeongJae Park Cc: Andrew Morton , "Liam R. Howlett" , David Hildenbrand , "Matthew Wilcox (Oracle)" , Brendan Higgins , David Gow , damon@lists.linux.dev, linux-mm@kvack.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/damon/tests/vaddr-kunit: init maple tree without MT_FLAGS_LOCK_EXTERN Message-ID: References: <20240904172931.1284-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904172931.1284-1-sj@kernel.org> X-Rspamd-Queue-Id: 0D1FE8000E X-Stat-Signature: 7axfnjx4pkkrury76u7f4wgou7ian7ck X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725479893-192215 X-HE-Meta: U2FsdGVkX1+r5JoM4iEuEHLKBeNPt3yVhdLxv3EdVqf1bJMRt+CPShD79cB0yj2/EoWzQOYoyr/nK75ircYQPn7PpEz3/mgIwjFLvJkmBbkIygULdL24opzucGswXS4El26V9Rft8eii/UCKRQ5FoFlZln1oGYPDeZ5tV21eG6nGgd7iLYZSz4tv/FqX6W9wa6vRv5LiFxGvyuSi4HfB5ACYVqNjaolhegri2T7EF41QG+Z2oXN+26x1lzdbV3xTvekoFlDtj2Dpxc/FKrKn0+aF41tSZvYgt9jZAeIfzNdiPQv3lab3HwGrrmv0t0ALMFSPR1zfuEqiP0VkFMyINlfe3WIjoj/gevBaI/ZXGapeLyUekuGlSdmcmSRBlfTyGaaEKHVwN3VBVyam4cKqs+KBfjatLpUJfA9Iilr+PKapx1p4iFc2UcBny/PnYhPB7/UfisYSuQRy988BPPnBvkrkXsFIAzDJGjlKgELpuORfjxM5BgHzcyFUZJI4+KAgvUB2N1anm/q95GE+rIP2DUiWlJDt9bdAOnpDMCe/b+AkZAZ/13qMSMWSSVuAJplOEQah/4JbFAy+Xkjcor3umtgTuRs65I76ydgHXIovpNsabpTK5j7TtEVWgJf3CBy7fA4pz5C8+AI6W1lvFDjT7DI8wFinBA8F6/ARHTVT2PYmjGgPvoeUq4nFnHvhck6LGtpC2ESV5L/PtILL5CJMi9KG393OsgiRGdA2IN5pCrnU3cm9n0KLy+TgiLJsb9G6wy+QN1s546qJjbsyZ0WqUXtCJsj6Am+G+5ZO3idSmtymXXglj1vvt8Wt4tzfRJTy7CLB6NGGL5Jt+ygnNlQxCPVBMORiu2sV0g6BNAU+l7eg1XskN+vbxjqGGAWDaip7KuToRMzAJDLxaLiRA+zkCo/wgoChvlrAWF4JH4ZfG18Voy2M6imR0TdomdQGsH+OutYUrQqUH+OuqO84l76 R2FKlamG 5Jmrb5DH0AEp/9gM/WjQFQD44R+NUk4LrUVz64r83W33wu6vov2jfDmXznWqIUEc3hPCJ2Qvg0HgNiYOhk9fxwc0Yn3nXUipUMCl0PutHH8U43f34aoHPUtlWlv+1U7lGy7+6R3Dmn0HgXY8AM3/bHceOBS11Ddanx9zyrY2xXLNMAXPsOO9DiwpdPhB21B1C6wWzElR4ZyC3am4k5kBnW2XSvZsJDNxHRBQwXl8IWGBYTjt8/aPcunNmJXomkXP8K+qUfQ5ykFtoVaAGqDhjdWtoTdOcs59mdLed0S3hukr1AR3GDKhc3hFGqy9XdFeWSABO5kHbe1tDv5RNgPZq0SaJohUEnkLqNkuvXqhzfxnhNCtRfGHgYQN2Xs45D5PUAQCQk3gsp+K5aLN92tPl/0PLs1l/DsH+R63La5wnIhbR2R+1GML/oumRqEfz5qBTmxvfZcgk+2V8Tdv2T4GWZT89OiwKgf5jPz1efR2VV54DhAMHi9ugWJyPe0/MWE1B+QrXrH3POV+26EDXpO3CSB0bPDAnrYm3XM7VgU6kW+OT5YJmy0mYZbuGIoIyqu5utOUdDrQ6F0OK5WK8l5nHLbbLLW/XVnxUgBiDw+N1Dc4OMDAV6qqABQxzyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 10:29:31AM -0700, SeongJae Park wrote: > damon_test_three_regions_in_vmas() initializes a maple tree with > MM_MT_FLAGS. The flags contains MT_FLAGS_LOCK_EXTERN, which means > mt_lock of the maple tree will not be used. And therefore the maple > tree initialization code skips initialization of the mt_lock. However, > __link_vmas(), which adds vmas for test to the maple tree, uses the > mt_lock. In other words, the uninitialized spinlock is used. The > problem becomes clear when spinlock debugging is turned on, since it > reports spinlock bad magic bug. > > Fix the issue by excluding MT_FLAGS_LOCK_EXTERN from the maple tree > initialization flags. Note that we don't use empty flags to make it > further similar to the usage of mm maple tree, and to be prepared for > possible future changes, as suggested by Liam. > > Reported-by: Guenter Roeck > Closes: https://lore.kernel.org/1453b2b2-6119-4082-ad9e-f3c5239bf87e@roeck-us.net > Fixes: d0cf3dd47f0d ("damon: convert __damon_va_three_regions to use the VMA iterator") > Suggested-by: Liam R. Howlett > Signed-off-by: SeongJae Park Tested-by: Guenter Roeck > --- > Changes from v1 > (https://lore.kernel.org/20240904004534.1189-1-sj@kernel.org) > - Keep lock usage and update the initialization flags (Liam) > - Fix a typo: s/celar/clear/ (Guenter) > > mm/damon/tests/vaddr-kunit.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h > index 83626483f82b..a339d117150f 100644 > --- a/mm/damon/tests/vaddr-kunit.h > +++ b/mm/damon/tests/vaddr-kunit.h > @@ -77,7 +77,7 @@ static void damon_test_three_regions_in_vmas(struct kunit *test) > (struct vm_area_struct) {.vm_start = 307, .vm_end = 330}, > }; > > - mt_init_flags(&mm.mm_mt, MM_MT_FLAGS); > + mt_init_flags(&mm.mm_mt, MT_FLAGS_ALLOC_RANGE | MT_FLAGS_USE_RCU); > if (__link_vmas(&mm.mm_mt, vmas, ARRAY_SIZE(vmas))) > kunit_skip(test, "Failed to create VMA tree"); > > -- > 2.39.2 >