From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF999C5AD49 for ; Fri, 6 Jun 2025 07:39:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 563356B0088; Fri, 6 Jun 2025 03:39:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 533546B008A; Fri, 6 Jun 2025 03:39:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 421996B008C; Fri, 6 Jun 2025 03:39:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 20FAB6B0088 for ; Fri, 6 Jun 2025 03:39:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BBD3AB7E60 for ; Fri, 6 Jun 2025 07:39:50 +0000 (UTC) X-FDA: 83524176540.16.B6C478C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 4976D1C000D for ; Fri, 6 Jun 2025 07:39:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BKIQnOOS; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749195588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BhoJzWHa5XwXWl7HUhWJWFpdgqG5BG+tce/0LfTOW0Q=; b=OQ2sq2bvfsObqv9gik2ZLZXxNJjd4A1cZ5WlCsYUK/fkWyCE4t7x+jbILtT/hc7ttQEko6 Xr5Eo1pxa1GpNg1lr5+TPv8RPoL8hm5CJ5DZIGPgVD0cAWMOPqUEv6V+x3MdjZvW/OKh1c oLpKK90pHb0nwAIjA/S6dhbAiUQkUfI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BKIQnOOS; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749195588; a=rsa-sha256; cv=none; b=x+oXb2Ti4UqPNJH1N0851IwGbzcUWTADd8zvZndR3iM65OCyR/WHcSKI2kJt/D4ae39ORX 8lL1P6J0STM6TMN6qB0mbecQLSbY9eKCEOGbNCMHwgUs+bBPcgkc85yqBD00yE2Gkgm4Xz a6mVZ1VT72sHgMtcsJQtkuXWXhAhEuI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749195586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BhoJzWHa5XwXWl7HUhWJWFpdgqG5BG+tce/0LfTOW0Q=; b=BKIQnOOSlWUrvCyeONSie/oF09vyBGQFFDnbx3I3Tdn9bRbIl6P/qsUtxIBMbRLw/LjHIE crBBZihV9FHWnaU3k4tmQg1vzANbzNECkkZ+eD7HIMbBnnSX1MjhPV37aV5Egod3QgXf/x QqvZ/4NUuIMyTOO5VbYegYYbB035xRA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-388-8z2YA_uAOpyT9pzkkKAn9Q-1; Fri, 06 Jun 2025 03:39:42 -0400 X-MC-Unique: 8z2YA_uAOpyT9pzkkKAn9Q-1 X-Mimecast-MFC-AGG-ID: 8z2YA_uAOpyT9pzkkKAn9Q_1749195581 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f6cc5332so1157193f8f.2 for ; Fri, 06 Jun 2025 00:39:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749195581; x=1749800381; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BhoJzWHa5XwXWl7HUhWJWFpdgqG5BG+tce/0LfTOW0Q=; b=VlLF8QCKOgpo3CHsXJcXutC31yhQvkLlf2o4aNk3FEtmzyQodQSVhr0cY2bipurTnc sMeLji3K7g7HMS1zokLEmfU+dW+pAolR+VuqPATmmIZ6/oPZxLjdOLgzFObUKLkkjn6+ nvs0a/B575kOmmeSJgBeHuA4PBc/+cd6Oi17MhV2y5YO2FFV4+lQ/UuSgKnZFKJ6PeH+ ibcNXo5I7wI04XWb5mpFzOGHXp+98A4Mudg0u2dF6TSw+u0/pSaSoyL8uSLkchQSkUMQ ODKoJ/+Xx6S4u9lCVo8W25DkTzPlsNPbxO4jMqjTqnjoCuyLIX51SDOyp0o5NQ+iR7q9 tgpg== X-Forwarded-Encrypted: i=1; AJvYcCUiHbVrXlpYANNPAfrh87X9iwtwr0cmCbZw2JS44jrAvJqQC6vVRYL6kvr2yM/2/JKF/0H8Lo/cmw==@kvack.org X-Gm-Message-State: AOJu0YwlsJOWtpt2RT3XHzqd635xwtwEZ0F6VVczdq6/NhRvMXaQ6/P3 GPkJD6NFXeAX2jrUJ3iR9dYudtfjlyqg6HkTbDeufFtpoiWpQ+SVxJT3dEqoCjsTglfmp7dY7Wc SsBINfxsjd7n0pqrSDvtB1Tcl9D9SFOIxhErnZz/Y+pgmgOPKVOqT X-Gm-Gg: ASbGncuMF2r0sio2mQu0sI/7Kxek3btgfo+TnU7jmIsRdXEKigf8xhQn/oLlIj0Aja4 j1TxIS43ppEaTuRyQZmq5EIBt26AmNIIaM3tKukMpZSBpZRynDE39cui1onSBtQdQ7DTlOVPrrs X5ReCJmsVRBUkYBxqPcnZ/kxZ11UUDtj9WoWqgYcSsBRtf4K+8t+AlPKZc+J7rkRC38blLLIJeQ MWzec3kynM5qv2LlB9ve088G53yrjCuKpRnsqHPSNV/vQ/Ln2EB5a5IR0pJI5OyutF4+kYNuwMX TT49V7Y9dLUjBSk0Z38pFj+D3meixCqLSvt0MToHNJE= X-Received: by 2002:a05:6000:250e:b0:3a3:6e85:a529 with SMTP id ffacd0b85a97d-3a531cb0cf0mr1786814f8f.51.1749195581385; Fri, 06 Jun 2025 00:39:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQs3qBLN6k4wLm64IaAd8R7wbKaspOFAjP47G4ujPD9jlSn5dBnR4N+GY2+13VYJrGQffTqg== X-Received: by 2002:a05:6000:250e:b0:3a3:6e85:a529 with SMTP id ffacd0b85a97d-3a531cb0cf0mr1786778f8f.51.1749195580929; Fri, 06 Jun 2025 00:39:40 -0700 (PDT) Received: from [192.168.3.141] (p57a1a6a5.dip0.t-ipconnect.de. [87.161.166.165]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229da18sm1116872f8f.19.2025.06.06.00.39.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 00:39:40 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 09:39:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 14/18] KVM: arm64: Handle guest_memfd-backed guest page faults To: Fuad Tabba , James Houghton Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250605153800.557144-1-tabba@google.com> <20250605153800.557144-15-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cAd7J6QK1I1jurHEtVDKfkuLc6jBuf7NNvqPxWl98AQ_1749195581 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 1wfa9d1okij1dazawegnjpboh4hq6tty X-Rspamd-Queue-Id: 4976D1C000D X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749195588-556318 X-HE-Meta: U2FsdGVkX1/IebjU4AI3kmIwzT71DC9CISWDWn3ulHPJ7CYXFsqp32ki+jXYn2U+cwS6PboJra809ga/jCNwfuRIJyN9qXx9Fyupa2eSoeqietT3M5/5MnF+a/MgwMObm6qARWWrsB4OEZahqucqBFd2kqy3a5yZhXs2M1jaL7Fs3bGgs3N9oiKwAYGFop4q3cauMmpjxUrvbutX65QgBqH772/sfko5KctfxdXeIq6ZQZGUy0ralYp7pOQJidSlFHzweFYKbwCyiXBB+YcpoOZYWxMoV08BJCPzLgRBjyYPSih+ZGd5pKGE1jUcqbE/9E6YWI6ipXwMpw7vZcJpYnMAJJDBj5+tcdeJlVZ3TcYy/Srk550Dlj3V2bgYR5GoZ0QDhW2MqzNO39YXDenywaqhocVqqtu3ZWXXpN672BPzETiyXn3RJyUF53WtjAW0Iv+IDWjqpG7ydv4GhhVgMFBl3azRFe12SE+64xXT4eCSS9jTNLpjU36o7OBddAyxy8AT6J0v6xqqIHGKkGCIWu+mPAuYMak1arg3KeFnBhGs+o1LJNqL4FLdvFoQvKGiHrfMttHt03DTc+v1EqZNYWFGzv/qmEX3CmhmV7c87VYxM+5P3n+sfCkKnT8V+me090vh4Ckz5H2TaeixG0RzjlZ0Qh3qMpHIXoGe298pGPjqEXGYRMoEKU7caC17F1uDlvZ1Lg+rlAOuOqAEVVV8b5jN0u2QxgEe/zyEXPD2QGj906L8bsqBDFZYXepkYbcu1NP4xIVMumAOxJJDvJiHicXd4EA0S79WADp7RBC2qjegTwXJuKUoWZu9nYrrAaH60ZN+m+o3fI8eKCGrfjC4lGDsYD1LYvmTZCMytdIZtCVcsOckMd9rYxq/mnMsRRlOp5/h1o6tdoQn/8ObWVmPq1zZKv7RLlc5hx6wXQcahjH3DO6L9P+nIwOpbsykqi3KYQMEBIxuxDjKQePyS15 rM3ya/vU 6+mKzwEU+jYm3fKl2wkyWbPwn8SPTS+XT5yhywS9VLiq56qfO/AI5FJcyo/JKyvo+BqBFZhg3y7we0p27iPRN8Edfu53o4puHgKYzj4BuUDGKB4F0KIiI2x5oHsmyWUb2SlC4zndGHCyhhMD5fFRqcWhtP49RHBiQkGM7grwglNDtGseOPfE9/E+bu3OcbzJZzjiF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> + write_fault = kvm_is_write_fault(vcpu); >>> + exec_fault = kvm_vcpu_trap_is_exec_fault(vcpu); >>> + >>> + if (write_fault && exec_fault) { >>> + kvm_err("Simultaneous write and execution fault\n"); >>> + return -EFAULT; >>> + } >>> + >>> + if (is_perm && !write_fault && !exec_fault) { >>> + kvm_err("Unexpected L2 read permission error\n"); >>> + return -EFAULT; >>> + } >> >> I think, ideally, these above checks should be put into a separate >> function and shared with user_mem_abort(). (The VM_BUG_ON(write_fault >> && exec_fault) that user_mem_abort() does seems fine to me, I don't see a >> real need to change it to -EFAULT.) > > I would like to do that, however, I didn't want to change > user_mem_abort(), and regarding the VM_BUG_ON, see David's feedback to > V10: > > https://lore.kernel.org/all/ed1928ce-fc6f-4aaa-9f54-126a8af12240@redhat.com/ Worth reading Linus' reply in [1], that contains a bit more history on BUG_ON() and how it should not be used. (VM_BUG_ON we'll now likely get rid of completely) [1] https://lkml.kernel.org/r/20250604140544.688711-1-david@redhat.com -- Cheers, David / dhildenb