From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0796C3DA60 for ; Thu, 18 Jul 2024 10:06:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 508816B0082; Thu, 18 Jul 2024 06:06:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B7F06B0083; Thu, 18 Jul 2024 06:06:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3586C6B0085; Thu, 18 Jul 2024 06:06:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 16FA56B0082 for ; Thu, 18 Jul 2024 06:06:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 78E44419AC for ; Thu, 18 Jul 2024 10:06:52 +0000 (UTC) X-FDA: 82352444664.13.36E4C7C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 08E1D4000C for ; Thu, 18 Jul 2024 10:06:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=O18IGytj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of krzk@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=krzk@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721297165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=enqHQhmG+qvYGHldPPrDBfrnv7aEzQ91SFQsxU2LNbY=; b=4CrS4wSDtOE14GeGL8ZwEUWSyLBKNHk01J/aCPVPqRTaK1flwDaonHmYZikDoFNvWEV0iK 4QMzFhjfFCII5+QbPe10tddk3znC1gSXQTcwFXvo4LdYVuvMW3aUi9IQsCkwtngkocppes jc4JR4PYylos/EFan09BMt9AI2GaCkM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721297165; a=rsa-sha256; cv=none; b=qgIXNOHGgvWd8+J7bGqPchXQfqlzNqVn8+FC9BvUwevaDXOT6seLaHe/l9yfRwjYHE+s6f 1KbtGxJbBrYz2WS67+iU2uiWxs5Pv6KjwOxUV/GheOPLc2cWyZSt3wPeJTYuI+Hp8aoYoO C3Ubn18oA+SLmDpny8xmB2dUU5AAilc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=O18IGytj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of krzk@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=krzk@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B0784CE1935; Thu, 18 Jul 2024 10:06:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96AB0C116B1; Thu, 18 Jul 2024 10:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721297206; bh=lnmV7JL/s+KKycf99YstQbEHnKqa0bYEOKJfm2l+tdA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=O18IGytjxQsoRUwaw7MqYi0i6lKILqvxRJxmZF0+e99aVGZ1Vu1qR2CsM28yjy6o1 XNLj2EVAnCIvaqMX58UPEY8jq8DAXtG3RjKMBjJ34aNnHsOCA6Cvu2b/wDcvxsL7lB VlaPtnWaPyJsZGcx8vYY+CM34TBwhN8dk5D43oLbAIQaMcQjBWSRi9Muv6ttpcL8vD 6KRHJgLar8kk923KdG/ENbTHFoMBBkmVzeHVwN4nOebo21idMRVDKxU765scVX1QzR UyZNckMa5FMHOmwcxk2aQMuK0HSN40ms9aWEQ4vtspxb5ksnCqaC+fbCQC//2uZBD8 FEZQFXi8eiYGw== Message-ID: Date: Thu, 18 Jul 2024 12:06:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master 7766/10451] drivers/clk/qcom/camcc-sm8650.c:3573:29: error: incompatible pointer types passing 'struct device *' to parameter of type 'struct platform_device *' To: Jagadeesh Kona , kernel test robot Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Bjorn Andersson , Bryan O'Donoghue , Dmitry Baryshkov , Vladimir Zapolskiy , Taniya Das , Ajit Pandey , Imran Shaik References: <202407072331.baglL4Sd-lkp@intel.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 08E1D4000C X-Stat-Signature: piq9r7pnq4dzxfk87rqzh7htn9d5rpt6 X-Rspam-User: X-HE-Tag: 1721297209-175086 X-HE-Meta: U2FsdGVkX19hQZHdma2YHFd6hqrqxI9Z5o1g9RtcU79NaL9XBzfxziODutgWAyC4hKe5rNKZwRJQJxSWMvEEcDIJ7pAfRkvIB6i5gXCS/Wl8GlvDixdSzVHMDauK4XCy38XthHcclC0nekgm9aYWZR2VISx4U8n/JR1qdtdrIAqxaPEYqeIBqaxC4AiEi5befw+j9PY7/05DOVYeUpHOeo+GHArI1Ppq+PneDg1FEZdDsoELTy5cGE1/gjKhe//A01/k8B/VGkSi+uIfhC5w2h2UecB5+B3JRp84cbPXUkgkg75Z6eZlK05cRtUgrjMnGBTA4DghSAMQnKYYHAx0xbg1raHEBDevM9yEjkKJ7doQvcG4byt+xPGE9hfVOjPv4x9CO/3DQhNiYDOkOuddXNbNYoCfdFjNhCOsubhH9iKPrC2XixESJGt7dc/2gBuW80XhPqXP2sn6rpIDcEcLeX+XnxXpf3qICFjf4sNUtsREgIrCWqZjyIVZAg9h/biVo/101pUESMTKhmYnYAxVUJBw+QP6Ai/ozYmbqjlHXaZYg6fyBQ+Uu/ayQmvkW+FuCXdaxRK/LGg1c/JoXhqOvEjiRsoZ+tVnNqn7M49cvlVFex/xGSg8UE32UEOsikvobzCcCFYAj85k9s4DCTs2XNzSFh4sjJprx5N9yu9FhUvgaE4bYJ8Qe2JJaK8CpHgYGeagRpXNWsjfJ3kV9+1oq/GSjYt3P3M1qMYv4NIwsf4H0T+Otr/6NA8LtZGTh2GXy4K0Lmq6/pZtbEwmB5rmFykRp7fVFAQo1eKQ6ZsE1HW2cjt2tj2YAaGsS4gRW3Q6haGAwXm0/bphEWHKB2OQ+2EWEaUuLlbi1ZME08StAEYeTSSmiPEpnquKYl/M3DWC8QFUP1C2V6ZMViLwTqYnCB/nP7FCX2U0WsKcrHnl8895olOU7a1Ypk6P6gqgDZqJ3wDIeCzPjCZelTJffxr TuyE3DlJ J0cCxCJRhy8jLBaGuhmVfwBSGVvl32XFxlrk2sEhOqjxSaER1oAsihzBVrYRf8tRv1Yt+wmTFnDvk5vyHbAQcvIvKSz1qyzZbZAQ6CQg/iBeaDjKru6j5YUhH6ZcDeo3SP1DgO4LY7e73WMsMNh8mQjFJacp/Mh5kGTT88oXbdR/osywdTBWkes96cOM28lSW0xg57vwElzg2U3q1ycERZyo3fEUTjPAnoXCy4jFd2NfjLht30acSvwwGgl26xa1dK2bqolNA1fPBh0VJxX0jz89so+0ecIMvT2Inmd7TaSjaNoEFX3WQFQj8cKlr4Vzoug95tPTOazUm4c7AG6MokDeOQpMv+BiEXv5PceUuunphbZRqay1FAXDqwQIkO730+l85U2VvIcNH5GBZwMpHjeTsODJaKiwYvlchHkQKlyh3tc6eUbEjDKuQ5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18/07/2024 11:48, Jagadeesh Kona wrote: > > > On 7/18/2024 12:18 PM, Krzysztof Kozlowski wrote: >> On 07/07/2024 17:20, kernel test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>> head: 0b58e108042b0ed28a71cd7edf5175999955b233 >>> commit: 09ea421652a832083ea380a72addf383965f3682 [7766/10451] clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver >>> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240707/202407072331.baglL4Sd-lkp@intel.com/config) >>> compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) >>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240707/202407072331.baglL4Sd-lkp@intel.com/reproduce) >> >> This and this: >> https://lore.kernel.org/all/202407072212.WptVaUDt-lkp@intel.com/ >> >> are reports on linux-next. They were addressed to you/ >> >> Jagadeesh, how did you respond to public reports that your commit has >> build failures in linux-next? >> >> It reached now Linus' tree causing huge rant, unfortunately not in the >> direction we would like that rant to go. >> >> If you receive a report that your code does not even compile, it is YOUR >> DAMN MOST IMPORTANT TASK to address it IMMEDIATELY. >> >> I don't think such code should be ever accepted if contributors do not >> take responsibility for their commits. >> >> Krzysztof >> > > I initially submitted my change [1] by passing pdev to > qcom_cc_really_probe(). Seems like due to [2] which changed the > qcom_cc_really_probe() parameters from pdev to dev, my change was > updated from pdev to &pdev->dev while applying. > > When this issue was reported by kernel bot, I checked out the linux-next > tree but I didn't see this failure since the common change [2] was So tree is not bisectable but that's fine? How about telling the maintainer: listen, your tree is now broken? > already merged into linux-next. I apologize for not reverting the same > over the email thread. > > But change [2] was somehow missed and only my change [1] landed up in > Linus's tree, which led to this failure as Arnd described in [3]. Nothing was missed. That commit should have never been accepted to that branch, but, since it happened, you claim that dependency in clk drivers should as well go to DTS branch? No, that's just wrong. Mistake was that particular commit going to that branch and kernel robot told you that which you (and Bjorn, but Bjorn is busy so it is your job as contributor) should investigate. If that's how commits from quicinc look like I am afraid to take anything. I will be on my own, stuck with such issues, because for contributor "it is fine". Best regards, Krzysztof