From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BEB8C369CB for ; Tue, 22 Apr 2025 08:56:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF35A6B0025; Tue, 22 Apr 2025 04:56:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7A796B0026; Tue, 22 Apr 2025 04:56:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF5D56B0027; Tue, 22 Apr 2025 04:56:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8B6516B0025 for ; Tue, 22 Apr 2025 04:56:21 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0C5321CFE35 for ; Tue, 22 Apr 2025 08:56:23 +0000 (UTC) X-FDA: 83361073446.30.D91173C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id A9A7D140003 for ; Tue, 22 Apr 2025 08:56:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fldqyzCl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745312180; a=rsa-sha256; cv=none; b=Y7gJIa5dPB8r6r6IgP9FfCXBUBwdfmw6nNrnkWrFBOZ1Q8A/rL08MCsSVfIwDZdiYONUkZ JU2sQD0zvMwsol6Kgz2Y0RZyxqZ0vsGadxwsD98P+75dVU4ST65orjvJ2Mr0g1AfU9slCp Sqo0BsWSOks+0W7Ei5kQeiQhfFtXRJ0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fldqyzCl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745312180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t/fkliyhwjYo/6vzpuyau7iSBw7U5UuvVDDapw9CN3A=; b=ivdg1HRrMWnbGZH+UvkUCrW5G7YgCUzVOUUbJgzEKPkZ55ensZ+X+ZneGH1ZQukzLqXEwQ h5A6sHLbNCw55bUQ6T71GBthT71Od1n+kaa9M/fkx2U8DoQqFB/llcMJ412D0uTrFO7Yvp WL+3s7n2e9fXOgncR4eOBCeP9fUkbIg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745312180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=t/fkliyhwjYo/6vzpuyau7iSBw7U5UuvVDDapw9CN3A=; b=fldqyzCl2GR6jWx8mOxPhcjaEzJ/DEtfOXzTnlrixUyHA/D71O+/QKaIYeqeUIDyF26vSN oJA0w3pg6dipx1q23+2FJc5dnL1+0PBpmiurqLVwZtjh+w6uOiZ7kjh0GF0Rt82Um+auKP RQ8JRisANrh+BQXRXxvnfYb2Mz5fCh4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-qaaZNNYLPcOvUjO50IX4pA-1; Tue, 22 Apr 2025 04:56:17 -0400 X-MC-Unique: qaaZNNYLPcOvUjO50IX4pA-1 X-Mimecast-MFC-AGG-ID: qaaZNNYLPcOvUjO50IX4pA_1745312176 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43e9a3d2977so36508475e9.1 for ; Tue, 22 Apr 2025 01:56:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745312176; x=1745916976; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=t/fkliyhwjYo/6vzpuyau7iSBw7U5UuvVDDapw9CN3A=; b=ZvCqWKh+j6vEmX4RThMbgfp7nMBROyvAwoeS9SRokt/ASeaUCzs1AWelTZ3MBJqiAm XJ5GCbrpFohG1GXp7faduaToMWM1Id6nUErTWr6tQfwydBxrVL1Vh5R4M0R/2erKPO6w qUZ+g7a9alj5q0VnSjPDqiMWgud9zET9na6eSY+C4nimiRaUiINKZ6n9rOFuvSNpYAna Y1SSirfriDOhGAdL8JZHTXcjY6jFZGw8zbsW03uQVq5o9BnuY5Ojh8vL9rF59pZizItc lM3CHUArtWd8bEMYt/9Pun/SRlef/z0Wd30uTp4V4f/b4EQj0jPogCtFZorDcfy2jFvQ rJCQ== X-Forwarded-Encrypted: i=1; AJvYcCUHcBTcrTQV3P5Ed/3Yh211be2pC1mKPNVshbO9L7jinDxV2GfBmt3Ez+hdWdo3KyWI4gV6AjgC+g==@kvack.org X-Gm-Message-State: AOJu0YyIVbsHeHQ9IcEbPOkCqkRk7TkN6BrD/tmJxo8l6ax5XhtWbeT5 es0ujVBoqzii0bFNUOuJI54P4u+fYda2okvztAESMwkbJvhZUODckunPguI2iftcqcnIyrzrKiy cY80gCTZWcfXpkLq5JW+SE4S8C1e1iApDX87VYjDp7nKdUk46 X-Gm-Gg: ASbGncsOZjXFToh8eXzscQL53BYLFefFSAGcMC3fpcl4irGg35cohRVKtX6x+a52jwb duTc+Io6xM/+AEJ4w5V5d+2dQtXdQTDpHKKx/UVMNtw9RX9sWXDEAlSJGovGLoFerEKC/eYQiEp frru7IohpSOJ6hjUQSzEIp1QWgEJfcH4nGRWJnIPcfw+So/doKM8omlhLauFiQZ2szUcCrTXWz9 dVnRhf8AwGG7e9dvtCbrty2wyWOwqp+V3m0mrcMovMIM1Xx7RYT0NUdxCBy5ik9um/EPeogCicZ gHiVjgaOQ8hzbBisIQ+APsiUHFMF2Ezw9J9eZCTm2F9CQgY9lTnaGcLCyjx+cQbLmbGTfz4ZA+q PInePC35ELXPKoPXXeKS4dIeSqMgi+KCLVYaC X-Received: by 2002:a05:600c:3b9b:b0:439:643a:c8d5 with SMTP id 5b1f17b1804b1-4406aa872fdmr143677655e9.0.1745312176216; Tue, 22 Apr 2025 01:56:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqPiQQsO1+6ekL/9r9ho28+iwatEw09L7oTisyx+CF6U4CL3jK44kFhlTXxgS0d9SPSnjk0w== X-Received: by 2002:a05:600c:3b9b:b0:439:643a:c8d5 with SMTP id 5b1f17b1804b1-4406aa872fdmr143677415e9.0.1745312175858; Tue, 22 Apr 2025 01:56:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c731:8700:3969:7786:322:9641? (p200300cbc73187003969778603229641.dip0.t-ipconnect.de. [2003:cb:c731:8700:3969:7786:322:9641]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa433303sm14301077f8f.24.2025.04.22.01.56.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 01:56:15 -0700 (PDT) Message-ID: Date: Tue, 22 Apr 2025 10:56:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] mm/hugetlb: Refactor __unmap_hugepage_range() to take folio instead of page To: nifan.cxl@gmail.com, muchun.song@linux.dev, willy@infradead.org Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni References: <20250418170834.248318-2-nifan.cxl@gmail.com> <20250418170834.248318-4-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250418170834.248318-4-nifan.cxl@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KysHkr-EYbR61nIxp_EneqeTlpHALGMoco9Ss5rAwKE_1745312176 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A9A7D140003 X-Stat-Signature: cz1naqtm6beet7t4r4t7xx8enuofiyi4 X-Rspam-User: X-HE-Tag: 1745312180-532507 X-HE-Meta: U2FsdGVkX1+oTyJuWcuxqD8ed/q9DgEfKmIcCZGeM3epLCOiumTIGqc9A2aSJuwUtqy6ncTUdM012ldIbxCSvxPr2XHgZoOb4S1y1V4vT3/4g37SytHMjT9GaJwZVPTQl/jEOCDZqyblxiAg9rHdBZLs5SJVB6xy4E6E5zp8yHN6+Oiff2WP9B5MGuMn5N7I12iOh/TKg53GylQbQEWVMnlZlKNreo71LDvk6RR4fzefmzPOKMntNxbmqct1Hl89E/vEUrT2pIru0qBCTxsmGHYc6mn+X5NG8mu9gvjJ8QMNC0Q+jeM3XewVlKSjQ6I+5sZKsSzaO2FDDIIeYQFJaCuHg28edPDSRO89sixUGKAYsNyPS7nnrkNAH7dMzczOTu4b53EV8MIyO9Ytsz0uPYczNgCf2elNNx32zIASUN3m6UZb5PJZawHWedwwdLaBxakpKaEEwiFaEsH7QnI322p34gqh92kmFfUUbIGlAgG1nyBgs0UaAeJavL3Pxp+TNq9bqVvXGtgzjBkAsHfVNHJZUfjW3c3Gt+/9uqg7HQcE+CbPWUfAwIkl+yr0LHtUUPgxYT0VjVyo5LBdQVwJ1ZoLu+QXgqzfMUD2jGcrSD2eQ/mPehLWjt4e3IrUmUSF1L801KUsh9BSIu22WGEdEcr9aR7VMQeoYHz4vGitXFO31KTHF8P2viVJbpf1cvudq6LXkDzyeE2oLnYlyTOrILCHM8u2BqljpgaO441+6W2PDFnMWydnTU1SJdNbeYpyU5Gm69n6wozk4ipHjMArKJGxFQAVOwCQebS10DIANUMlai7K0roaXJxyvfvpPR8T6/hIoia2XWcFdEm7mjkm1U3T70K52DUYBrb29k9oZiwwbAihTNJBAVC5SnxYUbGp0cddLjz1OJz1jRkiOllQwCGyKRmOLjNFdUawfEWsL4nwo7yLWDjlKrq6L63CsblUlaT2DS1W5CpFNB84xpP IAUDjr9H gFvcOAmjKcLouytbAZQz0h6JOdT1whGVgPe6TJomElTATMiv+IKxVqfcYyvCGQpep84mHkRu2SV/AYfQpGb4WviFJD17+TIxt8bNq/h8VYgHLtZkK11cAUxRgT0GTzI46iTPbieBIVK73mL/o0zR62ksgKWzT0yz2D40UwN5x1FubsoyAJBqRFaqMMI9NDxwWMFHMRRweG6m1HC3yDYJDrPniDzVAEvQo3X3ZmvCvqAAhvIO63ZoA4HkOrxuSPjwdzzqHt5swczuPPHecIzxvYV9FygR1kMH6xOPjutQD+5rzcvjOMPJWm05v+SS3gAVlW8yXqAfN3IC5n79EoPr3NSp4btOSQ4xoYVss5TmTPaV1FBzTK7Ptz0p6hONk7Xlzc+VLyvS5lvbLmF4mxjAAYTGF7A6/U6NIN+VkwqmYr7/C2y591NwiwAdE4Hjt7ZsWChWxi97rRuOzCt61mx20GeDqbh2XwF2cii9/MSIHDoh5y29ND4iugB0Wirvd+C7qvWEwXUIsD7Hwr8N8hSJOBSpFJJAfnzx2+DhOJ6LhXMWAUwca/du3HvJetdumgXY6vxMAUKy2DawKZN7P3X7fBkQ7aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.04.25 18:57, nifan.cxl@gmail.com wrote: > From: Fan Ni > > The function __unmap_hugepage_range() has two kinds of users: > 1) unmap_hugepage_range(), which passes in the head page of a folio. > Since unmap_hugepage_range() already takes folio and there are no other > uses of the folio struct in the function, it is natural for > __unmap_hugepage_range() to take folio also. > 2) All other uses, which pass in NULL pointer. > > In both cases, we can pass in folio. Refactor __unmap_hugepage_range() to > take folio. > > Signed-off-by: Fan Ni > --- > v2: fixed issue mentioned here: > https://lore.kernel.org/linux-mm/aAHUluy7T32ZlYg7@debian/T/#m2b9cc1743e1907e52658815b297b9d249474f387 > > v1: > https://lore.kernel.org/linux-mm/aAHUluy7T32ZlYg7@debian/T/#m738e9e7f7d7fe4aab6b21782b4658dd65abf8fc4 > --- > > include/linux/hugetlb.h | 4 ++-- > mm/hugetlb.c | 10 +++++----- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index b7699f35c87f..ebaf95231934 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -133,7 +133,7 @@ void unmap_hugepage_range(struct vm_area_struct *, > void __unmap_hugepage_range(struct mmu_gather *tlb, > struct vm_area_struct *vma, > unsigned long start, unsigned long end, > - struct page *ref_page, zap_flags_t zap_flags); > + struct folio *ref_folio, zap_flags_t zap_flags); > void hugetlb_report_meminfo(struct seq_file *); > int hugetlb_report_node_meminfo(char *buf, int len, int nid); > void hugetlb_show_meminfo_node(int nid); > @@ -452,7 +452,7 @@ static inline long hugetlb_change_protection( > > static inline void __unmap_hugepage_range(struct mmu_gather *tlb, > struct vm_area_struct *vma, unsigned long start, > - unsigned long end, struct page *ref_page, > + unsigned long end, struct folio *ref_folio, > zap_flags_t zap_flags) > { Same comment as for the previous patch, can we just call this "folio" instead of "ref_folio" if we are already touching it? -- Cheers, David / dhildenb